[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Julian Mauricechanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Frédéric Demianschanged: What|Removed |Added CC||frede...@tamil.fr --- Comment #8 from Frédéric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Brendan Gallagherchanged: What|Removed |Added Attachment #45208|0 |1 is obsolete|| --- Comment #5 from Brendan Gallagher --- Created attachment 46056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46056=edit Bug 15217 Remove redundant duplicate var declaration remove superfluous second declaration of template, borrowernumber and cookie which are never used Also removed the variables @results and @results_array which are declared but not used Signed-off-by: Frédéric Demians As suggested by Colin, perl -wc catalogue/search.pl doesn't complain anymore after applying the patch. perlcritic confirms the 2 variables were unused. Signed-off-by: Katrin Fischer Signed-off-by: Brendan A Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Brendan Gallagherchanged: What|Removed |Added CC||bren...@bywatersolutions.co ||m --- Comment #6 from Brendan Gallagher --- pushed to master - thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Brendan Gallagherchanged: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischerchanged: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Attachment #45017|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischerchanged: What|Removed |Added Attachment #45156|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 45208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45208=edit [PASSED QA] Bug 15217 Remove redundant duplicate var declaration remove superfluous second declaration of template, borrowernumber and cookie which are never used Also removed the variables @results and @results_array which are declared but not used Signed-off-by: Frédéric Demians As suggested by Colin, perl -wc catalogue/search.pl doesn't complain anymore after applying the patch. perlcritic confirms the 2 variables were unused. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 --- Comment #3 from Frédéric Demians--- Created attachment 45156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45156=edit Bug 15217 Remove redundant duplicate var declaration remove superfluous second declaration of template, borrowernumber and cookie which are never used Also removed the variables @results and @results_array which are declared but not used Signed-off-by: Frédéric Demians As suggested by Colin, perl -wc catalogue/search.pl doesn't complain anymore after applying the patch. perlcritic confirms the 2 variables were unused. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Colin Campbellchanged: What|Removed |Added Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 45016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45016=edit Proposed Patch Simple test: applying the patch removes the compile-time warnings displayed on perl -wc catalogue/search.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Colin Campbellchanged: What|Removed |Added Attachment #45016|0 |1 is obsolete|| --- Comment #2 from Colin Campbell --- Created attachment 45017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45017=edit Amended patch Added removal of declarations of two unused variables to patch to aid in decluttering the source -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/