[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Blocks||16015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 [Bug 16015] Cannot delete a group of libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Julian Mauricechanged: What|Removed |Added Blocks||15586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 [Bug 15586] References to Koha::Branches remain in unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Brendan Gallagherchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Blocks||4941 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 --- Comment #12 from Jonathan Druart--- (In reply to Brendan Gallagher from comment #9) > Didn't apply cleanly for me - can you rebase this Jonathan? (ping me when > you've rebased so I can test it and push it). > > Thanks! Trivial conflicts with bug 15373, bug 13517 and bug 13853 fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Attachment #45922|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 46219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46219=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Attachment #45923|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 46220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46220=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Brendan Gallagherchanged: What|Removed |Added CC||bren...@bywatersolutions.co ||m --- Comment #9 from Brendan Gallagher --- Didn't apply cleanly for me - can you rebase this Jonathan? (ping me when you've rebased so I can test it and push it). Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoizechanged: What|Removed |Added Attachment #45747|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 45923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45923=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoizechanged: What|Removed |Added Attachment #45746|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 45922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45922=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoizechanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Martin Renvoizechanged: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Much needed architectural work, which I can't find any regressions in. Passing QA, well done Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Marc Véronchanged: What|Removed |Added Attachment #45366|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 45746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45746=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Marc Véronchanged: What|Removed |Added Attachment #45744|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 45747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45747=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Marc Véronchanged: What|Removed |Added Attachment #45367|0 |1 is obsolete|| --- Comment #3 from Marc Véron --- Created attachment 45744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45744=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Blocks||15295 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 --- Comment #1 from Jonathan Druart--- Created attachment 45366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45366=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 --- Comment #2 from Jonathan Druart--- Created attachment 45367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45367=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druartchanged: What|Removed |Added Blocks||15293 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/