[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Iming Chan changed: What|Removed |Added Summary|Koha Item Type sorted by|Koha Item Type sorted by |Code instead of Description |Codes instead of ||Descriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #1 from Jonathan Druart --- Created attachment 46257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46257&action=edit Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #2 from Jonathan Druart --- Created attachment 46258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46258&action=edit Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15354 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #3 from Marc Véron --- Testing: Without patches: - Order in dropdown list of Koha item types is wrong (not alphabetically). - t/db_dependent/Koha.t passes green With first patch (tests): - t/db_dependent/Koha.t does not pass (not ok 10 - GetItemTypes test) (as expected) With second patch applied: - Order in dropdown is alphabetically (as expected) - t/db_dependent/Koha.t passes green (as expected) Going to sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc Véron changed: What|Removed |Added Attachment #46257|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 46274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46274&action=edit Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc See comment #3 Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc Véron changed: What|Removed |Added Attachment #46258|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 46275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46275&action=edit Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Jonathan, this doesn't appear to work for me. I changed the english and the default description of my BK itemtype to "Z" - but it still appears first in list when adding a new item? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #9 from Katrin Fischer --- I have no idea why, but 'Zooks' stays on top of list in the edit item screen no matter what I do. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #10 from Jonathan Druart --- Could you try to debug around cataloguing/additem.pl l.178 to 190? The GetItemTypes subroutine is called to construct the item types. $itemtypes should be an arrayref of item types, ordered by descriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #11 from Katrin Fischer --- I think it must have been some hidden whitespace. I reentered all descriptions, didn't notice an additional space, but after that - it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What|Removed |Added Attachment #46274|0 |1 is obsolete|| Attachment #46275|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 46497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46497&action=edit [PASSED QA] Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc See comment #3 Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #13 from Katrin Fischer --- Created attachment 46498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46498&action=edit [PASSED QA] Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher --- Pushed to master - thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||julian.maur...@biblibre.com --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
