[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Jonathan Druart changed: What|Removed |Added Blocks||15342 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #2 from Jonathan Druart --- Not that this patch could be improved and the call to GetMember removed. But to be easily backportable, I'd prefer to keep it light. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #1 from Jonathan Druart --- Created attachment 45553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45553&action=edit Bug 15344: Remove unucessary call to GetMemberDetails This subroutine does a lot a processing and should only be called when necessary. In the get_template_and_user subroutine (so called from any pages of Koha), it is call to pass the branchcode, title, firstname, surname and borrowernumber values for the logged in user. This subroutine calls GetMemberAccountRecords which retrieve the items infos for all accountlines entries of the logged in user. On members/members.pl, let's say you have 74 entries in the accountlines tables, the page will execute 115 SELECT instead of 35 if you don't have any accountlines entries. With this patch, the number of SELECT is always 31. To test this patch you should have technical skills to know what to do. Note that USER_INFO was an array of... 1 element. Now it's a hashref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #3 from Jonathan Druart --- Created attachment 45560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45560&action=edit Bug 15344: Remove some other calls of GetMemberDetails from pl scripts Same as previously. For these files it's a bit less obvious. To make sure these changes won't introduce any regression, check that the variable returned by GetMember is never used to get something else than a borrower fields. The 'flags' should not be get neither. For opac-user.tt it's different, other keys are got but there are defined in the pl script. On the way: - 'showname' is removed (never used) - fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs OPACPatronDetails) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Marc Véron changed: What|Removed |Added Attachment #45553|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 45604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45604&action=edit Bug 15344: Remove unucessary call to GetMemberDetails This subroutine does a lot a processing and should only be called when necessary. In the get_template_and_user subroutine (so called from any pages of Koha), it is call to pass the branchcode, title, firstname, surname and borrowernumber values for the logged in user. This subroutine calls GetMemberAccountRecords which retrieve the items infos for all accountlines entries of the logged in user. On members/members.pl, let's say you have 74 entries in the accountlines tables, the page will execute 115 SELECT instead of 35 if you don't have any accountlines entries. With this patch, the number of SELECT is always 31. To test this patch you should have technical skills to know what to do. Note that USER_INFO was an array of... 1 element. Now it's a hashref. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Marc Véron changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Marc Véron changed: What|Removed |Added Attachment #45560|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 45605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45605&action=edit Bug 15344: Remove some other calls of GetMemberDetails from pl scripts Same as previously. For these files it's a bit less obvious. To make sure these changes won't introduce any regression, check that the variable returned by GetMember is never used to get something else than a borrower fields. The 'flags' should not be get neither. For opac-user.tt it's different, other keys are got but there are defined in the pl script. On the way: - 'showname' is removed (never used) - fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs OPACPatronDetails) Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Kyle M Hall changed: What|Removed |Added Attachment #45604|0 |1 is obsolete|| Attachment #45605|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 45848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45848&action=edit Bug 15344: Remove unucessary call to GetMemberDetails This subroutine does a lot a processing and should only be called when necessary. In the get_template_and_user subroutine (so called from any pages of Koha), it is call to pass the branchcode, title, firstname, surname and borrowernumber values for the logged in user. This subroutine calls GetMemberAccountRecords which retrieve the items infos for all accountlines entries of the logged in user. On members/members.pl, let's say you have 74 entries in the accountlines tables, the page will execute 115 SELECT instead of 35 if you don't have any accountlines entries. With this patch, the number of SELECT is always 31. To test this patch you should have technical skills to know what to do. Note that USER_INFO was an array of... 1 element. Now it's a hashref. Signed-off-by: Marc Véron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #7 from Kyle M Hall --- Created attachment 45849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45849&action=edit Bug 15344: Remove some other calls of GetMemberDetails from pl scripts Same as previously. For these files it's a bit less obvious. To make sure these changes won't introduce any regression, check that the variable returned by GetMember is never used to get something else than a borrower fields. The 'flags' should not be get neither. For opac-user.tt it's different, other keys are got but there are defined in the pl script. On the way: - 'showname' is removed (never used) - fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs OPACPatronDetails) Signed-off-by: Marc Véron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||julian.maur...@biblibre.com --- Comment #9 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344
--- Comment #10 from Jonathan Druart
---
Check out explodes with a software error:
Can't use string ("1900156") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/Circulation.pm line 813.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #12 from Jonathan Druart --- Kyle and Julian, Have a quick look at the third patch, it fixes a blocking issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344
--- Comment #11 from Jonathan Druart
---
Created attachment 46121
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46121&action=edit
Bug 15344: Remove one occurrence in circ/circulation.pl
In C4::Circulation::CanBookBeIssued, $borrower->{flags} is called and
should be populated by GetMemberDetails
It fixes the following error on checking out:
Can't use string ("1900156") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/Circulation.pm line 813.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344
Marc Véron changed:
What|Removed |Added
Attachment #46121|0 |1
is obsolete||
--- Comment #13 from Marc Véron ---
Created attachment 46129
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46129&action=edit
Bug 15344: Remove one occurrence in circ/circulation.pl
In C4::Circulation::CanBookBeIssued, $borrower->{flags} is called and
should be populated by GetMemberDetails
It fixes the following error on checking out:
Can't use string ("1900156") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/Circulation.pm line 813.
Note: Error occurs with patrons with staff permissions, not with 'normal'
patrons.
Error is fixed with this patch.
Signed-off-by: Marc Véron
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Marc Véron changed: What|Removed |Added Severity|major |blocker --- Comment #14 from Marc Véron --- Setting to blocker because of software error while checking out to patron with staff permissions. Issue is fixed by Jonathan's latest patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #15 from Frédéric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344
--- Comment #16 from Marc Véron ---
(In reply to Frédéric Demians from comment #15)
> This patch has been pushed to 3.20.x, will be in 3.20.8.
Was it pushed without the third patch? - That would be a blocker, because I
still get the error from comment #13 (on master), and it seems that the third
patch that fixes it is not on master.
The offending line is #273 in circ/circulation.pl, we need the member details
here (for useres with staff permission), otherwise we get the software error:
Can't use string ("1") as a HASH ref while "strict refs" in use at
/usr/share/kohaclone/C4/Circulation.pm line 815.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #17 from Frédéric Demians --- Marc and Johnatan, thanks. I confirm 3rd patch is required. I've pushed it directly to 3.20.x branch. It still has to be pushed to master/stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #18 from Kyle M Hall --- (In reply to Frédéric Demians from comment #17) > Marc and Johnatan, thanks. I confirm 3rd patch is required. I've pushed it > directly to 3.20.x branch. It still has to be pushed to master/stable. Third patch has been pushed to master! Thanks for the followup Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #19 from Julian Maurice --- (In reply to Kyle M Hall from comment #18) > Third patch has been pushed to master! Pushed to 3.22.x as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Katrin Fischer changed: What|Removed |Added Blocks||15511 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 [Bug 15511] Tabbed fines display on OPAC patron summary page broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Jonathan Druart changed: What|Removed |Added Blocks||16009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 [Bug 16009] crash displaying pending offline circulations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
