[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #136 from Caroline Cyr La Rose --- (In reply to Katrin Fischer from comment #135) > Should this be needs documenting? I don,t think so. I already submitted something to the manual for this last week. I left it "Pushed to master" because to me, that means release maintainers haven't decided to backport it or not. If they have decided not to backport it, it can be set to resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting --- Comment #135 from Katrin Fischer --- Should this be needs documenting? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Caroline Cyr La Rose changed: What|Removed |Added Documentation||Caroline Cyr La Rose contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/665 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Blocks||32504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504 [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in table settings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Bug 15348 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement allows you |This enhancement allows you release notes|to specify an estimated |to specify an estimated |delivery date per order.|delivery date per order |The specified estimated |line. The specified |delivery date is also |estimated delivery date is |considered (alongside the |also considered (alongside |calculated estimated|the calculated estimated |delivery date, if no date |delivery date, if no date |has been specified) when|has been specified) when |searching for late orders |searching for late orders |and exporting late orders. |and exporting late orders. |You can also edit the |You can also edit the |estimated delivery date |estimated delivery date |from the late orders page. |from the late orders page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master --- Comment #134 from Katrin Fischer --- Follow-ups have been pushed now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #133 from Katrin Fischer --- Last 3 commits haven't been pushed yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #132 from Katrin Fischer --- Hi Tomas, did you miss these? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Bug 15348 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #143903|0 |1 is obsolete|| --- Comment #131 from Katrin Fischer --- Created attachment 143904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143904&action=edit Bug 15348: (follow-up) Fix modals to pre-set input with stored date Makes sure that when an estimated delivery day is edited using the modals on the basket summary or late order pages, the date input is pre-set to the stored estimated delivery date. To test: * Create some order lines with and without estimated delivery date set * Make sure that on the basket summary the edit link comes up with an empty modal * Close the basket * Check that on late orders the dates are pre-filled incorrectly as well * Apply patch * Refresh basket summary and late order pages * All edit links now should bring up the modal with the correct date filled in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #130 from Katrin Fischer --- Thanks Owen for the hints and explanations! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #129 from Katrin Fischer --- Created attachment 143903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143903&action=edit Bug 15348: (follow-up) Fix modals to pre-set input with stored date Makes sure that when an estimated delivery day is edited using the modals on the basket summary or late order pages, the date input is pre-set to the stored estimated delivery date. To test: * Create some order lines with and without estimated delivery date set * Make sure that on the basket summary the edit link comes up with an empty modal * Close the basket * Check that on late orders the dates are pre-filled incorrectly as well * Apply patch * Refresh basket summary and late order pages * All edit links now should bring up the modal with the correct date filled in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #128 from Katrin Fischer --- I believe the first fix is what Joubu asked for and the second is something I found while testing. I have a remaining issue: when clicking on 'edit' from basket, the date in the modal is no longer pre-set with the stored date. This might also appear in other spots where the modal is used (late orders). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #127 from Katrin Fischer --- Created attachment 143900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143900&action=edit Bug 15348: Store estimated delivery date when adding an order When the estimated delivery date was entered on adding or modifying and order, it was not saved to the database. To test: * Add new order, fill in estimated delivery date * Save * Verify the estimated delivery date is empty * Modify order line, date will also not be saved * Apply patch * The date should now save and update correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #126 from Katrin Fischer --- Created attachment 143896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143896&action=edit Bug 15348: (follow-up) Fix filters on input fields With bug 30718 we on longer need the KohaDates TT filter on the inputs. This patch removes them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #125 from Katrin Fischer --- (In reply to Jonathan Druart from comment #124) > This does not work. > > Because of bug 30718 you don't need the KohaDates filter on the flatpickr's > input. > The commit "Fix calendar widget" is actually messing with the date. > > The bug I found appears when you edit an order. I think there was an overlap in development/time gap between this passing and being pushed. Can you explain more what needs to be fixed/what is broken? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --- Comment #124 from Jonathan Druart --- This does not work. Because of bug 30718 you don't need the KohaDates filter on the flatpickr's input. The commit "Fix calendar widget" is actually messing with the date. The bug I found appears when you edit an order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |FIXED --- Comment #123 from Lucas Gass --- Enchancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Bug 15348 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #122 from Tomás Cohen Arazi --- Created attachment 140735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140735&action=edit Bug 15348: Add estimated_delivery_date to object spec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #121 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #120 from Tomás Cohen Arazi --- Created attachment 140708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140708&action=edit Bug 15348: (QA follow-up) DB update fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #119 from Katrin Fischer --- Rebased, tests pass and retested functionality on addorder.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139365|0 |1 is obsolete|| --- Comment #118 from Katrin Fischer --- Created attachment 139845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139845&action=edit Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139364|0 |1 is obsolete|| --- Comment #117 from Katrin Fischer --- Created attachment 139844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139844&action=edit Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139363|0 |1 is obsolete|| --- Comment #116 from Katrin Fischer --- Created attachment 139843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139843&action=edit Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139361|0 |1 is obsolete|| --- Comment #114 from Katrin Fischer --- Created attachment 139841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139841&action=edit Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139362|0 |1 is obsolete|| --- Comment #115 from Katrin Fischer --- Created attachment 139842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139842&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139360|0 |1 is obsolete|| --- Comment #113 from Katrin Fischer --- Created attachment 139840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139840&action=edit Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139359|0 |1 is obsolete|| --- Comment #112 from Katrin Fischer --- Created attachment 139839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139839&action=edit Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139358|0 |1 is obsolete|| --- Comment #111 from Katrin Fischer --- Created attachment 139838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139838&action=edit Bug 15348: (follow-up) Update calendar widget to flatpickr Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139357|0 |1 is obsolete|| --- Comment #110 from Katrin Fischer --- Created attachment 139837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139837&action=edit Bug 15348: (follow-up) Fix imports in moddeliverydate.pl Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139356|0 |1 is obsolete|| --- Comment #109 from Katrin Fischer --- Created attachment 139836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139836&action=edit Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139355|0 |1 is obsolete|| --- Comment #108 from Katrin Fischer --- Created attachment 139835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139835&action=edit Bug 15348: (follow-up) Fix TT filters from html to uri Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139354|0 |1 is obsolete|| --- Comment #107 from Katrin Fischer --- Created attachment 139834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139834&action=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139353|0 |1 is obsolete|| --- Comment #106 from Katrin Fischer --- Created attachment 139833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139833&action=edit Bug 15348: trivial code simplification Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139352|0 |1 is obsolete|| --- Comment #105 from Katrin Fischer --- Created attachment 139832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139832&action=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139351|0 |1 is obsolete|| --- Comment #104 from Katrin Fischer --- Created attachment 139831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139831&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply Depends on||29955 CC||tomasco...@gmail.com --- Comment #103 from Tomás Cohen Arazi --- Hi, please rebase. Bug 29955 made a small change that makes the first patch fail to apply. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #102 from Katrin Fischer --- (In reply to Martin Renvoize from comment #101) > Happy to coach on converting to API later btw.. it would be good to get more > devs up to speed on it.. I'm under no illusions there are certainly rough > edges still ;P Planning to 'harass' you guys for helping me sort the API related pages in the wiki once the update has happened, we have a lot of pages but I have no idea which information is actually current. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #101 from Martin Renvoize --- Happy to coach on converting to API later btw.. it would be good to get more devs up to speed on it.. I'm under no illusions there are certainly rough edges still ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #100 from Martin Renvoize --- The code works and there are no obvious regressions.. QA scripts are also happy.. I don't really understand why we introduce a new controller here where an API would have made more sense.. code only appears to have been submitted in 2020 and the API was already starting to get a lot more use. Passing QA however.. it just means more work for someone down the line to update it to use API's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139343|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 139365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139365&action=edit Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139342|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 139364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139364&action=edit Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139341|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 139363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139363&action=edit Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139340|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 139362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139362&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139339|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 139361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139361&action=edit Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139338|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 139360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139360&action=edit Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139337|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 139359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139359&action=edit Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139336|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 139358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139358&action=edit Bug 15348: (follow-up) Update calendar widget to flatpickr Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139335|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 139357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139357&action=edit Bug 15348: (follow-up) Fix imports in moddeliverydate.pl Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139334|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 139356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139356&action=edit Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139333|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 139355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139355&action=edit Bug 15348: (follow-up) Fix TT filters from html to uri Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139332|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 139354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139354&action=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139331|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 139353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139353&action=edit Bug 15348: trivial code simplification Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139330|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 139352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139352&action=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Martin Renvoize changed: What|Removed |Added Attachment #139329|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize --- Created attachment 139351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139351&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139301|0 |1 is obsolete|| --- Comment #84 from Katrin Fischer --- Created attachment 139343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139343&action=edit Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139274|0 |1 is obsolete|| --- Comment #83 from Katrin Fischer --- Created attachment 139342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139342&action=edit Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #139245|0 |1 is obsolete|| --- Comment #82 from Katrin Fischer --- Created attachment 139341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139341&action=edit Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138540|0 |1 is obsolete|| --- Comment #81 from Katrin Fischer --- Created attachment 139340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139340&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138539|0 |1 is obsolete|| --- Comment #80 from Katrin Fischer --- Created attachment 139339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139339&action=edit Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138538|0 |1 is obsolete|| --- Comment #79 from Katrin Fischer --- Created attachment 139338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139338&action=edit Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138537|0 |1 is obsolete|| --- Comment #78 from Katrin Fischer --- Created attachment 139337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139337&action=edit Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138536|0 |1 is obsolete|| --- Comment #77 from Katrin Fischer --- Created attachment 139336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139336&action=edit Bug 15348: (follow-up) Update calendar widget to flatpickr Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138535|0 |1 is obsolete|| --- Comment #76 from Katrin Fischer --- Created attachment 139335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139335&action=edit Bug 15348: (follow-up) Fix imports in moddeliverydate.pl Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138534|0 |1 is obsolete|| --- Comment #75 from Katrin Fischer --- Created attachment 139334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139334&action=edit Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138533|0 |1 is obsolete|| --- Comment #74 from Katrin Fischer --- Created attachment 139333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139333&action=edit Bug 15348: (follow-up) Fix TT filters from html to uri Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138532|0 |1 is obsolete|| --- Comment #73 from Katrin Fischer --- Created attachment 139332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139332&action=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138531|0 |1 is obsolete|| --- Comment #72 from Katrin Fischer --- Created attachment 139331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139331&action=edit Bug 15348: trivial code simplification Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138530|0 |1 is obsolete|| --- Comment #71 from Katrin Fischer --- Created attachment 139330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139330&action=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer changed: What|Removed |Added Attachment #138529|0 |1 is obsolete|| --- Comment #70 from Katrin Fischer --- Created attachment 139329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139329&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Christian Stelzenmüller Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #69 from Katrin Fischer --- Handing over to Martin for final QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #68 from Katrin Fischer --- Created attachment 139301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139301&action=edit Bug 15348: (follow-up) Fix pre-selected date when editing from late orders page When editing the estimated delivery date from the late orders page, with multiple late orders, the selected date in the edit form would always be the same, not matching the edited date. With this page, the edited date will match what is shown in the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #67 from Katrin Fischer --- Created attachment 139274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139274&action=edit Bug 15348: (follow-up) Fix sorting of estimated delivery date on basket summary page Also removes some unneded variables from the table footers that are used to display amount totals. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #66 from Katrin Fischer --- Created attachment 139245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139245&action=edit Bug 15348: (follow-up) Move estimated delivery date before supplier report and fix column settings On the basket summary page the estimated delivery date column was moved before the supplier report column, that is only visible when EDIFACT has been activated. It also adds the new column to the table configuration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Text to go in the||This enhancement allows you release notes||to specify an estimated ||delivery date per order. ||The specified estimated ||delivery date is also ||considered (alongside the ||calculated estimated ||delivery date, if no date ||has been specified) when ||searching for late orders ||and exporting late orders. ||You can also edit the ||estimated delivery date ||from the late orders page. Version(s)|This enhancement allows you | released in|to specify an estimated | |delivery date per order.| |The specified estimated | |delivery date is also | |considered (alongside the | |calculated estimated| |delivery date, if no date | |has been specified) when| |searching for late orders | |and exporting late orders. | |You can also edit the | |estimated delivery date | |from the late orders page. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #65 from Aleisha Amohia --- Changing status to reflect signoffs from Christian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #138491|0 |1 is obsolete|| --- Comment #64 from sandbo...@biblibre.com --- Created attachment 138540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138540&action=edit Bug 15348: (follow-up) Fix filtering results on estimated delivery date Adding another clause to the SQL so that the specified estimated delivery date is used for filtering first, and the calculated delivery date is used if there is no specified estimated delivery date. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #138110|0 |1 is obsolete|| --- Comment #63 from sandbo...@biblibre.com --- Created attachment 138539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138539&action=edit Bug 15348: (follow-up) Fix modal to edit delivery date This allows you to empty the delivery date and ensures the current date shows Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137743|0 |1 is obsolete|| --- Comment #62 from sandbo...@biblibre.com --- Created attachment 138538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138538&action=edit Bug 15348: DBIC changes DO NOT PUSH For testing purposes Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137742|0 |1 is obsolete|| --- Comment #61 from sandbo...@biblibre.com --- Created attachment 138537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138537&action=edit Bug 15348: (follow-up) Fix calendar widget, translateability, etc Also add functionality to edit the estimated delivery date from a closed basket. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137099|0 |1 is obsolete|| --- Comment #60 from sandbo...@biblibre.com --- Created attachment 138536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138536&action=edit Bug 15348: (follow-up) Update calendar widget to flatpickr Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137098|0 |1 is obsolete|| --- Comment #59 from sandbo...@biblibre.com --- Created attachment 138535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138535&action=edit Bug 15348: (follow-up) Fix imports in moddeliverydate.pl Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137058|0 |1 is obsolete|| --- Comment #58 from sandbo...@biblibre.com --- Created attachment 138534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138534&action=edit Bug 15348: (follow-up) Fix export of dt_from_string FAIL acqui/addorder.pl FAIL valid " dt_from_string " is not exported by the Koha::DateUtils module Can't continue after import errors Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #137057|0 |1 is obsolete|| --- Comment #57 from sandbo...@biblibre.com --- Created attachment 138533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138533&action=edit Bug 15348: (follow-up) Fix TT filters from html to uri Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136563|0 |1 is obsolete|| --- Comment #56 from sandbo...@biblibre.com --- Created attachment 138532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138532&action=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136562|0 |1 is obsolete|| --- Comment #55 from sandbo...@biblibre.com --- Created attachment 138531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138531&action=edit Bug 15348: trivial code simplification Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136561|0 |1 is obsolete|| --- Comment #54 from sandbo...@biblibre.com --- Created attachment 138530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138530&action=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 sandbo...@biblibre.com changed: What|Removed |Added Attachment #136560|0 |1 is obsolete|| --- Comment #53 from sandbo...@biblibre.com --- Created attachment 138529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138529&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
