[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

--- Comment #11 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Julian Maurice  ---
Patch pushed in 3.22.x, will be in 3.22.2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #9 from Brendan Gallagher  ---
Pushed to master - thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #45827|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 46032
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46032&action=edit
Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration >
Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into
a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

Signed-off-by: Hector Castro 
Works well for translation purpose

Bug 15363: (followup) Move tags inside if statements

Followup for comment #3

Signed-off-by: Jonathan Druart 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45671|0   |1
is obsolete||
  Attachment #45819|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 45827
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45827&action=edit
Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration >
Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into
a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

Signed-off-by: Hector Castro 
Works well for translation purpose

Bug 15363: (followup) Move tags inside if statements

Followup for comment #3

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

--- Comment #6 from Marc Véron  ---
Created attachment 45819
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45819&action=edit
Bug 15363: (followup) Move tags inside if statements

Followup for comment #3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

--- Comment #5 from Jonathan Druart  
---
No, I meant:
[% IF %]itemtypes[% ELSE %]ccodehttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

--- Comment #4 from Marc Véron  ---
(In reply to Jonathan Druart from comment #3)
> With this patch, we get
>   msgid "%sFor all collection codes: %sFor all item types: %s"
> Dont you think it's better to have 2 different entries?
> 
> You just need to move the strong tag into the IF statement.

Hi Jonathan, do you mean the following?

[% IF ( limitType == 'ccode' ) %]For all collection
codes: [% ELSE %]For all item types: [% END %]Check all | Uncheck all

If yes, we have the string splitting again, no?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
With this patch, we get
  msgid "%sFor all collection codes: %sFor all item types: %s"
Dont you think it's better to have 2 different entries?

You just need to move the strong tag into the IF statement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
Summary|Translatability: Fix issue  |Translatability: Fix issue
   |with ambiguous 'all' on |with ambiguous 'all' on
   |Administration › Set|Administration > Set
   |library checkin and |library checkin and
   |transfer policy |transfer policy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #45616|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 45671
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45671&action=edit
[SIGNED-OFF]Bug 15363: Translatability: Fix issue with ambiguous 'all' on
Administration > Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into
a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

Signed-off-by: Hector Castro 
Works well for translation purpose

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

2015-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #45616|Bug 15363 - |Bug 15363 -
description|Translatability: Fix issue  |Translatability: Fix issue
   |with ambiguous 'all' on |with ambiguous 'all' on
   |Administration › Set|Administration > Set
   |library checkin and |library checkin and
   |transfer policy |transfer policy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration › Set library checkin and transfer policy

2015-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

--- Comment #1 from Marc Véron  ---
Created attachment 45616
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45616&action=edit
Bug 15363 - Translatability: Fix issue with ambiguous 'all' on Administration ›
Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into
a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15363] Translatability: Fix issue with ambiguous 'all' on Administration › Set library checkin and transfer policy

2015-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363

Marc Véron  changed:

   What|Removed |Added

   Severity|enhancement |trivial
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14459

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/