[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Blocks||20530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20530 [Bug 20530] trailing ':' in columns_settings.yml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #16 from Jonathan Druart --- (In reply to Benjamin Rokseth from comment #15) > Eh, this is already committed to master, no? Yep! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Benjamin Roksethchanged: What|Removed |Added CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #15 from Benjamin Rokseth --- Eh, this is already committed to master, no? https://github.com/Koha-Community/Koha/commit/fdc06dec2a6e827a5c04c048a0478a2f80d2cd76 https://github.com/Koha-Community/Koha/commit/8e997fbafcc635b275c6ca1211e47a4cd38c8140 https://github.com/Koha-Community/Koha/commit/5f5a7ffaf81a0eaa9240f0790f91b04503484552 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Brendan Gallagherchanged: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #14 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Kyle M Hallchanged: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #13 from Kyle M Hall --- (In reply to Jonathan Druart from comment #12) > (In reply to Owen Leonard from comment #11) > > (In reply to Kyle M Hall from comment #9) > > > > > Bug 15471 [QA Followup] - Fix error causing visibility button to not > > > display > > > > In my system this follow-up causes an error rather than fixing one. > > > > SyntaxError: expected expression, got ';' > > /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL_report=1 > > > > Line 269: > > > > var columns_settings = ; > > This is because bug 13618 has been reverted. > @RM Please revert this last patch. Done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #12 from Jonathan Druart--- (In reply to Owen Leonard from comment #11) > (In reply to Kyle M Hall from comment #9) > > > Bug 15471 [QA Followup] - Fix error causing visibility button to not display > > In my system this follow-up causes an error rather than fixing one. > > SyntaxError: expected expression, got ';' > /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL_report=1 > > Line 269: > > var columns_settings = ; This is because bug 13618 has been reverted. @RM Please revert this last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #11 from Owen Leonard--- (In reply to Kyle M Hall from comment #9) > Bug 15471 [QA Followup] - Fix error causing visibility button to not display In my system this follow-up causes an error rather than fixing one. SyntaxError: expected expression, got ';' /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL_report=1 Line 269: var columns_settings = ; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Brendan Gallagherchanged: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the may 2016 release. thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Kyle M Hallchanged: What|Removed |Added Attachment #46310|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 47692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47692=edit Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc Véron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #9 from Kyle M Hall--- Created attachment 47693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47693=edit Bug 15471 [QA Followup] - Fix error causing visibility button to not display Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Kyle M Hallchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Heather Braumchanged: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Arve Søreidechanged: What|Removed |Added CC||arve.sore...@kul.oslo.kommu ||ne.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Gaetan Boissonchanged: What|Removed |Added CC||gaetan.bois...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 claire.hernan...@biblibre.comchanged: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |BLOCKED CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Sally Healeychanged: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Julian Mauricechanged: What|Removed |Added Attachment #46259|0 |1 is obsolete|| --- Comment #4 from Julian Maurice --- Created attachment 46307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46307=edit Bug 15471: Add column settings and filters to Holds queue table Same patch with console.log removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #5 from Julian Maurice--- (In reply to Marc Véron from comment #2) > QA tools say: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >FAIL forbidden patterns > forbidden pattern: console.log (line 25) Sorry about that, this is fixed now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #6 from Marc Véron--- Filtering works OK and I can manage the columns in administration, but I do not see a 'Show / hide columns' on the page itself (like e.g. with the currency table). Should the patch be tested on top of 15285? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Marc Véronchanged: What|Removed |Added Attachment #46307|0 |1 is obsolete|| --- Comment #7 from Marc Véron --- Created attachment 46310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46310=edit Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Julian Mauricechanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #3 from Marc Véron--- Oh, sorry, I was not aware of the dependency: Bug 15285. Patch seems to work, though, behalve of the QA tools complaining (see comment #2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- QA tools say: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt FAIL forbidden patterns forbidden pattern: console.log (line 25) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #1 from Julian Maurice--- Created attachment 46259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46259=edit Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/