[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lisette Scheer changed: What|Removed |Added CC||lise...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |In Discussion --- Comment #166 from Victor Grousset/tuxayo --- Discussed in current hackfest, now that there is vue in Koha via the ERM patches, there isn't anything to salvage from the vue patch submitted here. Mostly because here it's vue 2 (ERM is vue 3) and some other technical reason IIUC. But there is also the fact that the vue patch here wasn't a clone of the react patch. But different UX also. So first step is to settle on what is wanted for circ rules interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Koha Team University Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #165 from Koha Team University Lyon 3 --- Hi, we would like to test this next week during the hackfest Marseille. Is someone still working on this ? Cheers, Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #164 from Victor Grousset/tuxayo --- IIUC, this needs a rebase and the continuation of comparing the two alternatives. No other blocker than playing with both and getting feedback right? (which is already quite some work ^^) There isn't yet one that has been chosen right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #163 from Katrin Fischer --- I think there are different use cases for what you check the editor for: 1) Editing a single rule 2) Editing multiple rules: It's common that libraries have a lot (like over a 100) of rows in the current table. And if you have to change a lot of them to extend renewals because of COVID, you want something comfortable. And once you are done: 3) Checking your entries are for a set of rules (show me rules x y z for a certain category, all for a certain library... all for a certain itemtype) correct. For this use case, you will want to see "more" 4) Look up all rules applying to a certain case (like a checked out item where you wonder about how the fines are set) I think Agustin's works well for 1) and 4). But I think the editable table styl works better for 2) and 3). It's quicker and more comfortable. I think usually you will go in to edit more than one rule. I think maybe we could refine the suggested grouping of rules a bit more: - checkout/loan period related - renewal related - fine related - holds related - article requests related And reduce the need to scroll horizontally this way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun |ommunity.org|ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #162 from Agustín Moyano --- (In reply to Katrin Fischer from comment #161) > (In reply to Kyle M Hall from comment #160) > > Of course. My honest opinion is that React vs Vue is not really an issue. I > > believe that we as developers are perfectly capable of using either one. On > > the other hand, a discussion of licensing and other social issue has merit. > > Glad to hear - I don't have any experience or opinion on either, but hope > that we can figure out what is best long term. I think we've got 2 discussions.. one is which technology fits better our needs (React vs Vue) and the other is how do we want our circulation rules revamped. What I don't like of current circulation rules is that it's hard (at least for me) to edit scrolling horizontally, plus if there are a lot of rules it's hard to read. I feel that with the React proposal (the model, not the technology) could potentially happen the same.. if you edit different rules of a category/item type, you may need to scroll horizontally too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #161 from Katrin Fischer --- (In reply to Kyle M Hall from comment #160) > Of course. My honest opinion is that React vs Vue is not really an issue. I > believe that we as developers are perfectly capable of using either one. On > the other hand, a discussion of licensing and other social issue has merit. Glad to hear - I don't have any experience or opinion on either, but hope that we can figure out what is best long term. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #160 from Kyle M Hall --- Of course. My honest opinion is that React vs Vue is not really an issue. I believe that we as developers are perfectly capable of using either one. On the other hand, a discussion of licensing and other social issue has merit. (In reply to Katrin Fischer from comment #159) > Hi Kyle, I believe we might want to have the discussion about Angular / Vue > and the functionality/GUI separately because both are different aspects. At > the moment Augustin's patch is a completely new way of doing this both > technically and in how the GUI is done. It's not a reimplementation of > Jesse's work. > > We might come to the conclusion that we want something similar to Jesse's > but written in Vue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #159 from Katrin Fischer --- (In reply to Kyle M Hall from comment #158) > > I think Augustin's does a little nicer job in showing which rule applies > > easily, but you have to make the necessary selections first. The first one I > > like better for a better/faster editing/adding experience. > > > > It's hard. > > I think there is one *big* difference that weighs heavily in my mind. Jesse > Weaver is no longer an active member in the Koha community, whereas Augustin > is. Augustin will be able to assist other developers in learning how to make > changes to the rules editor. If we go with Piano's version, we'll be left to > explore and understand it on our own. Hi Kyle, I believe we might want to have the discussion about Angular / Vue and the functionality/GUI separately because both are different aspects. At the moment Augustin's patch is a completely new way of doing this both technically and in how the GUI is done. It's not a reimplementation of Jesse's work. We might come to the conclusion that we want something similar to Jesse's but written in Vue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #158 from Kyle M Hall --- > I think Augustin's does a little nicer job in showing which rule applies > easily, but you have to make the necessary selections first. The first one I > like better for a better/faster editing/adding experience. > > It's hard. I think there is one *big* difference that weighs heavily in my mind. Jesse Weaver is no longer an active member in the Koha community, whereas Augustin is. Augustin will be able to assist other developers in learning how to make changes to the rules editor. If we go with Piano's version, we'll be left to explore and understand it on our own. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #157 from Katrin Fischer --- (In reply to Jonathan Druart from comment #156) > (In reply to Katrin Fischer from comment #155) > > The vue patches apply nicely, but the the other POC patches have too many > > conflicts. Would love to be able to compare a bit on the different design > > approaches. > > Use the remote branch at https://gitlab.com/joubu/Koha/commits/bug_15522 > Not up-to-date but you will be able to compare the 2 approaches. Augustin made a branch for me after I posted this and I had a look - I think both have advantages so it's really not an easy one. What I miss is an overview kind of page like we have now - not to use it for editing, but to easily see what applies and to be able to export/print when needed even. Not sure if that is something that has been considered as a possible part of the developments. I think Augustin's does a little nicer job in showing which rule applies easily, but you have to make the necessary selections first. The first one I like better for a better/faster editing/adding experience. It's hard. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #156 from Jonathan Druart --- (In reply to Katrin Fischer from comment #155) > The vue patches apply nicely, but the the other POC patches have too many > conflicts. Would love to be able to compare a bit on the different design > approaches. Use the remote branch at https://gitlab.com/joubu/Koha/commits/bug_15522 Not up-to-date but you will be able to compare the 2 approaches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #155 from Katrin Fischer --- The vue patches apply nicely, but the the other POC patches have too many conflicts. Would love to be able to compare a bit on the different design approaches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #154 from Agustín Moyano --- screenshot: https://snipboard.io/jIwD0s.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #153 from Agustín Moyano --- I've just added Vue alternative for circulation rules. I really, really, really don't like the uncomfortable huge rules table, so I took the liberty to propose a new design. Hope you like it and have fun. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #152 from Agustín Moyano --- Created attachment 112061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112061&action=edit Bug 15522: (Vue alternative) Add yarn.lock -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #151 from Agustín Moyano --- Created attachment 112060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112060&action=edit Bug 15522: (Vue alternative) Add vue scripts This patch adds vue scripts for circulation rules To test: 1. Apply all patches 2. restart_all 3. yarn install 4. yarn run build 5. go to circulation rules in staff interface You'll notice the working area is divided in 3 parts.. On the left you've got a list area. That list area has a combo where you can choose between libraries, patron categories and item types. What you choose there are the rules you'll be watching and editing. The middle area is where rules are shown. That area is divided by circulation rules, fines rules and hold rules, and each of that sections are divided by rules specific for libraries, libraries and categories, libraries and item types or libraries, categories and item types. To edit a rule click on the pencil icon in the section title. If you're editing default values (Values for all libraries, categories or item types) the corresponding edit control (input, select, etc) is shown. If you are editing for a particular library, category or item type, above the editing control you get a checkbox to use default value or to overwrite that rule. In the area to the right you've got a label with the currently selected library, category or item type. If when selecting items in the list area you do ctrl+click (cmd+click on mac) you can select multiple elements from the list. All selected elements will appear in the right area. Notice that only one of them is still selected. You can rapidly change from one selected item to the other by clicking on those labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #147 from Agustín Moyano --- Created attachment 112056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112056&action=edit Bug 15522: (Vue alternative) Remove old smart rules pages and scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #148 from Agustín Moyano --- Created attachment 112057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112057&action=edit Bug 15522: (Vue alternative) Add policy template and scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #149 from Agustín Moyano --- Created attachment 112058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112058&action=edit Bug 15522: (Vue alternative) Modify api endpoint for circ rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #150 from Agustín Moyano --- Created attachment 112059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112059&action=edit Bug 15522: (Vue alternative) Set gulp script and Makefile.PL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #146 from Martin Renvoize --- (In reply to Martin Renvoize from comment #144) > I can confirm the branch does work as expected (when you remember to run the > yarn commands 'yarn install && yarn build') > > We've had this branch checked out for a few days with PTFS-E staff testing, > and even had a feedback session with ByWater staff. > > Written feedback here to follow. OK.. so after conversing about this.. the tl:dr feedback was "We like it" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #145 from Julian Maurice --- This needs to be rebased (conflict on gulpfile.js - see bug 26228) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #144 from Martin Renvoize --- I can confirm the branch does work as expected (when you remember to run the yarn commands 'yarn install && yarn build') We've had this branch checked out for a few days with PTFS-E staff testing, and even had a feedback session with ByWater staff. Written feedback here to follow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #143 from Jonathan Druart --- Can you confirm you tried the yarn commands? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #142 from Katrin Fischer --- I tried with the remote branch (Got the Loading...) and I tried the patches here - do not apply. Which is the preferred for testing at the moment? And can I please get a rebase or fix? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #141 from Martin Renvoize --- Actually.. it's growing on me.. but I think a few of the grouping terms could be improved to clarify the views. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #140 from Martin Renvoize --- Rebased and swagger spec fixed so it can all be applied easily. Jury is out on whether it's an improvement in my opinion.. but I'm not a librarian working with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #139 from Martin Renvoize --- Created attachment 106926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106926&action=edit Bug 15522: (QA followup) Fix the swagger spec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101947|0 |1 is obsolete|| --- Comment #138 from Martin Renvoize --- Created attachment 106925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106925&action=edit Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101944|0 |1 is obsolete|| --- Comment #136 from Martin Renvoize --- Created attachment 106923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106923&action=edit Bug 15522: (follow-up) Fix circulation rules interface title inconsistency Follow-up to "Bug 15522: Remove old circulation rules interface" Instead of: "Circulation, fines and holds rules", use "Circulation, fines, and holds rules" for consistency Latter form already used in commit Bug 15522: New interface for updated circulation rules as follows koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:37: Circulation, fines, and holds rules koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:88: Circulation, fines, and holds rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101945|0 |1 is obsolete|| --- Comment #137 from Martin Renvoize --- Created attachment 106924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106924&action=edit Bug 15522: (follow-up) Add missing http return codes to api spec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101942|0 |1 is obsolete|| --- Comment #134 from Martin Renvoize --- Created attachment 106921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106921&action=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101943|0 |1 is obsolete|| --- Comment #135 from Martin Renvoize --- Created attachment 106922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106922&action=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101939|0 |1 is obsolete|| --- Comment #131 from Martin Renvoize --- Created attachment 106918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106918&action=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101941|0 |1 is obsolete|| --- Comment #133 from Martin Renvoize --- Created attachment 106920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106920&action=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101940|0 |1 is obsolete|| --- Comment #132 from Martin Renvoize --- Created attachment 106919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106919&action=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101938|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize --- Created attachment 106917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106917&action=edit Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101937|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 106916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106916&action=edit Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101935|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 106914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106914&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Attachment #101934|0 |1 is obsolete|| --- Comment #126 from Martin Renvoize --- Created attachment 106913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106913&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Martin Renvoize changed:
What|Removed |Added
Attachment #101936|0 |1
is obsolete||
--- Comment #128 from Martin Renvoize ---
Created attachment 106915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106915&action=edit
Bug 15522: New interface for updated circulation rules
Test plan:
1) Make sure all dependencies are applied, and that their DB upgrades
have been applied.
2) Build JS (see previous patches for HOWTO).
3) Load .../cgi-bin/koha/admin/policy.pl .
4) Try changing an existing rule (one with a textbox or dropdown). Hit
"Save rules", ensure that your changes are saved.
5) Until changes are saved, all cells that are changed or affected by
your changes should be highlighted in yellow.
6) Same as above, but deleting a rule by hitting the "x" next to it.
7) Add rows and columns using the "Choose rule..." and "Choose
category/item type..." dropdowns.
8) Add rules by clicking the pencil in a currently unset rule cell.
Ensure changes are saved.
9) Hit "Cleanup rules"; all redundant rules should be removed. As this
only removes rules that are the same as the defaults, this should
not change any effective rules.
10) Use the filters at the top right ("Circulation", "Holds" and
"Fines") to filter the kinds of rules that are shown.
11) Ensure that any desired library can be shown, including (if
selected) all at the same time.
JD edits: Removed the changes to filtered categories, will be done in a
follow-up
Signed-off-by: Lisette Scheer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #125 from Martin Renvoize --- Same result if I apply the patches here.. it's like the JS just doesn't load at all.. Not seeing any errors in the console and not failures in the networking tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #124 from Martin Renvoize --- If I try to test via the linked branch all I get is 'Loading, please wait...'.. am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #123 from Christopher Brannon --- Could columns be accordioned like rows? Maybe accordion each column, or groups according to topic? Then maybe a button/link that shows all or return to accordion? Sometimes we like to scan the page, and having all show as we scroll is good, but we don't want to scroll all the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #122 from Jessie Zairo --- I spent some time exploring the new layout, here is a summary of my notes. It is nice that if you don’t need to use a column in a certain table, you can set the default to null, save, and the column will be removed. This then creates a dropdown at the end that will allow all the users to add the column back in. Really makes for a clean interface if you have unused columns. It is great that the header floats, staff can easily save, cleanup rules, or apply filters wherever they are on the policy page. For large libraries with multiple branches or consortiums, the initial page, cgi-bin/koha/admin/policy.pl, is slow to load or reflect changes. It would be nice to have the left column and the header float when you are editing the rules. Currently, there is no way to see what rule/column you are editing (without scrolling back and forth). For the rules by category, when creating a new rule, it inserts the new rule alphabetically. For longer lists, you have to go back to find it to make any edits. Overall, this is a fantastic improvement to the matrix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #121 from Katrin Fischer --- (In reply to Jonathan Druart from comment #120) > (In reply to Nick Clemens from comment #119) > > Sponsoring library has approved, removing discussion status > > Could you share a summary of what has been tested and discussed? +1 For further testing - git branch or attached patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #120 from Jonathan Druart --- (In reply to Nick Clemens from comment #119) > Sponsoring library has approved, removing discussion status Could you share a summary of what has been tested and discussed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Nick Clemens changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #119 from Nick Clemens --- Sponsoring library has approved, removing discussion status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #118 from Martin Renvoize --- Removed from 20.05 targets as it appears to still need a little work after usability testing.. We've got lots of the dependencies pushed, so hopefully this can get some attention and make it in time for 20.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #117 from Jonathan Druart --- Lari, the remote branch needs to be used to testing. The patches were not up-to-date on purpose, new rules have been added to the table, and need to be added to the interface, did you deal with them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #116 from Lari Taskula ---
Comment on attachment 101934
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934
Bug 15522: Add API for circulation rules
Review of attachment 101934:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15522&attachment=101934)
-
::: api/v1/swagger/paths/circulation-rules.json
@@ +28,5 @@
> + "schema": {
> +"$ref": "../definitions.json#/error"
> + }
> +}
> + }
No permissions required for GET?
@@ +40,5 @@
> + ],
> + "parameters": [{
> +"name": "body",
> +"in": "body",
> +"description": "A JSON object containing rules to set; null for a
> rule_value means to delete the rule",
I think this wrong functionality for POST method that is supposed to create
resources.
Also, by definition POST is not idempotent, but here it seems to be. (If I
understand the API correctly, here making the same request twice is the same as
making it only once, right?)
It should then be PUT. But PUT requires the whole object as a parameter.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101946|0 |1 is obsolete|| --- Comment #115 from Lari Taskula --- Created attachment 101947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101947&action=edit Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101927|0 |1 is obsolete|| --- Comment #111 from Lari Taskula --- Created attachment 101943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101943&action=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #112 from Lari Taskula --- Created attachment 101944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101944&action=edit Bug 15522: (follow-up) Fix circulation rules interface title inconsistency Follow-up to "Bug 15522: Remove old circulation rules interface" Instead of: "Circulation, fines and holds rules", use "Circulation, fines, and holds rules" for consistency Latter form already used in commit Bug 15522: New interface for updated circulation rules as follows koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:37: Circulation, fines, and holds rules koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:88: Circulation, fines, and holds rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #113 from Lari Taskula --- Created attachment 101945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101945&action=edit Bug 15522: (follow-up) Add missing http return codes to api spec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #114 from Lari Taskula --- Created attachment 101946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101946&action=edit Bug 15522: (follow-up) Fix 400 errors in circ_rules.t Commit "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries" renames a permission by one that negates the previous. However the commit above incorrectly negates more than is supposed to. The test wants to check whether unauthorized and restricted user can store circulation rules. The libriarian is restricted (to their homebranch) when they are circ rules authorized (by "manage_circ_rules" permission) but do not have permission "manage_circ_rules_from_any_libraries". To test: 1. prove t/db_dependent/api/v1/circ_rules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101926|0 |1 is obsolete|| --- Comment #110 from Lari Taskula --- Created attachment 101942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101942&action=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101925|0 |1 is obsolete|| --- Comment #109 from Lari Taskula --- Created attachment 101941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101941&action=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101923|0 |1 is obsolete|| --- Comment #107 from Lari Taskula --- Created attachment 101939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101939&action=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101922|0 |1 is obsolete|| --- Comment #106 from Lari Taskula --- Created attachment 101938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101938&action=edit Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101921|0 |1 is obsolete|| --- Comment #105 from Lari Taskula --- Created attachment 101937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101937&action=edit Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101924|0 |1 is obsolete|| --- Comment #108 from Lari Taskula --- Created attachment 101940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101940&action=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101918|0 |1 is obsolete|| --- Comment #102 from Lari Taskula --- Created attachment 101934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #101919|0 |1 is obsolete|| --- Comment #103 from Lari Taskula --- Created attachment 101935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101935&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Lari Taskula changed:
What|Removed |Added
Attachment #101920|0 |1
is obsolete||
--- Comment #104 from Lari Taskula ---
Created attachment 101936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101936&action=edit
Bug 15522: New interface for updated circulation rules
Test plan:
1) Make sure all dependencies are applied, and that their DB upgrades
have been applied.
2) Build JS (see previous patches for HOWTO).
3) Load .../cgi-bin/koha/admin/policy.pl .
4) Try changing an existing rule (one with a textbox or dropdown). Hit
"Save rules", ensure that your changes are saved.
5) Until changes are saved, all cells that are changed or affected by
your changes should be highlighted in yellow.
6) Same as above, but deleting a rule by hitting the "x" next to it.
7) Add rows and columns using the "Choose rule..." and "Choose
category/item type..." dropdowns.
8) Add rules by clicking the pencil in a currently unset rule cell.
Ensure changes are saved.
9) Hit "Cleanup rules"; all redundant rules should be removed. As this
only removes rules that are the same as the defaults, this should
not change any effective rules.
10) Use the filters at the top right ("Circulation", "Holds" and
"Fines") to filter the kinds of rules that are shown.
11) Ensure that any desired library can be shown, including (if
selected) all at the same time.
JD edits: Removed the changes to filtered categories, will be done in a
follow-up
Signed-off-by: Lisette Scheer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #101 from Lari Taskula ---
(In reply to Lari Taskula from comment #99)
> Comment on attachment 101920 [details] [review]
> Bug 15522: New interface for updated circulation rules
>
> Review of attachment 101920 [details] [review]:
> -
>
> ::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js
> @@ +75,5 @@
> > +;
> > +}
> > +
> > +componentDidMount() {
> > +$( this.toolbarElem ).fixFloat();
>
> Test plan step 3 fails, my browser (both FF and Chromium) console says:
> TypeError: $(...).fixFloat is not a functionapp.js:79:30
Fixed by "Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky",
would be useful to squash this patch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #100 from Lari Taskula --- (In reply to Lari Taskula from comment #98) > (In reply to Lisette Scheer from comment #62) > > (In reply to Jonathan Druart from comment #51) > > > Created attachment 99148 [details] [review] [review] [review] > > > Bug 15522: Add API for circulation rules > > > > > > Test plan: > > > 1) Run t/db_dependent/api/v1/circ_rules.t . > > > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove > > t/db_dependent/api/v1/circ_rules.t > > t/db_dependent/api/v1/circ_rules.t .. 1/5 > > # Failed test '403 Forbidden' > > # at t/db_dependent/api/v1/circ_rules.t line 128. > > # got: '400' > > # expected: '403' > > # Looks like you failed 1 test of 2. > > t/db_dependent/api/v1/circ_rules.t .. 3/5 > > # Failed test 'set_rules | unauthorized' > > # at t/db_dependent/api/v1/circ_rules.t line 132. > > > > # Failed test '200 OK' > > # at t/db_dependent/api/v1/circ_rules.t line 212. > > # got: '403' > > # expected: '200' > > # Looks like you failed 1 test of 6. > > > > # Failed test 'set_rules | restricted' > > # at t/db_dependent/api/v1/circ_rules.t line 223. > > # Looks like you failed 2 tests of 5. > > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, > > 0x200) > > Failed 2/5 subtests > > > > Test Summary Report > > --- > > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) > > Failed tests: 3, 5 > > Non-zero exit status: 2 > > Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 > > csys = 3.11 CPU) > > Result: FAIL > > > > I got this message when I tried to do this step in my devbox. Everything > > else worked great for me. > > I confirm this error. Will provide a patch to fix it. Already fixed by "Bug 15522: Fix permission name manage_circ_rules_from_any_libraries", maybe squash this patch to the first one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #99 from Lari Taskula ---
Comment on attachment 101920
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920
Bug 15522: New interface for updated circulation rules
Review of attachment 101920:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15522&attachment=101920)
-
::: koha-tmpl/intranet-tmpl/prog/js/src/admin/policy/app.js
@@ +75,5 @@
> +;
> +}
> +
> +componentDidMount() {
> +$( this.toolbarElem ).fixFloat();
Test plan step 3 fails, my browser (both FF and Chromium) console says:
TypeError: $(...).fixFloat is not a functionapp.js:79:30
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #98 from Lari Taskula --- (In reply to Lisette Scheer from comment #62) > (In reply to Jonathan Druart from comment #51) > > Created attachment 99148 [details] [review] [review] > > Bug 15522: Add API for circulation rules > > > > Test plan: > > 1) Run t/db_dependent/api/v1/circ_rules.t . > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove > t/db_dependent/api/v1/circ_rules.t > t/db_dependent/api/v1/circ_rules.t .. 1/5 > # Failed test '403 Forbidden' > # at t/db_dependent/api/v1/circ_rules.t line 128. > # got: '400' > # expected: '403' > # Looks like you failed 1 test of 2. > t/db_dependent/api/v1/circ_rules.t .. 3/5 > # Failed test 'set_rules | unauthorized' > # at t/db_dependent/api/v1/circ_rules.t line 132. > > # Failed test '200 OK' > # at t/db_dependent/api/v1/circ_rules.t line 212. > # got: '403' > # expected: '200' > # Looks like you failed 1 test of 6. > > # Failed test 'set_rules | restricted' > # at t/db_dependent/api/v1/circ_rules.t line 223. > # Looks like you failed 2 tests of 5. > t/db_dependent/api/v1/circ_rules.t .. Dubious, test returned 2 (wstat 512, > 0x200) > Failed 2/5 subtests > > Test Summary Report > --- > t/db_dependent/api/v1/circ_rules.t (Wstat: 512 Tests: 5 Failed: 2) > Failed tests: 3, 5 > Non-zero exit status: 2 > Files=1, Tests=5, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.86 cusr 0.23 > csys = 3.11 CPU) > Result: FAIL > > I got this message when I tried to do this step in my devbox. Everything > else worked great for me. I confirm this error. Will provide a patch to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #97 from Lari Taskula --- (In reply to Lari Taskula from comment #87) > Created attachment 101919 [details] [review] > Bug 15522: Add JS build pipeline > > This is not directly testable, but can be either used through the > Makefile: > > $ make js-build > > (This will automatically install all dependencies.) > > Or by manually installing yarn: > > $ sudo apt install nodejs npm > $ sudo npm install -g yarn > $ yarn install > $ yarn build > > (There is also `make js-watch` and `yarn watch`, which automatically > recompile when files are changed.) > > JD note: the make rule does not work > > Signed-off-by: Lisette Scheer I had issues with this on Ubuntu 18.04, especially the step "yarn build". koha@koha:~/Koha$ yarn build yarn run v1.22.4 $ node_modules/.bin/gulp build You are missing required Node modules; run `npm install`. I did some digging and found a more detailed message: ReferenceError: primordials is not defined It worked when I explicitly chose to install node version 10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi --- Comment #96 from Lari Taskula --- Fixed patch order, obsoleted duplicates, rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99215|0 |1 is obsolete|| --- Comment #95 from Lari Taskula --- Created attachment 101927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101927&action=edit Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99201|0 |1 is obsolete|| --- Comment #94 from Lari Taskula --- Created attachment 101926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101926&action=edit Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99203|0 |1 is obsolete|| --- Comment #92 from Lari Taskula --- Created attachment 101924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101924&action=edit Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99202|0 |1 is obsolete|| --- Comment #93 from Lari Taskula --- Created attachment 101925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101925&action=edit Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99204|0 |1 is obsolete|| --- Comment #91 from Lari Taskula --- Created attachment 101923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101923&action=edit Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99205|0 |1 is obsolete|| --- Comment #90 from Lari Taskula --- Created attachment 101922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101922&action=edit Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99206|0 |1 is obsolete|| --- Comment #89 from Lari Taskula --- Created attachment 101921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101921&action=edit Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Lari Taskula changed:
What|Removed |Added
Attachment #99214|0 |1
is obsolete||
--- Comment #88 from Lari Taskula ---
Created attachment 101920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101920&action=edit
Bug 15522: New interface for updated circulation rules
Test plan:
1) Make sure all dependencies are applied, and that their DB upgrades
have been applied.
2) Build JS (see previous patches for HOWTO).
3) Load .../cgi-bin/koha/admin/policy.pl .
4) Try changing an existing rule (one with a textbox or dropdown). Hit
"Save rules", ensure that your changes are saved.
5) Until changes are saved, all cells that are changed or affected by
your changes should be highlighted in yellow.
6) Same as above, but deleting a rule by hitting the "x" next to it.
7) Add rows and columns using the "Choose rule..." and "Choose
category/item type..." dropdowns.
8) Add rules by clicking the pencil in a currently unset rule cell.
Ensure changes are saved.
9) Hit "Cleanup rules"; all redundant rules should be removed. As this
only removes rules that are the same as the defaults, this should
not change any effective rules.
10) Use the filters at the top right ("Circulation", "Holds" and
"Fines") to filter the kinds of rules that are shown.
11) Ensure that any desired library can be shown, including (if
selected) all at the same time.
JD edits: Removed the changes to filtered categories, will be done in a
follow-up
Signed-off-by: Lisette Scheer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99213|0 |1 is obsolete|| --- Comment #87 from Lari Taskula --- Created attachment 101919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101919&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Lari Taskula changed: What|Removed |Added Attachment #99148|0 |1 is obsolete|| Attachment #99211|0 |1 is obsolete|| --- Comment #86 from Lari Taskula --- Created attachment 101918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101918&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #85 from Lari Taskula --- Not applying. Patches have gone in wrong order. I'll attempt to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #84 from Arthur Suzuki --- Also just tried the "Rules per categories and itemtype" section. When there are a lot of rules it's still tough to read which field one is editing. Would be great to reproduce something like this : http://output.jsbin.com/AjiJIGA/1 Nice to have one edit button on each field though. The interrogation mark helps to find out from which rules the value is inherited, would be useful to have as well the field name in there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #83 from Arthur Suzuki --- Also just tried the "Rules per categories and itemtype" section. When there are a lot of rules it's still tough to read which field one is editing. Would be great to reproduce something like this : http://output.jsbin.com/AjiJIGA/1 Nice to have one edit button on each field though. The interrogation mark helps to find out from which rules the value is inherited, would be useful to have as well the field name in there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #82 from Arthur Suzuki --- Tried the "Cleanup rules" button this way : Set rule by category (defaults) to 5, 5, 5 Created a new one for "School" with same values. click on "cleanup rules" -> get the disclaimer, click ok. after ok, the rule for school still appears with yellowish colors (enabled for editing I guess?) if I reload the page, it disappear from the view -> cleanup works. If I don't reload the page but click on "save" instead, then the rule still appears, until a full page reload. -> this might lead people to thinks the rules has not been removed. (solved after a reload). Overall, the stuff works but the process of reviewing the rules before actual deletion is not so clear. Maybe any click on the "save button" could trigger a full page reload to ensure working with "fresh" data? Happy to sign-off if this is the expected behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #81 from Arthur Suzuki --- Just seen the disclaimer : "This should not change any circulation behavior, but you will be able to review these changes before saving." Nice :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com --- Comment #80 from Arthur Suzuki --- Hi Nick, I've been testing the new interface, there are few things that I really like: - filters (circulation, fines, holds) -> very useful for ease of reading when lots of rules or when troubleshooting hold rules issues for example. - remove duplicate rules -> got to spend a bit more time to try that one, does it have a warning showing the duplicates before removal? that would be great if there's not :) - overall presentation is really nice. Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Needs Signoff |In Discussion --- Comment #79 from Nick Clemens --- We are reviewing this one internally and plan to demo it to the sponsoring library to get some feedback before this continues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Bug 15522 depends on bug 21156, which changed state. Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Bug 15522 depends on bug 21156, which changed state. Bug 21156 Summary: Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
Lisette Scheer changed:
What|Removed |Added
Attachment #99207|0 |1
is obsolete||
--- Comment #77 from Lisette Scheer ---
Created attachment 99214
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99214&action=edit
Bug 15522: New interface for updated circulation rules
Test plan:
1) Make sure all dependencies are applied, and that their DB upgrades
have been applied.
2) Build JS (see previous patches for HOWTO).
3) Load .../cgi-bin/koha/admin/policy.pl .
4) Try changing an existing rule (one with a textbox or dropdown). Hit
"Save rules", ensure that your changes are saved.
5) Until changes are saved, all cells that are changed or affected by
your changes should be highlighted in yellow.
6) Same as above, but deleting a rule by hitting the "x" next to it.
7) Add rows and columns using the "Choose rule..." and "Choose
category/item type..." dropdowns.
8) Add rules by clicking the pencil in a currently unset rule cell.
Ensure changes are saved.
9) Hit "Cleanup rules"; all redundant rules should be removed. As this
only removes rules that are the same as the defaults, this should
not change any effective rules.
10) Use the filters at the top right ("Circulation", "Holds" and
"Fines") to filter the kinds of rules that are shown.
11) Ensure that any desired library can be shown, including (if
selected) all at the same time.
JD edits: Removed the changes to filtered categories, will be done in a
follow-up
Signed-off-by: Lisette Scheer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
