[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Katrin Fischer  ---
(In reply to Aleisha Amohia from comment #3)
> (In reply to Marc Véron from comment #2)
> 
> > - not display the self registration link if PatronSelfRegistration is set
> > and PatronSelfRegistrationDefaultCategory is wrong or does not exist
> 
> I think this is probably the best option, as well as updating the
> descriptions for both system preferences. For example, update
> PatronSelfRegistration to say that even when set to Allow, the link will not
> display if PatronSelfRegistrationDefaultCategory is incorrectly set. Then
> update PatronSelfRegistrationDefaultCategory and give options of common
> patron categories.

This has both been implemented since :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Owen Leonard  changed:

   What|Removed |Added

   Hardware|PC  |All
 OS|Linux   |All
  Component|OPAC|System Administration
 CC||gmcha...@gmail.com
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Jonathan Druart  changed:

   What|Removed |Added

Version|3.22|master
   Severity|major   |normal

--- Comment #4 from Jonathan Druart  
---
Lowering the severity as it comes from a configuration issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia  ---
(In reply to Marc Véron from comment #2)

> - not display the self registration link if PatronSelfRegistration is set
> and PatronSelfRegistrationDefaultCategory is wrong or does not exist

I think this is probably the best option, as well as updating the descriptions
for both system preferences. For example, update PatronSelfRegistration to say
that even when set to Allow, the link will not display if
PatronSelfRegistrationDefaultCategory is incorrectly set. Then update
PatronSelfRegistrationDefaultCategory and give options of common patron
categories.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Could you please confirm that your system preference
PatronSelfRegistrationDefaultCategory is filled with a valid patron category?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Testing:

If PatronSelfRegistrationDefaultCategory is empty, the link for self
registration is not displayed in OPAC

If PatronSelfRegistrationDefaultCategory is set to a category that does not
exist, the error can be triggered.

It happens as well if there is a leading space char by mistake. Example with a
valid category PT:

[PT] -> OK
[PT] -> OK (one or more trailing space chars)
[ PT] -> Software error (Leading space char)
[   ] -> Software eror (one or more space chars)

Maybe we could

- validate the syspref field for not having leading spaces or spaces only

- give some more explanation in the syspref descriptions for
PatronSelfRegistration depending on a correct value for
PatronSelfRegistrationDefaultCategory

- add a warning on the about page (tab system information) if
PatronSelfRegistration is set and PatronSelfRegistrationDefaultCategory is
wrong or does not exist

- not display the self registration link if PatronSelfRegistration is set and
PatronSelfRegistrationDefaultCategory is wrong or does not exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/