[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #13 from Marcel de Rooy  ---
Created attachment 51833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51833=edit
Bug 15545: Add routine IsHoldNoteRequired to Reserves module

This routine will be used to determine if a hold note is required.
In the current approach this is implemented by use of Koha plugins.
A former approach included a syspref. This is no longer needed. This
approach is even more flexible.

The routine will use all plugins it finds with metadata tag
'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a
check method that returns true, the hold note should be regarded as
required.

The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an
implementation where the value of the leader or MARC21 300$a determines
if the hold note is required. Similarly, any other field of the
bibliographic record could be used in a new plugin.

Test plan:
Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #14 from Marcel de Rooy  ---
Created attachment 51834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51834=edit
Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl

This patch implements use of the new Reserves routine IsHoldNoteRequired,
making it possible to require a note when placing a hold.
Only a very small change in opac-reserve.pl is needed. As well as
corresponding changes in the template. I am removing some unused template
code related to a former approach.

Test plan:
[1] Disable UseKohaPlugins, enable OpacHoldNotes.
[2] Place a hold on a serial record (leader pos 7 == s). Verify that
the hold note is not required.
[3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins.
(Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz.
This file can be found as an attachment to this BZ report.)
[4] Again place a hold on a serial record. The hold note should be required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #12 from Marcel de Rooy  ---
Created attachment 51832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51832=edit
Koha Plugin: Rijks_HoldNoteRequired_Extent and _Leader

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49085|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49084|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #49086|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||16586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586
[Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #11 from Marcel de Rooy  ---
Back to Assigned: Making some changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #10 from Marcel de Rooy  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #46689|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 49086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49086=edit
Bug 15545: Unit test for IsHoldNoteRequired

Adds unit test.

Test plan:
Run the test t/db../Reserves/IsHoldNoteRequired.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #46688|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 49085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49085=edit
Bug 15545: Optionally require notes when placing a hold

This report adds three cases where you could want to require a note when
placing a hold. Each of these cases may be enabled separately via the
system preference HoldNoteReasons. (The hold note itself is triggered
by OpacHoldNotes.)

These three cases are:
[1] serial indication in the leader (called LEADER_SERIAL)
[2] collection indication in the leader (LEADER_COLLECTION)
[3] MARC 300$a contains an indication of multiple parts/volumes, as
identified by a regular expression (MARC300A_PARTS).

The new sub IsHoldNoteRequired in Reserves.pm handles these cases. And will
be easily extensible.
Also this patch removes some unused code in the reserves template for
mandatory hold notes reasons.

Test plan:
[1] Enable OpacHoldNotes. Set HoldNoteReasons to LEADER_SERIAL.
[2] In OPAC, place a hold on a serial record (with correct leader).
Verify that the hold notes are required.
[3] Set HoldNoteReasons to MARC300A_PARTS.
Verify that the hold notes are no longer required for the record in
the preceding step. (This actually depends on your 300$a..)
Cancel the hold you placed.
[4] Add "2 vols" to MARC 300$a in the same record.
Try to place the hold again. The hold notes should be required again.
[5] Place a multiple hold request with the same record and another one.
Click Place Hold while more-options is collapsed (blank notes).
Is the correct hold note made visible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #46687|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 49084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49084=edit
Bug 15545: Database revision for HoldNoteReasons pref

Adds a new preference.

Test plan:
Run the db revision.
Check the pref in the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #6 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #5)
> Would the need for this feature be eliminated if it was possible to limit
> item-level holds to the types of records defined in this patch? That is,
> serials, titles with volumes, etc?
> 
> If so, shouldn't we be solving that problem instead?

We still feel the need for this feature in that case. As long as our data is
not perfect (and all issuable materials have been split in the items table), we
still want the user to say what he really needs instead of collecting the whole
set. To illustrate: a multipart with 2 items a-d,e-h (which should indeed be 8
items).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #3 from Marcel de Rooy  ---
Created attachment 46688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46688=edit
Bug 15545: Optionally require notes when placing a hold

This report adds three cases where you could want to require a note when
placing a hold. Each of these cases may be enabled separately via the
system preference HoldNoteReasons. (The hold note itself is triggered
by OpacHoldNotes.)

These three cases are:
[1] serial indication in the leader (called LEADER_SERIAL)
[2] collection indication in the leader (LEADER_COLLECTION)
[3] MARC 300$a contains an indication of multiple parts/volumes, as
identified by a regular expression (MARC300A_PARTS).

The new sub IsHoldNoteRequired in Reserves.pm handles these cases. And will
be easily extensible.
Also this patch removes some unused code in the reserves template for
mandatory hold notes reasons.

Test plan:
[1] Enable OpacHoldNotes. Set HoldNoteReasons to LEADER_SERIAL.
[2] In OPAC, place a hold on a serial record (with correct leader).
Verify that the hold notes are required.
[3] Set HoldNoteReasons to MARC300A_PARTS.
Verify that the hold notes are no longer required for the record in
the preceding step. (This actually depends on your 300$a..)
Cancel the hold you placed.
[4] Add "2 vols" to MARC 300$a in the same record.
Try to place the hold again. The hold notes should be required again.
[5] Place a multiple hold request with the same record and another one.
Click Place Hold while more-options is collapsed (blank notes).
Is the correct hold note made visible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #2 from Marcel de Rooy  ---
Created attachment 46687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46687=edit
Bug 15545: Database revision for HoldNoteReasons pref

Adds a new preference.

Test plan:
Run the db revision.
Check the pref in the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #4 from Marcel de Rooy  ---
Created attachment 46689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46689=edit
Bug 15545: Unit test for IsHoldNoteRequired

Adds unit test.

Test plan:
Run the test t/db../Reserves/IsHoldNoteRequired.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #5 from Owen Leonard  ---
Would the need for this feature be eliminated if it was possible to limit
item-level holds to the types of records defined in this patch? That is,
serials, titles with volumes, etc?

If so, shouldn't we be solving that problem instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9743

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally require notes when placing a hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #1 from Marcel de Rooy  ---
This report adds three cases where you could want to require a note when
placing a hold. Each of these cases may be enabled separately via a system
preference. (The hold note itself is triggered by OpacHoldNotes.)

The three cases are: serial indication in the leader, collection indication in
the leader, and MARC 300$a contains an indication of multiple parts/volumes
(identified via a regular expression). A new sub in Reserves handles these
cases and will be easily extensible.

A unit test will be provided too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/