[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951
[Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jesse Weaver  ---
Pushed to master, thanks for your work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #24 from Jonathan Druart  
---
Created attachment 48590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48590=edit
Bug 15548 [QA Followup] - More new uses of Koha::Borrower

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #48111|0   |1
is obsolete||
  Attachment #48112|0   |1
is obsolete||
  Attachment #48142|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  
---
Created attachment 48588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48588=edit
Bug 15548: Move new patron related code to Patron*

The 'borrower' should not be used anymore, especially for new code.
This patch move files and rename variables newly pushed (i.e. in the Koha
namespace).

Test plan:
1/
  git grep Koha::Borrower
should not return code in use.

2/
Prove the different modified test files

3/ Do some clicks in the member^Wpatron module to be sure there is not
an obvious error.

Signed-off-by: Hector Castro 
Works as described. Tested with Circulation, Members/Patrons, Discharge,
Restrictions modules and the must common functionalities

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #23 from Jonathan Druart  
---
Created attachment 48589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48589=edit
Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #21 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #20 from Kyle M Hall  ---
Created attachment 48142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48142=edit
Bug 15548 [QA Followup] - More new uses of Koha::Borrower

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15635


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635
[Bug 15635] Move the patron images related code to Koha::Patron::Images
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47103|0   |1
is obsolete||
  Attachment #47104|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 48111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48111=edit
Bug 15548: Move new patron related code to Patron*

The 'borrower' should not be used anymore, especially for new code.
This patch move files and rename variables newly pushed (i.e. in the Koha
namespace).

Test plan:
1/
  git grep Koha::Borrower
should not return code in use.

2/
Prove the different modified test files

3/ Do some clicks in the member^Wpatron module to be sure there is not
an obvious error.

Signed-off-by: Hector Castro 
Works as described. Tested with Circulation, Members/Patrons, Discharge,
Restrictions modules and the must common functionalities

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #19 from Jonathan Druart  
---
Just another rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #18 from Jonathan Druart  
---
Created attachment 48112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48112=edit
Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15653


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653
[Bug 15653] Updating a guarantor has never updated its guarantees
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15656


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656
[Bug 15656] Move the guarantor/guarantees code to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #16 from Jonathan Druart  
---
Patches rebased, easy conflicts with bug 15295 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #15 from Jonathan Druart  
---
Created attachment 47104
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47104=edit
Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46728|0   |1
is obsolete||
  Attachment #46729|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 47103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47103=edit
Bug 15548: Move new patron related code to Patron*

The 'borrower' should not be used anymore, especially for new code.
This patch move files and rename variables newly pushed (i.e. in the Koha
namespace).

Test plan:
1/
  git grep Koha::Borrower
should not return code in use.

2/
Prove the different modified test files

3/ Do some clicks in the member^Wpatron module to be sure there is not
an obvious error.

Signed-off-by: Hector Castro 
Works as described. Tested with Circulation, Members/Patrons, Discharge,
Restrictions modules and the must common functionalities

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15449


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #13 from Jonathan Druart  
---
I have added a new test in the QA tools:

commit 352357f88d1225075b555723f9135e91eb76571c
Koha::Borrower has been moved by bug 15548

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #11 from Kyle M Hall  ---
Created attachment 46729
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46729=edit
Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #46634|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 46728
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46728=edit
Bug 15548: Move new patron related code to Patron*

The 'borrower' should not be used anymore, especially for new code.
This patch move files and rename variables newly pushed (i.e. in the Koha
namespace).

Test plan:
1/
  git grep Koha::Borrower
should not return code in use.

2/
Prove the different modified test files

3/ Do some clicks in the member^Wpatron module to be sure there is not
an obvious error.

Signed-off-by: Hector Castro 
Works as described. Tested with Circulation, Members/Patrons, Discharge,
Restrictions modules and the must common functionalities

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
RM Note:
git grep Koha::Borrower

should only result in references to:
misc/release_notes/release_notes_3_18_0.txt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #6 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #0)
> As previously agreed, we need to standardize our wording, Borrower should be
> Patron.

Was this announced somewhere?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #7)
> http://lists.koha-community.org/pipermail/koha-devel/2015-June/041551.html
> http://wiki.koha-community.org/wiki/Terminology

Agreed seems to be a strong word, if I am searching back.
It was only discussed on the second part of a dev meeting on June 24 with just
three or four attending. 
http://irc.koha-community.org/koha/2015-06-24#i_1694243

This means that the list on the wiki does not have community consensus yet. We
cannot definitely say here that Patron e.g. is the new standard as decided by
the community (on a regular IRC meeting).

Apart from that, I am all for consistency but not for refactoring code just to
reword. It will most probably generate new errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #7 from Jonathan Druart  
---
http://lists.koha-community.org/pipermail/koha-devel/2015-June/041551.html
http://wiki.koha-community.org/wiki/Terminology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #9 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > http://lists.koha-community.org/pipermail/koha-devel/2015-June/041551.html
> > http://wiki.koha-community.org/wiki/Terminology
> 
> Agreed seems to be a strong word, if I am searching back.
> It was only discussed on the second part of a dev meeting on June 24 with
> just three or four attending. 
> http://irc.koha-community.org/koha/2015-06-24#i_1694243
> 
> This means that the list on the wiki does not have community consensus yet.
> We cannot definitely say here that Patron e.g. is the new standard as
> decided by the community (on a regular IRC meeting).
> 
> Apart from that, I am all for consistency but not for refactoring code just
> to reword. It will most probably generate new errors.

It's not "only to reword", it's to keep consistency.
We have now 2 packages Koha::Borrowers and Koha::Patrons, which represent the
same thing. To make things clear, it's important to have only 1 word to
represent the same entity. A new dev will know where (s)he should add new code
patron-related.
I am pretty sure that the use of the "patron" term has been voted years ago for
the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46489|0   |1
is obsolete||

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
Created attachment 46634
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46634=edit
[SIGNED-OFF]Bug 15548: Move new patron related code to Patron*

The 'borrower' should not be used anymore, especially for new code.
This patch move files and rename variables newly pushed (i.e. in the Koha
namespace).

Test plan:
1/
  git grep Koha::Borrower
should not return code in use.

2/
Prove the different modified test files

3/ Do some clicks in the member^Wpatron module to be sure there is not
an obvious error.

Signed-off-by: Hector Castro 
Works as described. Tested with Circulation, Members/Patrons, Discharge,
Restrictions modules and the must common functionalities

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #4 from Marc Véron  ---
(In reply to Héctor Eduardo Castro Avalos from comment #3)
> (...)
> 
> For me all involved tests works successfully
> 

Glad to hear. I'm quite sure that the two fails in my tests were related to
some local issue on my VM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Hi Marc and Jonathan

For me all involved tests works successfully

t/Patron.t
t/db_dependent/Accounts.t
t/db_dependent/BiblioObject.t
t/db_dependent/Circulation/AnonymiseIssueHistory.t
t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
t/db_dependent/Creators/Lib.t
t/db_dependent/Hold.t
t/db_dependent/Koha_borrower_modifications.t
t/db_dependent/Patron.t
t/db_dependent/Patron/Borrower_Debarments.t
t/db_dependent/Patron/Borrower_Discharge.t
t/db_dependent/Patron/Borrower_Files.t
t/db_dependent/Patrons.t
t/db_dependent/Review.t
t/db_dependent/api/v1/patrons.t

The next was renamed/removed
Renamed t/Borrower.t
Renamed t/db_dependent/Borrower.t
Renamed t/db_dependent/Borrowers.t

git grep Koha::Borrower showed entries in release notes for 3.18 only.

I will start to test the modules implied. It seems to be that you only replaced
"borrower" to "patron" but IMHO I think this needs a rigorous test plan since
you changed a lot in this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

--- Comment #1 from Jonathan Druart  
---
Created attachment 46489
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46489=edit
Bug 15548: Move new patron related code to Patron*

The 'borrower' should not be used anymore, especially for new code.
This patch move files and rename variables newly pushed (i.e. in the Koha
namespace).

Test plan:
1/
  git grep Koha::Borrower
should not return code in use.

2/
Prove the different modified test files

3/ Do some clicks in the member^Wpatron module to be sure there is not
an obvious error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Testing with patch:
t/db_dependent/Circulation.t OK
t/db_dependent/Members.t OK
t/db_dependent/Hold.t OK
t/db_dependent/Item OK
t/db_dependent/Koha_Misc_Files.t (OK)
t/db_dependent/Patron.t OK
t/db_dependent/Patrons.t OK
t/db_dependent/Virtualshelves.t OK
t/Patron.t OK
t/db_dependent/Accounts.t OK
t/db_dependent/BiblioObject.t OK
t/db_dependent/Circulation/AnonymiseIssueHistory.t (Fails with and without
patch, could be related to my test server)
t/db_dependent/Creators/Lib.t (OK)
t/db_dependent/Hold.t (OK)
t/db_dependent/Koha_borrower_modifications.t (OK)
t/db_dependent/Borrower_Debarments.t OK
t/db_dependent/Borrower_Discharge.t OK
t/db_dependent/Borrower_Files.t OK
t/db_dependent/Review.t
t/db_dependent/api/v1/patrons.t (Fails with and without patch)


I think somebody else should run all the tests as well (especially the two
failing without and with patches).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/