[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #16 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #15 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.02.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Bouzid!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53157|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 53177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53177=edit
Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

Signed-off-by: Srdjan 

Signed-off-by: Jonathan Druart 
This patch adds the same tests in the aoColumns DT definition than the
ones in the creation of the table. That's sound good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #51186|0   |1
is obsolete||

--- Comment #12 from Srdjan Jankovic  ---
Created attachment 53157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53157=edit
[SIGNED-OFF] Bug 15636 - DataTables Warning: Requested unknown parameter from
opac-detail.tt

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

--- Comment #11 from Blou  ---
I rebased it.
Now, I've asked bouzid to find a way to reproduce it, but that's low on his
priority list.
As he said previously, the fix is just reproducing the same conditions for the
header as for the entries in the table.  No need of big research to imagine a
scenario where the unfixed code might break, even though it seems all of you
have been lucky so far :-)

So in that sense, I was under the hope this would go smoother...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Blou  changed:

   What|Removed |Added

  Attachment #50146|0   |1
is obsolete||

--- Comment #10 from Blou  ---
Created attachment 51186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51186=edit
Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

--- Comment #9 from Owen Leonard  ---
Please include a test plan in your commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Bouzid  changed:

   What|Removed |Added

   Assignee|remi.mayrand-provencher@inL |bouzid.ferg...@inlibro.com
   |ibro.com|
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Bouzid  changed:

   What|Removed |Added

 CC||bouzid.ferg...@inlibro.com

--- Comment #8 from Bouzid  ---
the order of the conditions is not the same in both places, which causes an
error display, and the javascript stops.
Now, the order is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Bouzid  changed:

   What|Removed |Added

  Attachment #47142|0   |1
is obsolete||

--- Comment #7 from Bouzid  ---
Created attachment 50146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50146=edit
Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |Failed QA

--- Comment #6 from Jonathan Druart  
---
I do not find any occurrence of singleBranchModel, I suspect a typo (for
singleBranchMode).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #5 from Marc Véron  ---
(In reply to Blou from comment #4)
> Hello Cate,
> We'll need your help on that.  You see, we cannot reproduce the situation
> without hacking the code.  It arose because we're adding an extra column in
> there for ebooks, in a custom development.  It causes a jqury message to pop
> up in the UI because of the imbalance in column count.
> 
> The origin of it is commit 6d32d66f, by bug #7720.  You can see in there
> that it's missing the javascript part for the test.
> 
> So, not sure how to test it.  Except that by looking at the code (and 7720's
> code), it's "obvious".  Just need a way to translate it into a scenario...

Blou,

Maybe you could add a separate patch with the "hack" that is necessary for
testing (marked with something like FOR TESTING ONLY - DO NOT PUSH)

The scenario would then be something like:
- apply the "Hack" patch
- verify the bug
- apply the patch with the jQuery fix
- verify that the error is gone
- remove both patches and apply the jQuery fix patch only
- verify that nothing is broken
- sign-off the patch with the jQuery fix

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #47141|0   |1
is obsolete||

--- Comment #2 from Rémi Mayrand-Provencher 
 ---
Created attachment 47142
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47142=edit
Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

Fixes the jQuery that generates the holdingst DataTable by adding the missing
UNLESS and IF tests to it.

The IF and UNLESS in opac-detail.tt need to be the same in the header
declaration of the DataTable and the jquery that builds it or else there can be
an error depening on the system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Remi, can you please add a test plan to your commit message?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Blou  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7720

--- Comment #4 from Blou  ---
Hello Cate,
We'll need your help on that.  You see, we cannot reproduce the situation
without hacking the code.  It arose because we're adding an extra column in
there for ebooks, in a custom development.  It causes a jqury message to pop up
in the UI because of the imbalance in column count.

The origin of it is commit 6d32d66f, by bug #7720.  You can see in there that
it's missing the javascript part for the test.

So, not sure how to test it.  Except that by looking at the code (and 7720's
code), it's "obvious".  Just need a way to translate it into a scenario...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |remi.mayrand-provencher@inL
   ||ibro.com
 CC||eric.be...@inlibro.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636

--- Comment #1 from Rémi Mayrand-Provencher 
 ---
Created attachment 47141
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47141=edit
Bug15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

Fixes the jQuery that builds the holdingst DataTable in opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/