[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25350


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25350
[Bug 25350] Load Emoji picker assets more efficiently
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #23 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #21)
>
> +1 for a syspref. Or better find a more compatible emoji picker.
> 
> Anyways, please default to enabled to keep the current behavior.

Sounds good to me. For now, we've just hacked it away, but I'll keep this in
the back of my mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #22 from David Cook  ---
(In reply to Owen Leonard from comment #20)
> (In reply to David Cook from comment #19)
> 
> > I think Endnote X9 uses an (old) embedded version of Internet Explorer
> 
> A scary Halloween short story as told by David.

藍

I love you, Owen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #21 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #19)
> The emoji picker is causing script errors when using Koha in Endnote X9. 
> 
> I think Endnote X9 uses an (old) embedded version of Internet Explorer, and
> I think that's why it's happening. 
> 
> Investigating ways of fixing it, but I think I might just send a follow-up
> about using a system preference to disable the emoji picker.

+1 for a syspref. Or better find a more compatible emoji picker.

Anyways, please default to enabled to keep the current behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #20 from Owen Leonard  ---
(In reply to David Cook from comment #19)

> I think Endnote X9 uses an (old) embedded version of Internet Explorer

A scary Halloween short story as told by David.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #19 from David Cook  ---
The emoji picker is causing script errors when using Koha in Endnote X9. 

I think Endnote X9 uses an (old) embedded version of Internet Explorer, and I
think that's why it's happening. 

Investigating ways of fixing it, but I think I might just send a follow-up
about using a system preference to disable the emoji picker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794
Bug 15794 depends on bug 18336, which changed state.

Bug 18336 Summary: Add support for Unicode supplementary characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #16 from Jonathan Druart  
---
Created attachment 71860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71860=edit
Bug 15794: Add [% KOHA_VERSION to .css and .js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #17 from Jonathan Druart  
---
Created attachment 71861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71861=edit
Bug 15794: Add emojiarea to the license area of the about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #15 from Kyle M Hall  ---
https://github.com/bywatersolutions/bywater-koha-devel/commit/c30f482d798b5402c357024f318c030c1e26bec0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #71053|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to M. Tompsett from comment #13)
> Additionally follow up bug that needs creating, updating the about area with
> the list of One Signal emoji-picker under the MIT and Apache licenses.

Mark, I will add your signature to the version in my github. BTW, I've just
updated the patch so the emoji picker works on the results page too!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #13 from M. Tompsett  ---
Additionally follow up bug that needs creating, updating the about area with
the list of One Signal emoji-picker under the MIT and Apache licenses.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #12 from M. Tompsett  ---
Remember to apply the dependency first, and run an update, and perhaps even a
reset_all just to make sure your data in prepared for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #11 from M. Tompsett  ---
Created attachment 71053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71053=edit
Bug 15794: Add Emoji Picker

TEST PLAN
-
1) apply this patch
2) Run the commands in comment #10
3) Attempt to add emoji tags in OPAC
   -- some system preferences may need setting
4) run koha qa test tools

NOTE: The failure resulting from the click will be
  a different bug.
  Also, do not include the emoji picker library,
  as the PNG files are too large to attach.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #10 from M. Tompsett  ---
I would recommend posting just the non-emoji picker parts, and then having
people do the following on a kohadevbox:
cd ~
git clone https://github.com/OneSignal/emoji-picker.git
cd emoji-picker/lib
mkdir ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker
cp -r -v . ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker
cd ~/kohaclone
git add `find ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker`
git commit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

--- Comment #9 from Tomás Cohen Arazi  ---
I've had trouble posting the patches here. Please use this branch to get the
patches:

https://github.com/tomascohen/koha/tree/bug_15794_emoji_tags

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

M. Tompsett  changed:

   What|Removed |Added

Summary|Allow the use of emojis as  |Add emoji picker to tag
   |tags on records |entry in OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/