[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for the May 2016 release. Istutiy Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Jonathan Druart changed: What|Removed |Added Attachment #50500|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 50597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50597&action=edit Bug 15938 - Use validation plugin when adding or editing classification sources and filing rules In Administration -> Classification sources there is some embedded JavaScript which checks for empty form values. This patch removes that JS and adds validation using the globally-included validation plugin instead. To test, apply the patch and go to Administration -> Classification sources. - Click to add a new classification source and confirm that you cannot submit the form with empty required values. - Edit an existing classification source and confirm that you cannot empty a required field and submit the form. - Repeat the previous two steps with filing rules. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Marc Véron changed: What|Removed |Added Attachment #48475|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 50500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50500&action=edit Bug 15938 - Use validation plugin when adding or editing classification sources and filing rules In Administration -> Classification sources there is some embedded JavaScript which checks for empty form values. This patch removes that JS and adds validation using the globally-included validation plugin instead. To test, apply the patch and go to Administration -> Classification sources. - Click to add a new classification source and confirm that you cannot submit the form with empty required values. - Edit an existing classification source and confirm that you cannot empty a required field and submit the form. - Repeat the previous two steps with filing rules. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 --- Comment #3 from Owen Leonard --- Bonus: This patch brings classsources.tt into compliance with the new JS9 coding guideline. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #2 from Owen Leonard --- Sorry, looks like an aborted git-bz attach added a link to Bug 15930 to my commit message. Not intentional! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15938] Use validation plugin when adding or editing classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15938 --- Comment #1 from Owen Leonard --- Created attachment 48475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48475&action=edit Bug 15938 - Use validation plugin when adding or editing classification sources and filing rules In Administration -> Classification sources there is some embedded JavaScript which checks for empty form values. This patch removes that JS and adds validation using the globally-included validation plugin instead. To test, apply the patch and go to Administration -> Classification sources. - Click to add a new classification source and confirm that you cannot submit the form with empty required values. - Edit an existing classification source and confirm that you cannot empty a required field and submit the form. - Repeat the previous two steps with filing rules. https://bugs.koha-community.org/show_bug.cgi?id=15930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
