[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #56 from Katrin Fischer --- (In reply to Katrin Fischer from comment #43) > Turns out, as phone notices are not a thing here at all, I am not sure how > this works. > > In which notice templates (letter codes) do I have to add the TT example > code? Still applies... Also: Test Summary Report --- t/db_dependent/Letters/TemplateToolkit.t (Wstat: 512 Tests: 24 Failed: 1) Failed test: 24 Non-zero exit status: 2 Parse errors: Bad plan. You planned 27 tests but ran 24. Files=1, Tests=24, 6 wallclock secs ( 0.01 usr 0.02 sys + 4.27 cusr 1.13 csys = 5.43 CPU) Result: FAIL Possibly just a reabase error (wrong number) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nick Clemens changed: What|Removed |Added Attachment #114413|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nick Clemens changed: What|Removed |Added Attachment #114414|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nick Clemens changed: What|Removed |Added Attachment #114415|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Attachment #114416|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #55 from Nick Clemens --- Created attachment 118210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118210&action=edit Bug 15969: Fetch the message instead of substituting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #54 from Nick Clemens --- Created attachment 118209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118209&action=edit Bug 15969: Unit test use of __MESSAGE_ID__ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #53 from Nick Clemens --- Created attachment 118208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118208&action=edit Bug 15969: Add unit test of substitution param Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
--- Comment #52 from Nick Clemens ---
Created attachment 118207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118207&action=edit
Bug 15969: Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #51 from Marcel de Rooy --- Processing additional checks * Commit title does not start with 'Bug X: ' - 28c2325c47 * Commit title does not start with 'Bug X: ' - 787cf5cda9 * Commit title does not start with 'Bug X: ' - 01aa2c4bb8 * Commit title does not start with 'Bug X: ' - ce321c3ad3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #50 from Kyle M Hall --- Created attachment 114416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114416&action=edit Bug 15969 - Fetch the message instead of substituting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #49 from Kyle M Hall --- Created attachment 114415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114415&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #48 from Kyle M Hall --- Created attachment 114414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114414&action=edit Bug 15969 - Add unit test of substitution param Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #103181|0 |1
is obsolete||
Attachment #103182|0 |1
is obsolete||
Attachment #103183|0 |1
is obsolete||
Attachment #103184|0 |1
is obsolete||
--- Comment #47 from Kyle M Hall ---
Created attachment 114413
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114413&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Patch doesn't apply CC||martin.renvoize@ptfs-europe ||.com --- Comment #46 from Martin Renvoize --- I was looking to take over on QA here, but the patches no longer apply, unfortunately :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer --- Hi Kyle, I tihnk I need a more detailed test plan here - I have failed to get it working with the existing instructions. How does the letter need to be set up in Koha? (letter code, HTML?, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #44 from Katrin Fischer --- Oh, and please fix the commit lines if you want to make me happy :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #43 from Katrin Fischer --- Turns out, as phone notices are not a thing here at all, I am not sure how this works. In which notice templates (letter codes) do I have to add the TT example code? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #41 from Kyle M Hall --- Created attachment 103183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103183&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #42 from Kyle M Hall --- Created attachment 103184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103184&action=edit Bug 15969 - Fetch the message instead of substituting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #40 from Kyle M Hall --- Created attachment 103182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103182&action=edit Bug 15969 - Add unit test of substitution param Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #71141|0 |1
is obsolete||
Attachment #71142|0 |1
is obsolete||
Attachment #71143|0 |1
is obsolete||
Attachment #71144|0 |1
is obsolete||
--- Comment #39 from Kyle M Hall ---
Created attachment 103181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103181&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Liz Rea changed: What|Removed |Added Status|Failed QA |Patch doesn't apply CC||wizzy...@gmail.com --- Comment #38 from Liz Rea --- Patch does not apply anymore sorry :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Bug 15969 depends on bug 17981, which changed state. Bug 17981 Summary: Add the ability to preview generated notice templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer --- This sentence sounds a little odd to me: +OPTIONAL. If set, processes the notice content as Template Toolkit syntax and sends the content as the CSV line instead +of generated a fixed CSV line. Kyle, can you please answer qustions on comment#34? If you work on the patches, can you please also fix the commit messages (Bug :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #36 from Katrin Fischer --- Unblocking as dependency is passed QA! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Julian Maurice changed: What|Removed |Added Status|Signed Off |BLOCKED CC||julian.maur...@biblibre.com --- Comment #35 from Julian Maurice --- Changing status to BLOCKED as it depends on a "does not apply" bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Signed Off
--- Comment #34 from Jonathan Druart
---
It's not pushed to master yet, still in NQA.
(In reply to Jonathan Druart from comment #7)
> Hi Kyle,
> This patch does a bit more than advertise :)
> 1/ __MESSAGE_ID__ could be used everywhere, not only for phone notice. I
> think this should be covered by tests and documented somewhere (eventually
> added to the notice editor)
Still valid.
> 2/
> +if ( $use_tt ) {
> +$letter->{content} =~ s/__MESSAGE_ID__/$message_id/g;
> +print $OUT $letter->{content};
> +}
>
> Don't you think it would be better to retrieve the notice instead of
> duplicating the substitution? It would be less error prone.
> Btw, why does the script output something different if tt syntax is used?
Still need an answer.
Does the --tt flag really makes sense?
(In reply to Jonathan Druart from comment #27)
> It would also be good to get an independent QA point of view.
Still needed. I will do it myself if no one else does.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Depends on||17981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 [Bug 17981] Add the ability to preview generated notice templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #33 from Kyle M Hall --- (In reply to Jonathan Druart from comment #27) > I'd like to know what it the plan here, I have done a lot of work on bug > 17981 to make the different notices work with the TT syntax. > This patch will conflict with it. > > It would also be good to get an independent QA point of view. Let's hold this one off until your bug is pushed to master. At that point I'll revisit this and make whatever changes are necessary to integrate them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #32 from Kyle M Hall --- Created attachment 71144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71144&action=edit Bug 15969 - Fetch the message instead of substituting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #30 from Kyle M Hall --- Created attachment 71142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71142&action=edit Bug 15969 - Add unit test of substitution param Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #59962|0 |1
is obsolete||
Attachment #59963|0 |1
is obsolete||
Attachment #59964|0 |1
is obsolete||
Attachment #59965|0 |1
is obsolete||
--- Comment #29 from Kyle M Hall ---
Created attachment 71141
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71141&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #31 from Kyle M Hall --- Created attachment 71143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71143&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #28 from Marcel de Rooy --- Applying: Bug 15969 - Add unit test of substitution param fatal: sha1 information is lacking or useless (C4/Letters.pm). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #27 from Jonathan Druart --- I'd like to know what it the plan here, I have done a lot of work on bug 17981 to make the different notices work with the TT syntax. This patch will conflict with it. It would also be good to get an independent QA point of view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #26 from Nick Clemens --- Created attachment 59965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59965&action=edit Bug 15969 - Fetch the message instead of substituting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #25 from Nick Clemens --- Created attachment 59964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59964&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #24 from Nick Clemens --- Created attachment 59963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59963&action=edit Bug 15969 - Add unit test of substitution param Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Nick Clemens changed:
What|Removed |Added
Attachment #59942|0 |1
is obsolete||
Attachment #59943|0 |1
is obsolete||
Attachment #59944|0 |1
is obsolete||
Attachment #59945|0 |1
is obsolete||
--- Comment #23 from Nick Clemens ---
Created attachment 59962
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59962&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #20 from Kyle M Hall --- Created attachment 59943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59943&action=edit Bug 15969 - Add unit test of substitution param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #22 from Kyle M Hall --- Created attachment 59945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59945&action=edit Bug 15969 - Fetch the message instead of substituting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #21 from Kyle M Hall --- Created attachment 59944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59944&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #59923|0 |1
is obsolete||
Attachment #59924|0 |1
is obsolete||
Attachment #59940|0 |1
is obsolete||
Attachment #59941|0 |1
is obsolete||
--- Comment #19 from Kyle M Hall ---
Created attachment 59942
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59942&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Attachment #59937|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 59941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59941&action=edit Bug 15969 - Fetch the message instead of substituting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Attachment #59925|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 59940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59940&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Attachment #59926|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 59937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59937&action=edit Bug 15969 - Fetch the message instead of substituting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #15 from Kyle M Hall --- Created attachment 59926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59926&action=edit Bug 15969 - Fetch the message instead of substituting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #13 from Kyle M Hall --- Created attachment 59924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59924&action=edit Bug 15969 - Add unit test of substitution param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #57931|0 |1
is obsolete||
Attachment #57933|0 |1
is obsolete||
Attachment #57934|0 |1
is obsolete||
Attachment #57935|0 |1
is obsolete||
--- Comment #12 from Kyle M Hall ---
Created attachment 59923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59923&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #14 from Kyle M Hall --- Created attachment 59925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59925&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #11 from Kyle M Hall --- Created attachment 57935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57935&action=edit Bug 15969 - Fetch the message instead of substituting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #10 from Kyle M Hall --- Created attachment 57934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57934&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #9 from Kyle M Hall --- Created attachment 57933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57933&action=edit Bug 15969 - Add unit test of substitution param -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #55820|0 |1
is obsolete||
--- Comment #8 from Kyle M Hall ---
Created attachment 57931
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57931&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #7 from Jonathan Druart
---
Hi Kyle,
This patch does a bit more than advertise :)
1/ __MESSAGE_ID__ could be used everywhere, not only for phone notice. I think
this should be covered by tests and documented somewhere (eventually added to
the notice editor)
2/
+if ( $use_tt ) {
+$letter->{content} =~ s/__MESSAGE_ID__/$message_id/g;
+print $OUT $letter->{content};
+}
Don't you think it would be better to retrieve the notice instead of
duplicating the substitution? It would be less error prone.
Btw, why does the script output something different if tt syntax is used?
3/ C4::Letters::_process_tt takes a new parameter, it should be covered by
tests.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #55819|0 |1
is obsolete||
--- Comment #6 from Kyle M Hall ---
Created attachment 55820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55820&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Kyle M Hall changed:
What|Removed |Added
Attachment #48811|0 |1
is obsolete||
--- Comment #5 from Kyle M Hall ---
Created attachment 55819
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55819&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #4 from Jonathan Druart --- CONFLICT (content): Merge conflict in misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl CONFLICT (content): Merge conflict in C4/Letters.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |BLOCKED --- Comment #3 from Jonathan Druart --- Blocked by bug 14757. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|unspecified |master Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Nicole C. Engard changed:
What|Removed |Added
Attachment #48618|0 |1
is obsolete||
--- Comment #2 from Nicole C. Engard ---
Created attachment 48811
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48811&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
Signed-off-by: Sean McGarvey
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Depends on||14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
--- Comment #1 from Kyle M Hall ---
Created attachment 48618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48618&action=edit
Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices
By allowing the use of Template Toolkit for generating the outgoing
Talking Tech CSV files, we can give libaries more control over the data
they send to Itiva. This enhancement would also make it possible to use
the script for other services since the output is no longer fixed to a
single format.
Test Plan:
1) Apply this patch
2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout
3) Generate the CSV file via the script
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
4) Enable Template Toolkit for the notices and update the notice text to be:
[% FILTER remove("\r\n") %]
"[% format %]",
"[% language %]",
"[% type %]",
"[% level %]",
"[% borrower.cardnumber %]",
"[% borrower.title %]",
"[% borrower.firstname %]",
"[% borrower.surname %]",
"[% borrower.phone %]",
"[% borrower.email %]",
"[% library_code %]",
"[% branch.id %]",
"[% branch.branchname %]",
"[% item.barcode %]",
"[% due_date %]",
"[% biblio.title %]",
"__MESSAGE_ID__"
[% END %]
5) Regenerate the notices
6) Compare the originals, note the format is the same
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
