[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||27452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27452 [Bug 27452] Create GUI for patron_emailer cron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Jonathan Druart changed: What|Removed |Added Blocks||24164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24164 [Bug 24164] Patron emailer cronjob is not generating unique content for notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||cronjob which takes a ||report id, and a notice ||code to be used to send ||custom emails to users ||generated from the report ||content. || ||The notices will ||be able to use any (and ||only) columns included in ||the report in the notice ||templates. User email ||addresses can be specified ||in the report, as well as ||the 'From' address for the ||email. || ||Notices for this ||cronjob must be defined ||using Template Toolkit ||syntax. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED Resolution|--- |FIXED Version(s)||19.05.00 released in|| --- Comment #28 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Josef Moravec changed: What|Removed |Added Blocks||22755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22755 [Bug 22755] Import Koha::Script to patron_emailer cronjob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 88232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88232&action=edit Bug 16149: Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected Signed-off-by: Jessica Ofsa Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 88231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88231&action=edit Bug 16149: Unit tests To test: prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Claire Gravely Signed-off-by: Jessica Ofsa Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85116|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Tomás Cohen Arazi changed: What|Removed |Added Attachment #85117|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #24 from Nick Clemens --- Created attachment 85117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85117&action=edit Bug 16149: Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected Signed-off-by: Jessica Ofsa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #83890|0 |1 is obsolete|| Attachment #83891|0 |1 is obsolete|| --- Comment #23 from Nick Clemens --- Created attachment 85116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85116&action=edit Bug 16149: Unit tests To test: prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Claire Gravely Signed-off-by: Jessica Ofsa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #79329|0 |1 is obsolete|| --- Comment #21 from Nick Clemens --- Created attachment 83890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83890&action=edit Bug 16149: Unit tests To test: prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #79330|0 |1 is obsolete|| --- Comment #22 from Nick Clemens --- Created attachment 83891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83891&action=edit Bug 16149: Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149
--- Comment #20 from Nick Clemens ---
(In reply to Jonathan Druart from comment #16)
> 1.
QA tool complaints fixed
> 2. I think we display something more useful than the error codes
Okay, we now have readable errors
> 3. Please correct indentation
Ah, I think i fixed it
> 4. Reading the tests:
> is( $result[0]{NO_EMAIL_COL}, 2, "Warning only for patron with no email");
> Why 2?
2 is the row with the error - the returned has includes the error and
referenced row (unless borrowernumber not found, then it is the wrong
borrowernumber)
> 5. The cronjob script has too many use statements
Yes, CP error, cleaned
> 6. I do not think the subroutine should take "commit", maybe it should
> return the notice instead?
> Same for verbose actually.
Okay, moved those and the sending into the cronjob
> 7. Subroutine takes "branch" whereas the script pass "branchcode" (!)
Oops, fixed
> 8. POD says "--report Specify a saved SQL report in the Koha system to user
> for the emails."
> It's actually the *id* (saved_sql.id), maybe it should be more explicit
Fixed
> 9. --email, should not we use Koha::Patron->notice_email_address and remove
> this option?
This is designed to be more flexible and let the report determine the content -
perhaps the library w3ants to check secondary emails or something?
> 10. --from specified email for 'from' address, report
> column 'from' used if not specified
> Should not we use branches.branchemail instead?
Again, designed for flexibility in allowing report to set this - perhaps we
want to send emails for patron clubs and they have their own email?
This was designed to so that it is a cronjob now, but also so it could be used
in a script in the GUI.
This was a major refactoring, back to NSO
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #79328|0 |1 is obsolete|| --- Comment #19 from Nick Clemens --- Created attachment 79330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79330&action=edit Bug 16149: Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #18 from Nick Clemens --- Created attachment 79329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79329&action=edit Bug 16149: Unit tests To test: prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #78896|0 |1 is obsolete|| Attachment #78897|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 79328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79328&action=edit Bug 16149: Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Status|Signed Off |Failed QA
--- Comment #16 from Jonathan Druart
---
1.
FAIL C4/Reports/Guided.pm
FAIL valid
"my" variable $report masks earlier declaration in same scope
FAIL misc/cronjobs/patron_emailer.pl
FAIL spelling
ommited ==> omitted
sucesses ==> successes
FAIL valid
"my" variable $report masks earlier declaration in same scope
* Commit title does not start with 'Bug X: ' - 2380dc8
* Commit title does not start with 'Bug X: ' - 579e02c
2. I think we display something more useful than the error codes
3. Please correct indentation
4. Reading the tests:
is( $result[0]{NO_EMAIL_COL}, 2, "Warning only for patron with no email");
Why 2?
5. The cronjob script has too many use statements
6. I do not think the subroutine should take "commit", maybe it should return
the notice instead?
Same for verbose actually.
7. Subroutine takes "branch" whereas the script pass "branchcode" (!)
8. POD says "--report Specify a saved SQL report in the Koha system to user for
the emails."
It's actually the *id* (saved_sql.id), maybe it should be more explicit
9. --email, should not we use Koha::Patron->notice_email_address and remove
this option?
10. --from specified email for 'from' address, report
column 'from' used if not specified
Should not we use branches.branchemail instead?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Claire Gravely changed: What|Removed |Added Attachment #78890|0 |1 is obsolete|| Attachment #78891|0 |1 is obsolete|| --- Comment #14 from Claire Gravely --- Created attachment 78896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78896&action=edit [SIGNED-OFF] Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #15 from Claire Gravely --- Created attachment 78897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78897&action=edit [SIGNED-OFF] Bug 16149 - Unit tests To test: prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #67392|0 |1 is obsolete|| Attachment #67393|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 78890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78890&action=edit Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #13 from Nick Clemens --- Created attachment 78891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78891&action=edit Bug 16149 - Unit tests To test: prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Indranil Das Gupta changed: What|Removed |Added CC||indr...@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #11 from Nick Clemens --- (In reply to Hugo Agud from comment #8) > SENDING_SUCCEED => 0 Heh, the line above is reporting the success of row #0, not a failure. Poor design. I altered the patch to count up from 1. Additionally you need the '-commit' option to actually populate the message queue. Please retest and let me know if that works :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #66398|0 |1 is obsolete|| Attachment #66399|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 67392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67392&action=edit Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #10 from Nick Clemens --- Created attachment 67393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67393&action=edit Bug 16149 - Unit tests To test: prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #8 from Hugo Agud --- Hi, I have been able to apply the patch but I am not able to send any mail I have enabled koha mail and I have install postfix... may you help me on this, please? kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ perl patron_emailer.pl -report=1 -notice=ODUE -module=circulation -library=orex -from=i...@orex.es -email=email -verbose LETTER_FOUND => 1 REPORT_FOUND => 1 REPORT_SUCCEED => 1 SENDING_SUCCEED => 0 kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ perl patron_emailer.pl -report=1 -notice=CHECKIN -module=circulation -library=orex -from=i...@orex.es -email=email -verbose LETTER_FOUND => 1 REPORT_FOUND => 1 REPORT_SUCCEED => 1 SENDING_SUCCEED => 0 kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ perl patron_emailer.pl -report=1 -notice=DUE -module=circulation -library=orex -from=i...@orex.es -email=email -verbose LETTER_FOUND => 1 REPORT_FOUND => 1 REPORT_SUCCEED => 1 SENDING_SUCCEED => 0 kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ perl patron_emailer.pl -report=1 -notice=PREDUE -module=circulation -library=orex -from=i...@orex.es -email=email -verbose LETTER_FOUND => 1 REPORT_FOUND => 1 REPORT_SUCCEED => 1 SENDING_SUCCEED => 0 kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ exit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #63455|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 66399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66399&action=edit Bug 16149 - Unit tests To test: prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #63454|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 66398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66398&action=edit Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Hugo Agud changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||ha...@orex.es --- Comment #5 from Hugo Agud --- Bug 16149 - Generate and send custom notices based on report output 63454 - Bug 16149 - Generate and send custom notices based on report output 63455 - Bug 16149 - Unit tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16149 - Generate and send custom notices based on report output Using index info to reconstruct a base tree... M C4/Reports/Guided.pm Falling back to patching base and 3-way merge... Auto-merging C4/Reports/Guided.pm Applying: Bug 16149 - Unit tests Using index info to reconstruct a base tree... M t/db_dependent/Reports/Guided.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reports/Guided.t CONFLICT (content): Merge conflict in t/db_dependent/Reports/Guided.t 6d20h 1.30 2x2.8GHz 3.7G85% 2017-08-23 08:09:18 Failed to merge in the changes. Patch failed at 0001 Bug 16149 - Unit tests The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16149---Unit-tests-IoVGvi.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Attachment #62217|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 63454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63454&action=edit Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #4 from Nick Clemens --- Created attachment 63455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63455&action=edit Bug 16149 - Unit tests To test: prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #2 from Nick Clemens --- Created attachment 62217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62217&action=edit Bug 16149 - Generate and send custom notices based on report output Ths patch add an EmailReport function to C4::Reports::Guided It accepts a notice (module, code, branch) and a report and attempts to email notices to patron, generating content using report content. Notice must be in template toolkit syntax, only columns in report are available for notice. To test: 1 - Specify various options 2 - Ensure errors are returned if options are incomplete or incorrect 3 - Pass a report containing 'from' and 'email' and 'borrowernumber' columns and ensure message queue populated as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Status|NEW |ASSIGNED Change sponsored?|Seeking cosponsors |Sponsored CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 J Schmidt changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 --- Comment #1 from Nicole C. Engard --- *** Bug 15507 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
