[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #12 from Julian Maurice  ---
Created attachment 50209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50209=edit
Bug 16238: Use .prop() instead of .attr() for 'disabled'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #11 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #9)
> Why do you only fix checked?
> There are also disabled and readonly.

No particular reason. I suppose this should be done as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #9 from Jonathan Druart  
---
What do you only fix checked?
There are also disabled and readonly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #10 from Jonathan Druart  
---
s/What/Why

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #8 from Julian Maurice  ---
(In reply to Julian Maurice from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > What about the others occurrences?
> > I have found some others at the OPAC:
> >git grep '\.attr' **/*.tt|grep "'checked'"
> I don't know how I could have missed so many of them. I'll provide a followup
In fact, it's completely normal, bug 15883 only upgrades jQuery for staff
interface, so no changes required in OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #7 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #6)
> What about the others occurrences?
> I have found some others at the OPAC:
>git grep '\.attr' **/*.tt|grep "'checked'"
I don't know how I could have missed so many of them. I'll provide a followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
What about the others occurrences?
I have found some others at the OPAC:
   git grep '\.attr' **/*.tt|grep "'checked'"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Marc Véron  changed:

   What|Removed |Added

  Attachment #50177|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 50194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50194=edit
Bug 16238: QA fix: remove tab characters

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Marc Véron  changed:

   What|Removed |Added

  Attachment #50119|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 50193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50193=edit
Bug 16238: Use .prop() instead of .attr() for 'checked'

According to https://jquery.com/upgrade-guide/1.9/#attr-versus-prop-
.attr() is no longer correct to access the checked state of a checkbox.

This patch do the following replacements:
  .attr('checked')   =>  .prop('checked')
  .attr('checked, '')=>  .prop('checked', false)
  .attr('checked, 'checked') =>  .prop('checked', true)
  .attr('checked', boolValue)=>  .prop('checked', boolValue)
  .removeAttr('checked') =>  .prop('checked', false)
  .attr('checked') == 'checked'  =>  .is(':checked')

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #3 from Julian Maurice  ---
Created attachment 50177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50177=edit
Bug 16238: QA fix: remove tab characters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
QA tools complain at 2 places:


koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
forbidden pattern: tab char (line 6)

koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
forbidden pattern: tab char (line 169)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

--- Comment #1 from Julian Maurice  ---
Created attachment 50119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50119=edit
Bug 16238: Use .prop() instead of .attr() for 'checked'

According to https://jquery.com/upgrade-guide/1.9/#attr-versus-prop-
.attr() is no longer correct to access the checked state of a checkbox.

This patch do the following replacements:
  .attr('checked')   =>  .prop('checked')
  .attr('checked, '')=>  .prop('checked', false)
  .attr('checked, 'checked') =>  .prop('checked', true)
  .attr('checked', boolValue)=>  .prop('checked', boolValue)
  .removeAttr('checked') =>  .prop('checked', false)
  .attr('checked') == 'checked'  =>  .is(':checked')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238

Julian Maurice  changed:

   What|Removed |Added

 Depends on||15883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
[Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/