[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15504 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Colin Campbell changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #46 from Colin Campbell --- New bug 18625 to update the field if 'last seen' is from a sip patron info request (used to validate patron for access to resources) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Blocks||18625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 [Bug 18625] update borrower last seen from SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Blocks||18821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 [Bug 18821] TrackLastPatronActivity is a performance killer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Katrin Fischer changed: What|Removed |Added Summary|When automatically deleting |When automatically deleting |expired borrowers, make |expired borrowers, make |sure they didn't log them |sure they didn't log in |selves recently |recently -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54591|0 |1 is obsolete|| --- Comment #25 from Marcel de Rooy --- Created attachment 54615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54615&action=edit Bug 16276: Make the batch patron deletion tool deal with last_seen This patch adds the same change as the previous one to the batch patron deletion tool. If the pref TrackLastPatronActivity is enabled, the librarians will be able to delete patrons who do not have been connected since a given time. Test plan: Define a date for the "who have not been connected since" options and confirm that it works as expected. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #27 from Marcel de Rooy --- Created attachment 54617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54617&action=edit Bug 16276: [QA Follow-up] Number of tests corrected Applies to t/db_dependent/Members.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54589|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 54613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54613&action=edit Bug 16276: Make delete_patrons.pl deal with --last_seen This patch modify the delete_patrons.pl cronjob to deal with the last_seen option. To test it, you just have to use the --last_seen option and pass a valid date (iso format) Example: perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm will delete all the patrons who do not have been active since this date. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54590|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy --- Created attachment 54614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54614&action=edit Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand With small change: number of tests in t/db_dependent/Members.t https://bugs.koha-community.org/show_bug.cgi?id=12276 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #28 from Marcel de Rooy --- Created attachment 54618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54618&action=edit Bug 16276: [QA Follow-up] Only track when pref is enabled Do not track when the pref has not been enabled. This patch moves the conditional update in Auth.pm to Koha::Patron. And adds a test for the new track_login method. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54592|0 |1 is obsolete|| --- Comment #26 from Marcel de Rooy --- Created attachment 54616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54616&action=edit Bug 16276: Add a new pref TrackLastPatronActivity and new column borrowers.lastseen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54588|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 54612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54612&action=edit Bug 16276: Update borrowers.lastseen when a patron is active In order to add the ability to delete patrons who have been inactive for more than a given time, we need to track down the last time they were active. To do that, we need a new DB column in the borrowers table (lastseen). Note that the borrowers.lastseen column will not be initialised for existing installations (set to NULL) so inactive existing patrons will never be deleted. A workaround would be to init them at the date when the new column will be added. Test plan: 0/ Set the new pref TrackLastPatronActivity on 1/ Log in as a patron (staff or OPAC) 2/ Check that the borrowers.lastseen field has been updated with the current time Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #29 from Marcel de Rooy --- Oops forgot some signoff lines..Hang on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54612|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 54619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54619&action=edit Bug 16276: Update borrowers.lastseen when a patron is active In order to add the ability to delete patrons who have been inactive for more than a given time, we need to track down the last time they were active. To do that, we need a new DB column in the borrowers table (lastseen). Note that the borrowers.lastseen column will not be initialised for existing installations (set to NULL) so inactive existing patrons will never be deleted. A workaround would be to init them at the date when the new column will be added. Test plan: 0/ Set the new pref TrackLastPatronActivity on 1/ Log in as a patron (staff or OPAC) 2/ Check that the borrowers.lastseen field has been updated with the current time Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54618|0 |1 is obsolete|| --- Comment #36 from Marcel de Rooy --- Created attachment 54625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54625&action=edit Bug 16276: [QA Follow-up] Only track when pref is enabled Do not track when the pref has not been enabled. This patch moves the conditional update in Auth.pm to Koha::Patron. And adds a test for the new track_login method. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54617|0 |1 is obsolete|| --- Comment #35 from Marcel de Rooy --- Created attachment 54624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54624&action=edit Bug 16276: [QA Follow-up] Number of tests corrected Applies to t/db_dependent/Members.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54614|0 |1 is obsolete|| --- Comment #32 from Marcel de Rooy --- Created attachment 54621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54621&action=edit Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand With small change: number of tests in t/db_dependent/Members.t https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54615|0 |1 is obsolete|| --- Comment #33 from Marcel de Rooy --- Created attachment 54622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54622&action=edit Bug 16276: Make the batch patron deletion tool deal with last_seen This patch adds the same change as the previous one to the batch patron deletion tool. If the pref TrackLastPatronActivity is enabled, the librarians will be able to delete patrons who do not have been connected since a given time. Test plan: Define a date for the "who have not been connected since" options and confirm that it works as expected. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54616|0 |1 is obsolete|| --- Comment #34 from Marcel de Rooy --- Created attachment 54623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54623&action=edit Bug 16276: Add a new pref TrackLastPatronActivity and new column borrowers.lastseen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Marcel de Rooy changed: What|Removed |Added Attachment #54613|0 |1 is obsolete|| --- Comment #31 from Marcel de Rooy --- Created attachment 54620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54620&action=edit Bug 16276: Make delete_patrons.pl deal with --last_seen This patch modify the delete_patrons.pl cronjob to deal with the last_seen option. To test it, you just have to use the --last_seen option and pass a valid date (iso format) Example: perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm will delete all the patrons who do not have been active since this date. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Attachment #51411|0 |1 is obsolete|| Attachment #54619|0 |1 is obsolete|| Attachment #54620|0 |1 is obsolete|| Attachment #54621|0 |1 is obsolete|| Attachment #54622|0 |1 is obsolete|| Attachment #54623|0 |1 is obsolete|| Attachment #54624|0 |1 is obsolete|| Attachment #54625|0 |1 is obsolete|| --- Comment #37 from Jonathan Druart --- Created attachment 55495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55495&action=edit Bug 16276: Update borrowers.lastseen when a patron is active In order to add the ability to delete patrons who have been inactive for more than a given time, we need to track down the last time they were active. To do that, we need a new DB column in the borrowers table (lastseen). Note that the borrowers.lastseen column will not be initialised for existing installations (set to NULL) so inactive existing patrons will never be deleted. A workaround would be to init them at the date when the new column will be added. Test plan: 0/ Set the new pref TrackLastPatronActivity on 1/ Log in as a patron (staff or OPAC) 2/ Check that the borrowers.lastseen field has been updated with the current time Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #42 from Jonathan Druart --- Created attachment 55500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55500&action=edit Bug 16276: [QA Follow-up] Number of tests corrected Applies to t/db_dependent/Members.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #40 from Jonathan Druart --- Created attachment 55498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55498&action=edit Bug 16276: Make the batch patron deletion tool deal with last_seen This patch adds the same change as the previous one to the batch patron deletion tool. If the pref TrackLastPatronActivity is enabled, the librarians will be able to delete patrons who do not have been connected since a given time. Test plan: Define a date for the "who have not been connected since" options and confirm that it works as expected. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #41 from Jonathan Druart --- Created attachment 55499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55499&action=edit Bug 16276: Add a new pref TrackLastPatronActivity and new column borrowers.lastseen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #39 from Jonathan Druart --- Created attachment 55497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55497&action=edit Bug 16276: Change to GetBorrowersToExpunge to take last_seen into account Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand With small change: number of tests in t/db_dependent/Members.t https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #38 from Jonathan Druart --- Created attachment 55496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55496&action=edit Bug 16276: Make delete_patrons.pl deal with --last_seen This patch modify the delete_patrons.pl cronjob to deal with the last_seen option. To test it, you just have to use the --last_seen option and pass a valid date (iso format) Example: perl misc/cronjobs/delete_patrons.pl --last_seen="1984-02-04" --confirm will delete all the patrons who do not have been active since this date. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand https://bugs.koha-community.org/show_bug.cgi?id=12276 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 --- Comment #43 from Jonathan Druart --- Created attachment 55501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55501&action=edit Bug 16276: [QA Follow-up] Only track when pref is enabled Do not track when the pref has not been enabled. This patch moves the conditional update in Auth.pm to Koha::Patron. And adds a test for the new track_login method. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #44 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Blocks||17607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17607 [Bug 17607] Fix patron definition in Swagger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added Blocks||17620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17620 [Bug 17620] Fix format of date/data-times in Swagger definition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added Blocks|17620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17620 [Bug 17620] Fix format of date/data-times in Swagger definition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added Blocks||17621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17621 [Bug 17621] API: Should the 'update_on' Patron field really be a datetime? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added Blocks|17621 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17621 [Bug 17621] API: Should the 'update_on' Patron field really be a datetime? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com Status|Pushed to Master|Pushed to Stable --- Comment #45 from Mason James --- (In reply to Kyle M Hall from comment #44) > Pushed to master for 16.11, thanks Jonathan, Marcel! enhancement, passing for 16.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Mason James changed: What|Removed |Added Status|Pushed to Stable|Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Blocks||17713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 [Bug 17713] Members.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added Blocks||17820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820 [Bug 17820] Do not use search->next when find can be used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart changed: What|Removed |Added CC||neng...@gmail.com --- Comment #47 from Jonathan Druart --- *** Bug 15504 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #48 from Nick Clemens --- Followup pushed to fix the update feedback http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=55332977bf4d70de9d78c324ad88b302d2174c10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Nick Clemens changed: What|Removed |Added Text to go in the||Update statement adjusted, release notes||not new for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added Text to go in the|Update statement adjusted, |Update statement adjusted, release notes|not new for 19.05 |not new for 19.05 or ||18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #49 from Martin Renvoize --- Followup pushed to 18.11.x series too.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Martin Renvoize changed: What|Removed |Added Text to go in the|Update statement adjusted, |Correction to update release notes|not new for 19.05 or|statement, feature actually |18.11.x series. |added in 16.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #50 from Lucas Gass --- skipping enhancement for 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Nick Clemens changed: What|Removed |Added Text to go in the|Correction to update|RMNOTE - Remove from release notes|statement, feature actually |release notes, Correction |added in 16.11. |to update statement, ||feature actually added in ||16.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
