[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #13 from Owen Leonard  ---
This interface still needs work but it's going to end up being quite different
after Bug 23501 so I think this should be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Owen Leonard  changed:

   What|Removed |Added

 Depends on||23501


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501
[Bug 23501] Drag-and-drop hold reordering in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #12 from Andreas Hedström Mace  ---
It seems I was a but quick when I looked over the comments for this bug, I
assumed there was a working patch that I could test but reading the comments
again (more thoroughly!) it seems it was more in discussion? Should I change
the status back to Needs Signoff or maybe In Discussion?

My two cents is that a drag and drop option, combined with an action menu to be
accessible, sounds like the best way to go. (Actually the holds page in the
staff interface is the one who got singled out as most in need of re-work when
we did some UX work on Koha, and anything that can be done to make it
easier/more understandable is great!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Andreas Hedström Mace  changed:

   What|Removed |Added

 CC||andreas.hedstrom.mace@sub.s
   ||u.se
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #11 from Andreas Hedström Mace  ---
Patch doesn't apply for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Academy
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #10 from Christopher Brannon  ---
Yeah.  Kinda thought that.  Okay.  How about this: An action item that says
"Change hold priority" and then a modal box asking for position?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #9 from Katrin Fischer  ---
Hm, if there are a lot of holds a submenu with the positions might get out of
hand. Let's keep thinking about this a bit more.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #8 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #7)
> I think it might be worth having both, options in the menu and drag & drop,
> because the latter is probably not accessible.

Then how about in addition to the drag and drop, having a single "Move hold"
action item with a submenu that shows possible rankings, and defaults to the
current ranking position.  Just click on the new ranking placement, rather than
bumping up or down, or bumping to the top or bottom?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #7 from Katrin Fischer  ---
I think it might be worth having both, options in the menu and drag & drop,
because the latter is probably not accessible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #6 from Christopher Brannon  ---
Kyle and I were talking about this, and he brought up the idea of just
rearranging the elements physically (drag and drop).  So what if you removed
all the move options (except for pin to bottom) and did something like that? 
Kyle pointed out this code:

http://jqueryui.com/sortable/

Worth a discussion.

I still like the action menu, but we could have less in the menu and even get
rid of the priority dropdown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4230

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #5 from Kyle M Hall  ---
 It does make moving a hold a number of places up or down a bit more
cumbersome, but it's also more self-explanitory. I'm torn. Even in it's current
state it's a bit cumbersome with the page reloading between each move. I think
this table would really benefit from the re-ordering being done via ajax in
some fashion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #4 from Owen Leonard  ---
Created attachment 51935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51935=edit
Bug 16421 - Move hold edit actions into dropdown menu

This patch modifies the view of existing holds in the staff client so
that holds-related actions are moved into an 'actions' menu. This
includes priority-reordering controls, suspend, and cancel.

This patch also modifies the display of details for each hold so that
its suspension or priority status is clear.

To test, apply the patch and view holds for a title with multiple holds.

- Test the priority-reordering controls and confirm that they work
  correctly.
- Test the "suspend" link and confirm that the suspension form is
  displayed correctly in a modal window.
  - Confirm that suspensions are saved correctly with and without a
date, and that suspension information is displayed correctly after
saving.
- Test the "Cancel hold" link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #3 from Katrin Fischer  ---
Hm, I think we should try and get more people to look at this :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #2 from Owen Leonard  ---
> first option being the most flexible, as you can do all 4 with less clicks.

I don't think the dropdown menu with the numbers is necessarily the most
convenient if you have a lot of holds. For instance, moving hold number 50 up
one space would required a lot of scrolling through numbers.

I think it could be argued that by moving the arrows into a menu I have taken
away the convenience they offer by being visible all the time.

At my library we don't monkey with holds priorities much, so I don't use the
options in a real-life situation very often.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I like it!

But something I wonder about: do we really need all 5 options for changing the
holds sequence? 
We have the pull down which allows you to select a new number, we have up,
down, to the bottom, to the top.
The first and the last 4 allow you to achieve the same thing - with the first
option being the most flexible, as you can do all 4 with less clicks.
Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Katrin Fischer  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/