[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16749 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #5 from Marcel de Rooy--- WIP: Still working on the last patch a little. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #4 from Marcel de Rooy--- Created attachment 52467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52467=edit Bug 16733: Adjust debian scripts for hardcoded PERL5LIBs koha-foreach, koha-upgrade-schema (shell scripts): [1] Read default file [2] Include helper functions [3] Add call to adjust_paths_dev_install [4] Replace hardcoded path by $PERL5LIB koha-shell (perl script): [1] Remove hardcoded lib path [2] Add a sub that reads PERL5LIB from default or koha-conf, just as the shell scripts do. koha-plack (shell script), plack.psgi: [1] Add call to adjust_paths_dev_install [2] Remove hardcoded lib path [3] Add installer path to PERL5LIB, remove it from plack.pgsi koha-sitemap (shell script): [1] Add call to adjust_paths_dev_install [2] Remove hardcoded lib path [3] Add installer path to PERL5LIB [4] Adjust path for call to sitemap cron job koha-start-sip (shell script): [1] Read default file [2] Include helper functions [3] Add call to adjust_paths_dev_install [4] Adjust path to C4/SIP koha-stop-sip (shell script): [1] Remove KOHA_CONF and PERL5LIB (not needed to stop the daemon) [2] Same for paths in daemon client options NOTE: Script debian/scripts/koha-upgrade-to-3.4 has been left out intentionally. Test plan: [1] Regular install: Run koha-foreach echo Hi Run koha-upgrade-schema yourinstance Run koha-shell yourinstance If you have plack, run koha-plack --start|--stop yourinstance Run koha-sitemap --generate yourinstance Run koha-start-sip yourinstance Run koha-stop-sip yourinstance [2] Dev install [yourinstance] with in koha-conf.xml: Run koha-upgrade-schema yourinstance Run koha-shell yourinstance If you have plack: koha-plack --start|--stop yourinstance Run koha-sitemap --generate yourinstance Run koha-start-sip yourinstance Run koha-stop-sip yourinstance [3] Git grep on koha/lib You should no longer see occurrences in debian/scripts except: koha-translate: see report 16749 koha-upgrade-to-3.4: left out intentionally [4] Git grep on koha/bin You should only see hits for lines with koha-functions in the debian scripts except: koha-upgrade-to-3.4: left out intentionally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #2 from Marcel de Rooy--- Created attachment 52465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52465=edit Bug 16733: Adjust koha-indexer [1] Add a call to the new adjust_paths_dev_install [2] Differentiate location of rebuild_zebra.pl NOTE: The scripts assume koha-functions.sh to be in /usr/share/koha/bin. Finding a better location for this shell library may be hard. Test plan: Run koha-indexer for a regular package install or a dev install. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #3 from Marcel de Rooy--- Created attachment 52466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52466=edit Bug 16733: Adjust koha-rebuild-zebra [1] Add a call to the new adjust_paths_dev_install [2] Differentiate location of rebuild_zebra.pl [3] Replace a hardcoded path by $PERL5LIB Test plan: Adjust a biblio record in package or dev install. Run koha-rebuild-zebra -b -z for same instance. Verify that the change has been indexed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #1 from Marcel de Rooy--- Created attachment 52464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52464=edit Bug 16733: Add adjust_paths_dev_install to koha-functions.sh This new function checks koha-conf.xml for a given instance and if it contains a dev_install line, it adjusts PERL5LIB and KOHA_HOME accordingly. Otherwise it does not touch the values of these variables as normally read from /etc/default/koha-common. The function will be used in various debian scripts to allow for more flexibility with dev installs. And at the same time aiming to make better use of PERL5LIB and KOHA_HOME. Test plan: [1] Add /not/there to your koha-conf.xml. [2] Run on the command line: PERL5LIB=test source [path-to-your-instance]/debian/scripts/koha-functions.sh echo $PERL5LIB adjust_paths_dev_install [name-of-your-instance] echo $PERL5LIB The last echo should be: /not/there [3] Remove the line and repeat step 2. The last echo should be: test Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Marcel de Rooychanged: What|Removed |Added Blocks||16749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 [Bug 16749] Follow-up for bug 16733: changes for koha-translate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16733] Adjust or make flexible some paths in debian scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Marcel de Rooychanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/