[Koha-bugs] [Bug 16754] Use validation plugin when adding or editing budgets

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52463|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16754] Use validation plugin when adding or editing budgets

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #2 from Owen Leonard  ---
I see that the date comparison operation is handled better in other templates.
I'm going to revise this patch to try to incorporate a working version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16754] Use validation plugin when adding or editing budgets

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

--- Comment #1 from Owen Leonard  ---
Created attachment 52463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52463&action=edit
Bug 16754 - Use validation plugin when adding or editing budgets

This patch removes the custom javascript form validation from the budget
edit template and replaces it with validation via the validation plugin.

I did not reproduce the date comparison portion of the script because it
didn't work correctly in many cases. The datepicker enforces the
requirement that the budget start date precedes the budget end date.

Also changed: I added the "Required" text next to required fields.

To test, apply the patch and test the budget creation process for
adding, editing, and duplicating budgets. In all cases:

- The start date and end date should be required
- The description should be required
- The budget amount should be required to be a number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16754] Use validation plugin when adding or editing budgets

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/