[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #14 from Marjorie Barry-Vila --- (In reply to Martin Renvoize from comment #11) > With the introduction of a discounts process in accounts with bug 24081 I > think this is resolved. Hi Martin, Katrin is right. The new feature for making a discount does not allow you to increase the amount of the fine. For example, it is convenient to be able to change an amount when a replacement price no longer matches the market value of an item. Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #13 from Katrin Fischer --- What if you made the fine too low and want to fix that? I am not sure if this is really fixed by the discount feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What|Removed |Added Resolution|FIXED |DUPLICATE --- Comment #12 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 24081 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #11 from Martin Renvoize --- With the introduction of a discounts process in accounts with bug 24081 I think this is resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer changed: What|Removed |Added Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What|Removed |Added Assignee|david.bourga...@inlibro.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #10 from Martin Renvoize --- I'm going to assume David Bourgault isn't going to get back to this and unassign it so we can fold it into the accounts tree afresh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #9 from Martin Renvoize --- Hmm, should we use 'adjust' or should we create a new credit/debit and offset against the original for this. I'm torn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer changed: What|Removed |Added CC||neng...@gmail.com --- Comment #8 from Katrin Fischer --- *** Bug 2193 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #7 from Kyle M Hall --- 4) Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #6 from Jonathan Druart --- So... once and for all: new subroutines cannot be added to the C4 namespace and you have to provide test coverage. We are moving the code from C4 to Koha, so I will not accept more subroutines to C4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall --- Needed to pass qa: 1) Implement use of Account Offsets. Any change to a fee or payment needs to add to the account offsets table from now on. The point of it is to create a full accounting of all changes to accountlines 2) Add a user permission for this functionality 3) Implement using Koha::Account::Line(s)/Offset(s) instead of using direct SQL queries. These new subs should live in Koha::Account::Line since they are operating on individual accountlines. We need to reduce the number of subs in the C4 namespace instead of adding to them ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |david.bourga...@inlibro.com |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #4 from Katrin Fischer --- Please also consider to add a separate permission for this, some libraries might consider it dangerous or not want everyone to be able to do this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] Add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer changed: What|Removed |Added Summary|add possibility to edit |Add possibility to edit |fines |fines CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #3 from Kyle M Hall --- Editing fines should create account offsets to reflect the change in amount to a fine if applicable. It would also be nice if the code use Koha::Account::Line(s) instead of direct sql. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Alex Buckley changed: What|Removed |Added Attachment #67313|0 |1 is obsolete|| --- Comment #2 from Alex Buckley --- Created attachment 67585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67585&action=edit Bug 16820 - Edit accountlines from borrower's profile Adds the option to edit an accountline from a borrower's profile page in the intranet. Test plan : 0) Try to edit an accountline, you can't 1) Apply patch 2) Try to edit an accountline, you can Also solves Bug 2193 Followed test plan, patch worked as described. Also ran QA test tools and all 3 modified files passed Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 David Bourgault changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff CC||david.bourga...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #1 from David Bourgault --- Created attachment 67313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67313&action=edit Bug 16820 - Edit accountlines from borrower's profile Adds the option to edit an accountline from a borrower's profile page in the intranet. Test plan : 0) Try to edit an accountline, you can't 1) Apply patch 2) Try to edit an accountline, you can Also solves Bug 2193 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
