[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Marcel de Rooy  ---
Closed in favor of bug 14399

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14399

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #14 from Marcel de Rooy  ---
Small code review:

+my $datelastseen = $input->param('datelastseen') || $input->param('setdate');
We should not do that. It will disrupt some workflows.
Datelastseen is the inventory date.

-my $dls = output_pref( { dt => dt_from_string( $datelastseen ),
- dateformat => 'iso' } );
+1 for removing those two lines :)
I am removing this whole block on bug 14399. It is weird code.

-if (none { $item->{barcode} eq $_->{barcode} && !$_->{'onloan'} }
@$wrongplacelist) {
+if (none { $_->{barcode} && $item->{barcode} eq $_->{barcode} &&
!$_->{'onloan'} } @$wrongplacelist) {
Looks like rescuable lines to me now.

-ModDateLastSeen($item->{'itemnumber'});
+ModItem({ itemlost => 0, datelastseen => $dls }, undef,
$item->{'itemnumber'});
I understand why you do it. But I guess we might need a checkbox for that ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #13 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #12)
> The datelastseen field on the inventory form is actually useless.

Not completely btw. Bug 12631 describes a scenario with two partial barcode
files and using this inventory date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12913

--- Comment #12 from Marcel de Rooy  ---
Blocking this report temporarily in favor of rescuing bug 12913, taking into
account the comments of David on bug 14399.
The datelastseen field on the inventory form is actually useless.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #11 from Marcel de Rooy  ---
(In reply to Blou from comment #9)
> This patch:
> - Doesn't brake most functionalities.
What does it break? :)

> - Doesn't fix any of the many other bugs and issues with this broken tool.
OK I am looking at several and will try if it is possible to start here..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Blou  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com
 Status|NEW |Needs Signoff

--- Comment #10 from Blou  ---
This is by no mean a great patch.  But our users encountered the problem, and
this fixes it.  When debugging, I found MANY other issues, but I tried to stay
focused on just what was needed for their usage.

A complete overhaul would be needed to make this tool intuitive.  That's not
the goal here.  Just get the users the basics they need.

If more problem encountered (or side effects), we'll fix...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #9 from Blou  ---
Created attachment 60788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60788=edit
Bug 16834 inventory.pl's Set Inventory Date to is ignored

When entering a value in "Set Inventory date to" at the top of the UI, this
value is ignored and the items are always updated with today.
This is (in part) caused by ModDateLastSeen not allowing to set current day.

This patch:
- Makes relevant the date entered at the top (Set Inventory date to).
- Makes relevant the date entered at the bottow (Inventory date).
- Doesn't brake most functionalities.
- Doesn't fix any of the many other bugs and issues with this broken tool.
- remove a warning that was flooding the logs on every call.
- Just makes the UI intuitive for common usage regarding dates.

TEST:
1) find a barcode in your db, write it in a text file
 - set item.datelastseen to some date in the past
2) go to tools/inventory
3) Browse to select the file from 1)
4) Select a date (top) before today, and after the datelastseen entered.
5) Click submit.
6) Validate:
   - Datelastseen specified at the top is the one you entered.
   - Date Last Seen in the table is the old from the DB
   - item.datelastseen is now today
7) Apply the patch.  Validate:
   - item.datelastseen is now the date you entered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Blou  changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #8 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #7)
> Yes it does

Confirmed!

So I found what is the problem, but no idea how to fix it:
inventory.pl calls ModItem and update datelastseen (l.210), but a call to
ModDateLastSeen is done later (l.332). ModDateLastSeen does not accept any
parameters and update datelastseen with the today's date.

My supposition is that bug 14001 introduced this bug by trying to fix something
else.
Maybe we could just remove the call to ModDateLastSeen and handle $moddatecount
somewhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #7 from Nick Clemens  ---
Yes it does

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
Does the issue exist on master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #5 from M. Tompsett  ---
I'm a little groggy right now, but I think there is a setdata vs lastseendate
competition in the code. I'll try to make sense later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #4 from M. Tompsett  ---
(In reply to M. Tompsett from comment #3)
> Upgrading to 3.18.13 will fix the problem.

Hmmm... or maybe not? Because bug 14001 seems to be in 3.18.9.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #3 from M. Tompsett  ---
Upgrading to 3.18.13 will fix the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

--- Comment #2 from Amy Kearns  ---
3.18.09.000

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #1 from M. Tompsett  ---
What version are they running?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/