[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Jonathan Druart changed: What|Removed |Added Summary|Wrong warning "Invalid date |Wrong warning "Invalid date |... passed to output_pre" |... passed to output_pref" |can be carped |can be carped -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848
--- Comment #1 from Jonathan Druart
---
Created attachment 53090
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53090&action=edit
Bug 16848: Prevent invalid warning to be carped from output_pref
>From Koha::DateUtils::output_pref:
$dt = eval { dt_from_string( $str ) } if $str;
carp "Invalid date '$str' passed to output_pref\n" if $@;
This second line is wrong: if $str does not exist, the first line is not
evaluated and $@ could be filled with previous error.
To reproduce:
Then:
prove t/DateUtils.t
will display:
t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or
string at Koha/DateUtils.pm line 217.
Invalid date '' passed to output_pref
at t/DateUtils.t line 233.
t/DateUtils.t .. ok
All tests successful.
Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00
csys = 1.42 CPU)
Result: PASS
Test plan:
Without this patch, you should not see the carp
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848
Srdjan Jankovic changed:
What|Removed |Added
Attachment #53090|0 |1
is obsolete||
--- Comment #2 from Srdjan Jankovic ---
Created attachment 53120
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53120&action=edit
[SIGNED-OFF] Bug 16848: Prevent invalid warning to be carped from output_pref
>From Koha::DateUtils::output_pref:
$dt = eval { dt_from_string( $str ) } if $str;
carp "Invalid date '$str' passed to output_pref\n" if $@;
This second line is wrong: if $str does not exist, the first line is not
evaluated and $@ could be filled with previous error.
To reproduce:
Then:
prove t/DateUtils.t
will display:
t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or
string at Koha/DateUtils.pm line 217.
Invalid date '' passed to output_pref
at t/DateUtils.t line 233.
t/DateUtils.t .. ok
All tests successful.
Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00
csys = 1.42 CPU)
Result: PASS
Test plan:
Without this patch, you should not see the carp
Signed-off-by: Srdjan
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- I took liberty of adding local $@ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #4 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #3) > I took liberty of adding local $@ Are you sure it is useful? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #5 from Srdjan Jankovic --- Probably not that much, but I have a habit of doing that, I believe it is a good practice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Jonathan, Srdjan, is this ready for QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #7 from Srdjan Jankovic --- I think so, unless Jonathan fiercely objects, in which case I'll remove the line that I've added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #8 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #7) > I think so, unless Jonathan fiercely objects, in which case I'll remove the > line that I've added. It should not hurt, so I am ok with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848
Katrin Fischer changed:
What|Removed |Added
Attachment #53120|0 |1
is obsolete||
--- Comment #9 from Katrin Fischer ---
Created attachment 54121
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54121&action=edit
[PASSED QA] Bug 16848: Prevent invalid warning to be carped from output_pref
>From Koha::DateUtils::output_pref:
$dt = eval { dt_from_string( $str ) } if $str;
carp "Invalid date '$str' passed to output_pref\n" if $@;
This second line is wrong: if $str does not exist, the first line is not
evaluated and $@ could be filled with previous error.
To reproduce:
Then:
prove t/DateUtils.t
will display:
t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or
string at Koha/DateUtils.pm line 217.
Invalid date '' passed to output_pref
at t/DateUtils.t line 233.
t/DateUtils.t .. ok
All tests successful.
Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00
csys = 1.42 CPU)
Result: PASS
Test plan:
Without this patch, you should not see the carp
Signed-off-by: Srdjan
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr Status|Pushed to Master|Pushed to Stable --- Comment #11 from Frédéric Demians --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #12 from Frédéric Demians --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #13 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
