[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #17 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Depends on||12051 --- Comment #16 from Julian Maurice --- For reference, this shortcut has been introduced by bug 12051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 [Bug 12051] add renew tab to top on staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #15 from Katrin Fischer --- These patches have been pushed to 16.11.x, will be in 16.11.02 . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Tim, Dani! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer changed: What|Removed |Added Version|16.05 |master --- Comment #13 from Katrin Fischer --- I am not sure the version setting here is correct - I tested this on master pre 16.11 release. I am resetting it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 --- Comment #12 from Martin Renvoize --- Created attachment 56451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56451&action=edit [PASSED QA] Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. Signed-off-by: Jesse Maseto Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Martin Renvoize changed: What|Removed |Added Attachment #55457|0 |1 is obsolete|| Attachment #56114|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 56448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56448&action=edit [PASSED QA] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Jesse Maseto changed: What|Removed |Added Attachment #56105|0 |1 is obsolete|| --- Comment #10 from Jesse Maseto --- Created attachment 56114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56114&action=edit Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Jesse Maseto changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 --- Comment #9 from Danielle Elder --- Created attachment 56105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56105&action=edit Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer changed: What|Removed |Added Attachment #55362|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 55457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55457&action=edit [PASSED QA] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 --- Comment #7 from Katrin Fischer --- The new shortcut for renewal should be added to the help file on the circulation home page! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- In order to select Yes I need to do alt+shift+y - It makes sense as it's a Y, but leaving a note anyway :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Owen Leonard changed: What|Removed |Added Attachment #54941|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 55362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55362&action=edit [SIGNED-OFF] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added Attachment #54941|Bug 16933: Alt+y not|Bug 16933: Alt+y not description|working on "Please confirm |working on "Please confirm |checkout " dialogs |checkout " dialogs | | |The | |keyboard shortcut for renew | |is also set to Alt+y. | |Change the key | |for renew | |from Alt+y to Alt+w. | | | | | |To | |test: | |1) Press Alt+y when | |you get a "Please confirm | |checkout" dialog. | |2) | --- Comment #4 from tmcma...@wlpl.org --- Comment on attachment 54941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54941 Bug 16933: Alt+y not working on "Please confirm checkout " dialogs The keyboard shortcut for renew is also set to Alt+y. Change the key for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added Attachment #54941|0 |1 is patch|| Attachment #54941|Patch to fix Alt+y for |Bug 16933: Alt+y not description|selecting Yes at dialogs. |working on "Please confirm ||checkout " dialogs || ||The ||keyboard shortcut for renew ||is also set to Alt+y. ||Change the key ||for renew ||from Alt+y to Alt+w. || || ||To ||test: ||1) Press Alt+y when ||you get a "Please confirm ||checkout" dialog. ||2) The ||renew tab is selected ||instead of confirming the ||dialog. ||3) Apply the patch ||and refresh your browser to ||load the change. ||4) Repeat ||step one. ||5) Alt+y confirms ||the checkout, Alt+w selects ||the renew tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tmcma...@wlpl.org |ity.org | Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Hello, You patch is not correctly formated. Please have a look at https://wiki.koha-community.org/wiki/SubmitingAPatch and then switch the status to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added Patch complexity|--- |Trivial patch --- Comment #2 from tmcma...@wlpl.org --- I didn't know why Alt+y was used for renew, so I changed it to Alt+w so it doesn't conflict with Alt+y to answer yes in dialogs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added Attachment #54941|Patch to fix Alt+y for |Patch to fix Alt+y for description|selecting Yes to prompts|selecting Yes at dialogs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcma...@wlpl.org changed: What|Removed |Added CC||tmcma...@wlpl.org --- Comment #1 from tmcma...@wlpl.org --- Created attachment 54941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54941&action=edit Patch to fix Alt+y for selecting Yes to prompts This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
