[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #19 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|22.05.00|22.05.00,21.11.02 released in|| --- Comment #18 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #17 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #16 from Katrin Fischer --- Really love to see this one finally fixed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer changed: What|Removed |Added Attachment #128049|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 128705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128705&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #14 from David Nind --- Now tested on a UNIMARC system, and everything works as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What|Removed |Added Text to go in the||This fixes hiding notes release notes||fields (5XX in MARC21 and ||3XX in UNIMARC) using ||NotesToHide. Before this ||you could hide one field ||and it worked. However, ||when hiding multiple fields ||one field would still ||always be visible. Now ||hiding notes fields works ||as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #13 from David Nind --- ... UNIMARC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #12 from David Nind --- (In reply to Florian from comment #10) > Thank you David, a pesky new line had lodged itself in the code since then :p > > I posted the rebased version. Thanks Florian! Things now work as expected and you can hide 500 fields. Note: I only tested the 500 fields in MARC21, and didn't test . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What|Removed |Added Attachment #128041|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 128049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128049&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Florian changed: What|Removed |Added CC||florian.bontemps@biblibre.c ||om Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Florian --- Thank you David, a pesky new line had lodged itself in the code since then :p I posted the rebased version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Florian changed: What|Removed |Added Attachment #126990|0 |1 is obsolete|| --- Comment #9 from Florian --- Created attachment 128041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128041&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind --- With no patch applied and using the latest master, if only 500 is hidden using the NotesToHide system preference then it works as expected. As per comment #2, if I have two 5XX fields with data (say 500 and 504, but I tested and it can be any two fields) and hide all of them 500 still displays. From what I can tell, if all the available 5XX fields are added to NotesToHide, then the first available field still displays. That is, it needs to display at least one field under the description tab in the OPAC and staff interface, and you can't hide them all. To replicate (using koha-testing-docker (KTD) and the default book framework): 1. Add data to each available field for a record (with KTD I used record 262 - Programming Perl). 2. Progressively hide each field until all the 5XX fields available are included in NotesToHide (500,504,505,520,521,522,526,538,541,546,583,586). 3. Up until 586 was added to NotesToHide, everything worked as expected. 4. However, once I added 586, 500 was no longer hidden (all the other fields remained hidden). 5. If I only have data in two fields, say 504 and 526, then 504 is still displayed. The patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17127: Remove notes from detail.tt to only use MARCNOTES Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 17127: Remove notes from detail.tt to only use MARCNOTES -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #7 from Florian --- Created attachment 126990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126990&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Florian changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Pablo López Liotti changed: What|Removed |Added CC||palio...@mdp.edu.ar --- Comment #6 from Pablo López Liotti --- Today this still don`t work. koha 20.05.11 NotesToHide syspref set to 500,520,505 works fine with 520 and 505 but 500 is in description tab. Is there an advance on this little bug? Thks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer changed: What|Removed |Added Summary|Can't blacklist MARC21 500 |Can't hide MARC21 500 and |with NotesToHide|others with NotesToHide -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
