[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #200 from Matthias Le Gac --- (In reply to Laurence Rault from comment #199) > I have forgotten : > html files are exported in ISO-8859 encoding, ot utf8, some diacritics are > not well encoded in the file, example éèàêë So I need to change how is export ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #199 from Laurence Rault --- I have forgotten : html files are exported in ISO-8859 encoding, ot utf8, some diacritics are not well encoded in the file, example éèàêë -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #198 from Laurence Rault --- Got those errors on kdt and on Biblibre's sandboxes. No error in PTFS's sandbox. Tested : everything works OK until 14. From 15 it is not possible to test on a sandbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #197 from Matthias Le Gac --- I don't understand your problem because when I run the test plan, everything works and I don't get any errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Laurence Rault changed: What|Removed |Added CC||laurence.ra...@biblibre.com Status|Needs Signoff |Failed QA --- Comment #196 from Laurence Rault --- When viewing a record, opac or staff : Could not compile /kohadevbox/koha/opac/opac-detail.pl: "CustomXSLTExportList" is not exported by the C4::XSLT module Could not compile /kohadevbox/koha/catalogue/detail.pl: "CustomXSLTExportList" is not exported by the C4::XSLT module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Matthias Le Gac changed: What|Removed |Added Assignee|emily-rose.francoeur@inLibr |matthias.le-...@inlibro.com |o.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #195 from Matthias Le Gac --- Created attachment 163623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163623=edit Bug 17385: (QA follow-up) Add CustomXSLTExportPath & improve descriptions TEST PLAN Prerequisites: - Have more than one record in your catalog Test steps: 1) Search for a record in the intranet 2) Click on the 'Save' button and observe the dropdown menu ---> There is no 'Simple Export' in the dropdown menu 3) Apply the patch 4) In 'Koha administration > System preferences' search 'OpacExportOptions' 5) Enable 'Simple HTML formats' and click on 'Save all OPAC preferences' 6) Repeat steps 1 and 2 ---> There is now 'Simple Export' option in the dropdown menu 7) Click on 'Simple Export' ---> a .html file should be downloaded ---> you should see the record informations in the downloaded file 8) Add some item to your Cart 9) Open your Cart 10) Click on the 'Download' button, then click on 'Simple Export' ---> a .html file should be downloaded ---> you should see the records informations in the downloaded file 11) Add some items to a list 12) Open the list 13) Click on the 'Download list' button, then click on 'Simple Export' ---> a .html file should be downloaded ---> you should see the records informations in the downloaded file 14) Do the same steps in OPAC (steps 6 to 13) 15) On your computer, create a folder that will contain the xsl files in the attachment 16 [review]) In the intranet, go to 'Koha administration > System preferences' and search for 'CustomXSLTExportPath' 17) Write the full path to your created folder and click on the 'Save all Cataloging preferences' 18) Repeat steps 6 to 14 (no need to download this time, only check that 'Simple Export 1' and 'Simple Export 2' are displaying when you click on the 'Save'/'Download'/'Download list' button) 19) In the system preferences search for OpacExportOptions and disable 'Simple HTML formats' 20) Repeat steps 6 to 13 in OPAC ---> Notice that 'Simple Export 1' and 'Simple Export 2' are not in the menu anymore 21) Run 'prove t/db_dependent/XSLT.t' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Matthias Le Gac changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Matthias Le Gac changed: What|Removed |Added Attachment #159147|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Victor Grousset/tuxayo changed: What|Removed |Added Keywords||no-sandbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added Assignee|ivan.dzi...@inlibro.com |emily-rose.francoeur@inLibr ||o.com Status|Failed QA |Needs Signoff --- Comment #194 from Emily-Rose Francoeur --- Created attachment 159148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159148=edit XSLT test files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #193 from Emily-Rose Francoeur --- Created attachment 159147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159147=edit Bug 17385: (QA follow-up) Add CustomXSLTExportPath & improve descriptions Here is a summary the corrections : - Addressed all warnings and failures identified by the QA testing tool - Revised the description of the export format (Removed all instances of 'XSL - ') - Updated the description of the custom option in the OpacExportOptions system preference - Corrected the MARC21_simple_export.xsl file to generate a valid HTML file - Introduced the new preference system CustomXSLTExportPath, allowing users to choose the path for the custom XSL files - Updated the sysprefs.sql file for OpacExportOptions and CustomXSLTExportPath - Added a new atomic update file for OpacExportOptions and CustomXSLTExportPath - Updated XSLT tests (t/db_dependent/XSLT.t) NEW TEST PLAN Prerequisites: - Have more than one record in your catalog Test steps: 1) Search for a record in the intranet 2) Click on the 'Save' button and observe the dropdown menu ---> There is no 'Simple Export' in the dropdown menu 3) Apply the patch 4) In 'Koha administration > System preferences' search 'OpacExportOptions' 5) Enable 'Simple HTML formats' and click on 'Save all OPAC preferences' 6) Repeat steps 1 and 2 ---> There is now 'Simple Export' option in the dropdown menu 7) Click on 'Simple Export' ---> a .html file should be downloaded ---> you should see the record informations in the downloaded file 8) Add some item to your Cart 9) Open your Cart 10) Click on the 'Download' button, then click on 'Simple Export' ---> a .html file should be downloaded ---> you should see the records informations in the downloaded file 11) Add some items to a list 12) Open the list 13) Click on the 'Download list' button, then click on 'Simple Export' ---> a .html file should be downloaded ---> you should see the records informations in the downloaded file 14) Do the same steps in OPAC (steps 6 to 13) 15) On your computer, create a folder that will contain the xsl files in the attachment 16) In the intranet, go to 'Koha administration > System preferences' and search for 'CustomXSLTExportPath' 17) Write the full path to your created folder and click on the 'Save all Cataloging preferences' 18) Repeat steps 6 to 14 (no need to download this time, only check that 'Simple Export 1' and 'Simple Export 2' are displaying when you click on the 'Save'/'Download'/'Download list' button) 19) In the system preferences search for OpacExportOptions and disable 'Simple HTML formats' 20) Repeat steps 6 to 13 in OPAC ---> Notice that 'Simple Export 1' and 'Simple Export 2' are not in the menu anymore 21) Run 'prove t/db_dependent/XSLT.t' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added Attachment #156819|0 |1 is obsolete|| --- Comment #192 from Emily-Rose Francoeur --- Created attachment 159146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159146=edit Bug 17385: Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added Attachment #156818|0 |1 is obsolete|| --- Comment #191 from Emily-Rose Francoeur --- Created attachment 159145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159145=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added Attachment #156817|0 |1 is obsolete|| --- Comment #190 from Emily-Rose Francoeur --- Created attachment 159144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159144=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added Attachment #156816|0 |1 is obsolete|| --- Comment #189 from Emily-Rose Francoeur --- Created attachment 159143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159143=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added Attachment #156815|0 |1 is obsolete|| --- Comment #188 from Emily-Rose Francoeur --- Created attachment 159142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159142=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #187 from Martin Renvoize --- I also agree the hardcoded xslt filepath is incorrect.. those files would get wiped out/replaced at any upgrade as they're assumed to be community maintained. The other xslt driven preferences take a path to allow for overriden sheets that you maintain yourselves. In most cases those custom versions would be under /var/lib/koha/*site*/ for example.. these won't get nuked at upgrades. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #186 from Martin Renvoize --- I can confirm the QA script failures.. 'ktd pull -> ktd up -> ktd --shell -> qa' I tend to run `qa --more-tests` but that won't make any difference here other than to try and run some additional tests if it thinks there are any related. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #185 from Emily-Rose Francoeur --- (In reply to Katrin Fischer from comment #183) > Do you have the latest version of QA script? (separate repository from Koha) Yes, I use the last version of QA Test Tools : https://wiki.koha-community.org/wiki/QA_Test_Tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #184 from Katrin Fischer --- (In reply to Emily-Rose Francoeur from comment #182) > I'd like to provide some clarification regarding point 6. Initially, this > patch was created so that students could have a file containing the basic > notices informations. This would enable them to copy and paste these > informations more easily into their assignments. Therefore, HTML files are > not generated for importing notices afterward, which is why they are > incomplete/invalid for import. I didn't assume they were for import or export, but I think it would not be hard to add the necessary HTML elements to make it a valid file. This will also avoid issues with display in different browsers that might handle invalid diffferently. > I also have some questions regarding point 7. To make sure I understand > correctly, should we add a system preference (e.g., CustomExportFilePath) so > that libraries can choose where they want to place their custom XSL file? If > no path is specified, would the default path be to the > "MARC21_simple_export.xsl" files? Additionally, should we consider renaming > these files to "MARC21CustomSimpleExport.xsl" to align with the naming > conventions of other .xsl files? I need a bit more time for this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #183 from Katrin Fischer --- (In reply to Emily-Rose Francoeur from comment #181) > Hi Katrin, > I ran the QA Test Tools, and I couldn't find any errors or warnings. What > parameters did you use to get errors and warnings for the > opac-detail-sidebar.inc file ? On my end, I ran koha-qa.pl -v 2 -c 5 on a > git installation. I use the most recent version of master and only apply the > patch for this bug. I use the tools without any additional params as "git qa" in ktd. Do you have the latest version of QA script? (separate repository from Koha) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #182 from Emily-Rose Francoeur --- I'd like to provide some clarification regarding point 6. Initially, this patch was created so that students could have a file containing the basic notices informations. This would enable them to copy and paste these informations more easily into their assignments. Therefore, HTML files are not generated for importing notices afterward, which is why they are incomplete/invalid for import. I also have some questions regarding point 7. To make sure I understand correctly, should we add a system preference (e.g., CustomExportFilePath) so that libraries can choose where they want to place their custom XSL file? If no path is specified, would the default path be to the "MARC21_simple_export.xsl" files? Additionally, should we consider renaming these files to "MARC21CustomSimpleExport.xsl" to align with the naming conventions of other .xsl files? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Emily-Rose Francoeur changed: What|Removed |Added CC||emily-rose.francoeur@inLibr ||o.com --- Comment #181 from Emily-Rose Francoeur --- Hi Katrin, I ran the QA Test Tools, and I couldn't find any errors or warnings. What parameters did you use to get errors and warnings for the opac-detail-sidebar.inc file ? On my end, I ran koha-qa.pl -v 2 -c 5 on a git installation. I use the most recent version of master and only apply the patch for this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Martin Renvoize changed: What|Removed |Added CC||m.h...@kingsfund.org.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #180 from Katrin Fischer --- I can see we had a lot of iterations here already. I did some testing to help out, but I think I'll leave it to Marcel to finish: 1) QA test tools We have a fail for TT filters: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc FAIL filters wrong_html_filter at line 90 ( XSL - [% filesOption.filename | html %]) wrong_html_filter at line 90 ( XSL - [% filesOption.filename | html %]) wrong_html_filter at line 90 ( XSL - [% filesOption.filename | html %]) ... and a lot of perltidy warns. 2) Export format pull down +XSL - [% filesOption.filename | html %] and other occurences. As we are not exporting an XSL file, it would be nice to rephrase this. Maybe we should just remove XSL in favor of just having the file name? 3) Export format description In the system preference we have: +custom: XSL - Simple Export * Capitalization * We don't export XSL, I believe something like: Simple HTML format would probably be a better match? * It would also guide any other added custom export format, if I understand correctly, so maybe even: Custom export formats, including simple HTML? +$format = "html" if ($format =~ /^xsl\./); It looks like we always assume it will be an HTML file? 4) Commit messages include no test plan. 5) New option for system preference I think we need a database update adding the option to OpacExportOptions and also update sysprefs.sql. 6) I am struggling with adding the sample files to Koha. They are great for testing this, but I am not sure if they are helpful as they are. At the moment, they are incomplete/invalid HTML files. http://www.loc.gov/MARC21/slim;>Programming Perl / Tom Christiansen, Brian D. Foy Larry Wall.Beijing ; O'Reilly, c2012. 7) The path for the custom formats is not configurable. I guess any files added there by libraries could be potentially be overwritten in updates. If this is for custom formats, maybe we should allow for a custom path as well. Overall the concept here feels a little rough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #179 from Hammat wele --- Created attachment 156819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156819=edit Bug 17385: Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #154382|0 |1 is obsolete|| --- Comment #178 from Hammat wele --- Created attachment 156818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156818=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #154381|0 |1 is obsolete|| --- Comment #177 from Hammat wele --- Created attachment 156817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156817=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #154380|0 |1 is obsolete|| --- Comment #176 from Hammat wele --- Created attachment 156816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156816=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #154379|0 |1 is obsolete|| --- Comment #175 from Hammat wele --- Created attachment 156815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156815=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #154383|1 |0 is patch|| Attachment #154383|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #174 from Katrin Fischer --- Hi Hamat, can you please rebase and re-attach all patches? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17385: Add custom export XSLT Applying: Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Applying: Bug 17385: (QA follow-up) Add caching Applying: Bug 17385: Add tests for CustomXSLTExportList Applying: Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc). error: could not build fake ancestor Patch failed at 0001 Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList Please also run the QA test tools and fix the commit message of the last patch (Fix) should get you a warning in the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #173 from Hammat wele --- Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151381|0 |1 is obsolete|| --- Comment #172 from Hammat wele --- Created attachment 154383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154383=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151380|0 |1 is obsolete|| --- Comment #171 from Hammat wele --- Created attachment 154382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154382=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151379|0 |1 is obsolete|| --- Comment #170 from Hammat wele --- Created attachment 154381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154381=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151378|0 |1 is obsolete|| --- Comment #169 from Hammat wele --- Created attachment 154380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154380=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151377|0 |1 is obsolete|| --- Comment #168 from Hammat wele --- Created attachment 154379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154379=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Eric Bégin changed: What|Removed |Added CC|bouzid.ferg...@gmail.com, |eric.be...@inlibro.com |charles.far...@inlibro.com, | |david.bourga...@inlibro.com | |, | |francois.charbonnier@inlibr | |o.com, | |gabriel.decarufel@inlibro.c | |om, | |ivan.dzi...@inlibro.com,| |the-minh.lu...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151106|0 |1 is obsolete|| --- Comment #167 from Hammat wele --- Created attachment 151381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151381=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151105|0 |1 is obsolete|| --- Comment #166 from Hammat wele --- Created attachment 151380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151380=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151104|0 |1 is obsolete|| --- Comment #165 from Hammat wele --- Created attachment 151379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151379=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151103|0 |1 is obsolete|| --- Comment #164 from Hammat wele --- Created attachment 151378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151378=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #151102|0 |1 is obsolete|| --- Comment #163 from Hammat wele --- Created attachment 151377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151377=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Attachment #151099|0 |1 is obsolete|| --- Comment #162 from David Nind --- Created attachment 151106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151106=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Attachment #151098|0 |1 is obsolete|| --- Comment #161 from David Nind --- Created attachment 151105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151105=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Attachment #151097|0 |1 is obsolete|| --- Comment #160 from David Nind --- Created attachment 151104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151104=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Attachment #151096|0 |1 is obsolete|| --- Comment #159 from David Nind --- Created attachment 151103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151103=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Attachment #151095|0 |1 is obsolete|| --- Comment #158 from David Nind --- Created attachment 151102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151102=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #157 from Hammat wele --- Created attachment 151099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151099=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC > a .html file should be downloaded. > you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141160|0 |1 is obsolete|| --- Comment #156 from Hammat wele --- Created attachment 151098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151098=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141159|0 |1 is obsolete|| --- Comment #155 from Hammat wele --- Created attachment 151097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151097=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141158|0 |1 is obsolete|| --- Comment #154 from Hammat wele --- Created attachment 151096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151096=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141157|0 |1 is obsolete|| --- Comment #153 from Hammat wele --- Created attachment 151095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151095=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141164|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141163|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141162|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141161|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141164|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141163|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141162|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #144384|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141161|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141160|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141157|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #144384|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #144335|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #144380|0 |1 is obsolete|| --- Comment #152 from Hammat wele --- Created attachment 144384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144384=edit This patch adds 'XSL-Simple Export' when saving a bibliographic record To test: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. 3) Notice that 'XSL- Simple Export' is not in the menu. 4) Apply the patch. 5) In System preferences search for OpacExportOptions and enable XSL 6) Repeat the steps 1 and 2. 7) Notice that 'XSL - Simple Export' is in the menu. 8) Click on 'XSL - Simple Export'. A .html file should be downloaded. 9) Open the .html file. You should see the record's informations. 10) Add some items to your Cart 11) Open the Cart 12) Click on the 'Download' button and observe the dropdown menu. 13) Notice that 'XSL - Simple Export' is in the menu. 14) Click on 'XSL - Simple Export'. A .html file should be downloaded. 15) Open the .html file. You should see the record's informations. 16) Add some items to a List 17) Open the List 18) Click on the 'Download' button and observe the dropdown menu. 19) Notice that 'XSL - Simple Export' is in the menu. 20) Click on 'XSL - Simple Export'. A .html file should be downloaded. 21) Open the .html file. You should see the record's informations. 22) Do the same steps in OPAC 23) In System preferences search for OpacExportOptions and disable XSL 24) Repeat all steps 25) Notice that 'XSL - Simple Export' is no more in the menus. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141162|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141164|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141163|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141161|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added CC||hammat.w...@inlibro.com Attachment #141160|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #144336|0 |1 is obsolete|| --- Comment #151 from Hammat wele --- Created attachment 144380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144380=edit This patch adds 'XSL-Simple Export' when saving a bibliographic record To test: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. 3) Notice that 'XSL- Simple Export' is not in the menu. 4) Apply the patch. 5) In System preferences search for OpacExportOptions and enable XSL 6) Repeat the steps 1 and 2. 7) Notice that 'XSL - Simple Export' is in the menu. 8) Click on 'XSL - Simple Export'. A .html file should be downloaded. 9) Open the .html file. You should see the record's informations. 10) Add some items to your Cart 11) Open the Cart 12) Click on the 'Download' button and observe the dropdown menu. 13) Notice that 'XSL - Simple Export' is in the menu. 14) Click on 'XSL - Simple Export'. A .html file should be downloaded. 15) Open the .html file. You should see the record's informations. 16) Add some items to a List 17) Open the List 18) Click on the 'Download' button and observe the dropdown menu. 19) Notice that 'XSL - Simple Export' is in the menu. 20) Click on 'XSL - Simple Export'. A .html file should be downloaded. 21) Open the .html file. You should see the record's informations. 22) Do the same steps in OPAC 23) In System preferences search for OpacExportOptions and disable XSL 24) Repeat all steps 25) Notice that 'XSL - Simple Export' is no more in the menus. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #150 from Hammat wele --- Created attachment 144336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144336=edit This patch adds 'XSL-Simple Export' when saving a bibliographic record To test: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. 3) Notice that 'XSL- Simple Export' is not in the menu. 4) Apply the patch. 5) In System preferences search for OpacExportOptions and enable XSL 6) Repeat the steps 1 and 2. 7) Notice that 'XSL - Simple Export' is in the menu. 8) Click on 'XSL - Simple Export'. A .html file should be downloaded. 9) Open the .html file. You should see the record's informations. 10) Add some items to your Cart 11) Open the Cart 12) Click on the 'Download' button and observe the dropdown menu. 13) Notice that 'XSL - Simple Export' is in the menu. 14) Click on 'XSL - Simple Export'. A .html file should be downloaded. 15) Open the .html file. You should see the record's informations. 16) Add some items to a List 17) Open the List 18) Click on the 'Download' button and observe the dropdown menu. 19) Notice that 'XSL - Simple Export' is in the menu. 20) Click on 'XSL - Simple Export'. A .html file should be downloaded. 21) Open the .html file. You should see the record's informations. 22) Do the same steps in OPAC 23) In System preferences search for OpacExportOptions and disable XSL 24) Repeat all steps 25) Notice that 'XSL - Simple Export' is no more in the menus. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What|Removed |Added Attachment #141157|0 |1 is obsolete|| --- Comment #149 from Hammat wele --- Created attachment 144335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144335=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #148 from David Nind --- Hi Shi Yao Wang. I've retested, using the consolidated test plan in comment #128 - please provide an update if anything for testing needs changing. Things I've noted - and the reasons for changing to Failed QA: 1. For the staff interface: - For an individual record, the Save > XSL - Simple Export works as expected - For the cart and lists: . XSL - Simple Export appears in the list of download options . there are error traces if this option is selected Error trace - staff interface cart: Undefined subroutine ::Compile::ROOT::kohadevbox_koha_basket_downloadcart_2epl::XSLTParse4Display called at /kohadevbox/koha/basket/downloadcart.pl line 83. at /kohadevbox/koha/basket/downloadcart.pl line 71 Error trace - staff interface lists: Undefined subroutine ::Compile::ROOT::kohadevbox_koha_virtualshelves_downloadshelf_2epl::XSLTParse4Display called at /kohadevbox/koha/virtualshelves/downloadshelf.pl line 85. at /kohadevbox/koha/virtualshelves/downloadshelf.pl line 75 2. For the OPAC: - For an individual record, the Save record > XSL - Simple Export works as expected - For the cart and lists: XSL - Simple Export does not appear in the list of download options 3. Tests fail for prove -l t/XSLT.t: root@kohadevbox:koha(bz17385)$ prove -l t/XSLT.t t/XSLT.t .. 2/12 # Failed test 'CustomXSLTExportList finds custom XSLTs' # at t/XSLT.t line 107. # Failed test 'Title is specified in root node' # at t/XSLT.t line 108. Use of uninitialized value in string eq at t/XSLT.t line 109. # Failed test 'Title is filename if not specified' # at t/XSLT.t line 109. # Looks like you failed 3 tests of 12. t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/12 subtests Test Summary Report --- t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 10-12 Non-zero exit status: 3 Files=1, Tests=12, 5 wallclock secs ( 0.02 usr 0.00 sys + 3.91 cusr 0.17 csys = 4.10 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139284|0 |1 is obsolete|| --- Comment #147 from Shi Yao Wang --- Created attachment 141164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141164=edit Bug 17385: Add missing imports and equivalent code for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139283|0 |1 is obsolete|| --- Comment #146 from Shi Yao Wang --- Created attachment 141163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141163=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139282|0 |1 is obsolete|| --- Comment #145 from Shi Yao Wang --- Created attachment 141162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141162=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139281|0 |1 is obsolete|| --- Comment #144 from Shi Yao Wang --- Created attachment 141161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141161=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139280|0 |1 is obsolete|| --- Comment #143 from Shi Yao Wang --- Created attachment 141160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141160=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139279|0 |1 is obsolete|| --- Comment #142 from Shi Yao Wang --- Created attachment 141159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141159=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139278|0 |1 is obsolete|| --- Comment #141 from Shi Yao Wang --- Created attachment 141158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141158=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #139277|0 |1 is obsolete|| --- Comment #140 from Shi Yao Wang --- Created attachment 141157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141157=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #139 from Shi Yao Wang --- Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #138132|0 |1 is obsolete|| --- Comment #138 from Shi Yao Wang --- Created attachment 139284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139284=edit Bug 17385: Add missing imports and equivalent code for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #138088|0 |1 is obsolete|| --- Comment #137 from Shi Yao Wang --- Created attachment 139283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139283=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Shi Yao Wang changed: What|Removed |Added Attachment #138087|0 |1 is obsolete|| --- Comment #136 from Shi Yao Wang --- Created attachment 139282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139282=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
