[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 --- Comment #1 from Lari Taskula --- Created attachment 56106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56106&action=edit Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl members/moremember.pl will set mobile number as smsalertnumber in template if smsalertnumber is not defined. This will cause incorrect display for SMS number in patron's Details-tab. This confusion between smsalertnumber and mobile is already fixed in Bug 14683, but members/moremember.pl was not fixed yet. This is a minor issue since it won't occur for manually added new patrons due to fixes already pushed in Bug 14683, but in case patron's smsalertnumber is null in database, this bug can be replicated: To test: 1. Set EnhancedMessagingPreferences to "Allow" and make sure SMSSendDriver has been set. 2. Add a new patron, give it a mobile/other phone number. 3. Run a SQL query: update koha.borrowers set smsalertnumber=NULL where borrowernumber=XXX; (replace XXX with your new patron's borrowernumber) 4. Go to patron's details tab and observe that SMS number shows the mobile/ other phone you provided earlier. 5. Apply patch. 6. Refresh patron's details tab. 7. Observe that smsalertnumber is now empty, as it should be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Lari Taskula changed: What|Removed |Added Patch complexity|--- |Trivial patch Depends on||14683 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 [Bug 14683] Unable to clear SMS number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Marc Véron changed: What|Removed |Added Attachment #56106|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 56120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56120&action=edit Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl members/moremember.pl will set mobile number as smsalertnumber in template if smsalertnumber is not defined. This will cause incorrect display for SMS number in patron's Details-tab. This confusion between smsalertnumber and mobile is already fixed in Bug 14683, but members/moremember.pl was not fixed yet. This is a minor issue since it won't occur for manually added new patrons due to fixes already pushed in Bug 14683, but in case patron's smsalertnumber is null in database, this bug can be replicated: To test: 1. Set EnhancedMessagingPreferences to "Allow" and make sure SMSSendDriver has been set. 2. Add a new patron, give it a mobile/other phone number. 3. Run a SQL query: update koha.borrowers set smsalertnumber=NULL where borrowernumber=XXX; (replace XXX with your new patron's borrowernumber) 4. Go to patron's details tab and observe that SMS number shows the mobile/ other phone you provided earlier. 5. Apply patch. 6. Refresh patron's details tab. 7. Observe that smsalertnumber is now empty, as it should be. Followed test plan, works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Katrin Fischer changed: What|Removed |Added Attachment #56120|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 57669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57669&action=edit [PASSED QA] Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl members/moremember.pl will set mobile number as smsalertnumber in template if smsalertnumber is not defined. This will cause incorrect display for SMS number in patron's Details-tab. This confusion between smsalertnumber and mobile is already fixed in Bug 14683, but members/moremember.pl was not fixed yet. This is a minor issue since it won't occur for manually added new patrons due to fixes already pushed in Bug 14683, but in case patron's smsalertnumber is null in database, this bug can be replicated: To test: 1. Set EnhancedMessagingPreferences to "Allow" and make sure SMSSendDriver has been set. 2. Add a new patron, give it a mobile/other phone number. 3. Run a SQL query: update koha.borrowers set smsalertnumber=NULL where borrowernumber=XXX; (replace XXX with your new patron's borrowernumber) 4. Go to patron's details tab and observe that SMS number shows the mobile/ other phone you provided earlier. 5. Apply patch. 6. Refresh patron's details tab. 7. Observe that smsalertnumber is now empty, as it should be. Followed test plan, works as expected. Signed-off-by: Marc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Lari! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #5 from Julian Maurice --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17419] Fix more confusion between smsalertnumber and mobile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17419 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/