[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

--- Comment #9 from Jonathan Druart  
---
This patch is no longer relevant, it has been fixed by
  commit 45cffd874c62c7b090390c5fb3c955c31f524608
Bug 17901: Fix possible SQL injection in shelf editing

However we could update the existing bad data anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

--- Comment #8 from Marcel de Rooy  ---
(In reply to Blou from comment #6)
> But the data is there, the user doesn't really care that it won't happen
> anymore with the new interface.  It seems that a simple default value is a
> very valid programming.  In this case and in most others.
> 
> This is not a failed QA.  This is a "In Discussion" death sentence...

This is not a death sentence. Just add a small atomicupdate dbrev. I do not
have a strong opinion about the line in opac-shelves. It should not be
necessary, but it would not hurt either.

Although Failed QA or In Discussion may look like the final destination of some
patches, this generally speaking does not have to be so. (This one is not in
that category at all.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

--- Comment #7 from Jonathan Druart  
---
(In reply to Blou from comment #6)
> But the data is there, the user doesn't really care that it won't happen
> anymore with the new interface.  It seems that a simple default value is a
> very valid programming.  In this case and in most others.
> 
> This is not a failed QA.  This is a "In Discussion" death sentence...

Hum? Marcel is just asking the same thing as me: update the existing bad data.
so set searchfield="title" where searchfield is null or "" and we are done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

--- Comment #6 from Blou  ---
But the data is there, the user doesn't really care that it won't happen
anymore with the new interface.  It seems that a simple default value is a very
valid programming.  In this case and in most others.

This is not a failed QA.  This is a "In Discussion" death sentence...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Marcel de Rooy  ---
Cannot reproduce this from the interface.
The request for a dbrev repairing bad data is a valid one.

Changing status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
This should no longer be possible from the interface, so what about updating
the bad data as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Marc Véron  changed:

   What|Removed |Added

  Attachment #57010|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 57104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57104=edit
Bug 17526 - OPAC lists require a sortfield

Using the OPAC, going into the public lists, we click one of them and get

DBIx::Class::Storage::DBI::_dbh_execute(): You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'ASC LIMIT 10) `me`  JOIN `biblio` `biblionumber` ON
`biblionumber`.`biblionumber'

THis is because the sortfield is empty and creates a SQL like GROUP BY ASC
LIMIT 10.  Missing the group by .
In the intranet list, there's a default usage of 'title' that makes it all
work.

TESTING:
1) just create a public list with no sortfield.  In the DB:
   - virtualshelves.category = 2
   - virtualshelves.sortfield = ''
2) click on the list in the OPAC's public list.  Boom!

This simple patch uses 'title' if nothing else is specified.

Reproduced. Patch fixes issue as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

--- Comment #2 from Blou  ---
Created attachment 57010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57010=edit
Bug 17526 - OPAC lists require a sortfield

Using the OPAC, going into the public lists, we click one of them and get

DBIx::Class::Storage::DBI::_dbh_execute(): You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'ASC LIMIT 10) `me`  JOIN `biblio` `biblionumber` ON
`biblionumber`.`biblionumber'

THis is because the sortfield is empty and creates a SQL like GROUP BY ASC
LIMIT 10.  Missing the group by .
In the intranet list, there's a default usage of 'title' that makes it all
work.

TESTING:
1) just create a public list with no sortfield.  In the DB:
   - virtualshelves.category = 2
   - virtualshelves.sortfield = ''
2) click on the list in the OPAC's public list.  Boom!

This simple patch uses 'title' if nothing else is specified.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Blou  changed:

   What|Removed |Added

   Severity|minor   |normal
   Patch complexity|--- |Trivial patch
 CC||eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com
   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com

--- Comment #1 from Blou  ---
This also happens in 3.22, btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/