[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 --- Comment #1 from Jonathan Druart --- Created attachment 57076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57076&action=edit Bug 17537: Fix valid-templates.t for some include files 3 include files do not pass the template validation tests: - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc This is because they process a block which has not been declared before. As they are include files, they cannot stand on their own. We could have added them to the exclude file list of xt/author/valid-templates.t but I think it's better to keep them into the validation loop. Test plan: prove xt/author/valid-templates.t should return green And the library dropdown list should be correctly populated on the pages these files are included (opac-topissues for instance) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Jonathan Druart changed: What|Removed |Added Depends on||15803, 15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Claire Gravely changed: What|Removed |Added Attachment #57076|0 |1 is obsolete|| --- Comment #2 from Claire Gravely --- Created attachment 57103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57103&action=edit Bug 17537: Fix valid-templates.t for some include files 3 include files do not pass the template validation tests: - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc This is because they process a block which has not been declared before. As they are include files, they cannot stand on their own. We could have added them to the exclude file list of xt/author/valid-templates.t but I think it's better to keep them into the validation loop. Test plan: prove xt/author/valid-templates.t should return green And the library dropdown list should be correctly populated on the pages these files are included (opac-topissues for instance) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Tomás Cohen Arazi changed: What|Removed |Added Attachment #57103|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 57132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57132&action=edit Bug 17537: Fix valid-templates.t for some include files 3 include files do not pass the template validation tests: - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc This is because they process a block which has not been declared before. As they are include files, they cannot stand on their own. We could have added them to the exclude file list of xt/author/valid-templates.t but I think it's better to keep them into the validation loop. Test plan: prove xt/author/valid-templates.t should return green And the library dropdown list should be correctly populated on the pages these files are included (opac-topissues for instance) Signed-off-by: Claire Gravely Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||k...@bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Bug 17537 depends on bug 15758, which changed state. Bug 15758 Summary: Move the C4::Branch related code to Koha::Libraries - part 4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com Status|Pushed to Master|Pushed to Stable --- Comment #5 from Mason James --- blocked by enhancement, passing for 16.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 Mason James changed: What|Removed |Added Status|Pushed to Stable|Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537 --- Comment #6 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
