[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 --- Comment #1 from Petter Goksøyr Åsen --- Created attachment 57726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57726&action=edit remove unused variables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Petter Goksøyr Åsen changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #2 from Josef Moravec --- Please, provide a test plan (even if it's some brief and obvious) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 --- Comment #3 from Petter Goksøyr Åsen --- Test plan: Visually verify that the removed variables are not referred to in the the current scope (sub). Variables with identical names might be used in other subroutines in the file, so grepping for them will give you some false positives. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Alex Buckley changed: What|Removed |Added Attachment #57726|0 |1 is obsolete|| --- Comment #4 from Alex Buckley --- Created attachment 57850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57850&action=edit remove unused variables https://bugs.koha-community.org/show_bug.cgi?id=17671 Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- (In reply to Petter Goksøyr Åsen from comment #3) > Test plan: > Visually verify that the removed variables are not referred to in the the > current scope (sub). Reading the code is not a test plan, sir. Check if adding a reserve still works, would be. But obviously, I will pass QA on these trivial changes. No problem. Koha::Old::Hold->new is hilarious btw. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What|Removed |Added Attachment #57850|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 57883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57883&action=edit Bug 17671: Remove unused variables in C4::Reserves I was reading through Reserves.pm trying to figure out a bug - found some unused variables instead. Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 --- Comment #7 from Marcel de Rooy --- Petter, Please add "Bug [number]:" as prefix on the first line of your commit message. And add a commit message :) Also fill the Assignee on Bugzilla please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |boutrosboutrosboutros@gmail |ity.org |.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 --- Comment #8 from Petter Goksøyr Åsen --- > Reading the code is not a test plan, sir. > Check if adding a reserve still works, would be. Apologies! You're right of course. > Please add "Bug [number]:" as prefix on the first line of your commit message. > And add a commit message :) > Also fill the Assignee on Bugzilla please. Apologies again, I will make sure to do this next time:) Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Petter! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #10 from Katrin Fischer --- Decided against backporting this to stable - not a bug fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
