[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #39 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #38 from Fridolin Somers --- I made some checkouts before running unit tests and they failed. I added a follow-up to fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #37 from Fridolin Somers --- Created attachment 132201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132201=edit Bug 17748: (follow-up) Stronger unit tests Before this patch, unit tests perform an item search assuming there is no checked-out items in database. This is correct for a fresh reseted database. But if you checkout any item then prove t/db_dependent/Items.t it will fail. We can see in this file that other tests use filter on generated branchcode. This patch adds filter to items.homebranch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #36 from Fridolin Somers --- Looks perfect. Great thanks to sponsor and contributors ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added Attachment #131051|0 |1 is obsolete|| --- Comment #35 from Jonathan Druart --- Created attachment 132016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132016=edit Bug 17748: (follow-up) Fix date due column filter After items search result when entering a term in date due colum filter table is not filtered. Its is because columns from 'Issue' must be added in _SearchItems_build_where_fragment() like it has been added in SearchItems(). Test plan : 1) Perform an item search with some results beeing checked-out 2) In colum 'Date due' enter a number that is contained is some due dates, ie '2022' 3) Table results are filtered with items having search term in due date Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #34 from Fridolin Somers --- I've added a small fix for column filter. I'd like for QA to validate it. In my opinion, "Availability" should be placed under "Last checkout date". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #33 from Fridolin Somers --- Created attachment 131051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131051=edit Bug 17748: (follow-up) Fix date due column filter After items search result when entering a term in date due colum filter table is not filtered. Its is because columns from 'Issue' must be added in _SearchItems_build_where_fragment() like it has been added in SearchItems(). Test plan : 1) Perform an item search with some results beeing checked-out 2) In colum 'Date due' enter a number that is contained is some due dates, ie '2022' 3) Table results are filtered with items having search term in due date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #32 from Jonathan Druart --- Created attachment 130849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130849=edit Bug 17748: Remove unecessary html filter Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #31 from Jonathan Druart --- Created attachment 130848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130848=edit Bug 17748: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #30 from Jonathan Druart --- Created attachment 130847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130847=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. Signed-off-by: Christian Stelzenmüller Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #29 from Jonathan Druart --- Created attachment 130846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130846=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. Signed-off-by: Christian Stelzenmüller Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added Attachment #129623|0 |1 is obsolete|| Attachment #129624|0 |1 is obsolete|| Attachment #129625|0 |1 is obsolete|| Attachment #130154|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 130845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130845=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out or not). If checked out, shows due date in item search results. The due date column will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up two items. Check out Item A to a borrower. Leave Item B as is not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, and Checked out. 4) Leave the Ignore option selected and do a search so that both items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Item B). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #27 from Aleisha Amohia --- Created attachment 130154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130154=edit Bug 17748: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #26 from Jonathan Druart --- Tests are missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #25 from Katrin Fischer --- Added Christian's surname to the sign-off lines, patches still apply cleanly against master. Thx Aleisha for noticing the missed status change! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What|Removed |Added Attachment #128647|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 129625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129625=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What|Removed |Added Attachment #128646|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 129624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129624=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What|Removed |Added Attachment #128645|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 129623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129623=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out or not). If checked out, shows due date in item search results. The due date column will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up two items. Check out Item A to a borrower. Leave Item B as is not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, and Checked out. 4) Leave the Ignore option selected and do a search so that both items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Item B). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the release notes|availability of an item to |due date of an item to the |the item search results |item search results. The |(i.e. shows if checked out, |due date column will also |available on the shelf, or |show when exporting results |not available for checkout |to a CSV file. |for some other reason). If | |checked out, also shows due | |date in item search | |results. Both the new | |availability and due date | |columns will also show when | |exporting results to a CSV | |file. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What|Removed |Added Summary|Show due date and |Show due date in item |availability in item search |search results |results | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
