[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Skipping QA, too much time spent on these tests already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Jonathan Druart changed: What|Removed |Added Attachment #58117|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 58119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58119&action=edit Bug 17759: Remove invalid guarantorid's in Members.t See also bug 17733. As long as we have no FK, these invalid guarantorid's can make tests fail. Adding a sql statement to clear them in the beginning of the test. Test plan: [1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests, we should manipulate one or two borrowers: Run this SQL query first: SELECT `AUTO_INCREMENT` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = '[your database]' and table_name='borrowers'; Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE borrowernumber=[some existing borrowernumber] [2] Without this patch, run Members.t. Should fail two tests. [3] Apply the patch. Fetch the new AUTO_INCREMENT value and update guarantorid accordingly again for the manipulated borrower. [4] Run the test. It should not fail. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Marcel de Rooy changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 --- Comment #1 from Marcel de Rooy --- Created attachment 58117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58117&action=edit Bug 17759: Remove invalid guarantorid's in Members.t See also bug 17733. As long as we have no FK, these invalid guarantorid's can make tests fail. Adding a sql statement to clear them in the beginning of the test. Test plan: [1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests, we should manipulate one or two borrowers: Run this SQL query first: SELECT `AUTO_INCREMENT` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = '[your database]' and table_name='borrowers'; Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE borrowernumber=[some existing borrowernumber] [2] Without this patch, run Members.t. Should fail two tests. [3] Apply the patch. Fetch the new AUTO_INCREMENT value and update guarantorid accordingly again for the manipulated borrower. [4] Run the test. It should not fail. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17759] Fixing theoretical problems with guarantorid in Members.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 Marcel de Rooy changed: What|Removed |Added Depends on||17733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 [Bug 17733] Members.t is still failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/