[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED

--- Comment #10 from Nick Clemens  ---
Fixed by bug 19575 commit 6d53910f0ca05ae41b0d10ce6f3eb274efd3aca4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
 CC||josef.mora...@gmail.com

--- Comment #9 from Josef Moravec  ---
Hi Nick, nice enhancement, but the test does not cover the change - it passes
with and without the second patch.

I am attaching rebased patches, as there were some minor conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Josef Moravec  changed:

   What|Removed |Added

  Attachment #75564|0   |1
is obsolete||
  Attachment #75565|0   |1
is obsolete||

--- Comment #7 from Josef Moravec  ---
Created attachment 85891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85891=edit
Bug 18163: Unit tests

prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

--- Comment #8 from Josef Moravec  ---
Created attachment 85892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85892=edit
Bug 18163: Pass through limits in ES

Before these patches we only allow a small subset of indexes to be used
as limits - if we are going to let users add new fields eventually we
probably don't want to strip out terms we didn't plan for.

To test:
1 - Enable ES
2 - Using sample kohadevbox data try a search like this (or adjust as
necessary):
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw=kw=kw=subject%2Cphr%3Astreet_by=relevance=Search
3 - Note nothing is found
4 - Apply patches
5 - Repeat search
6 - It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

--- Comment #6 from Cab Vinton  ---
Unable to replicate in Biblibre sandboxes 11 (this patch) & 12 (master), w/
database 2 (UNIMARC).

Tried searching by subject and subject phrase, & both with and without an item
type limit:
opac-search.pl?idx=su%2Cphr=rugby=and=kw==and=kw==Search=mc-itype%2Cphr%3ALIVR

Search returned the same 2 results in both sandboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

--- Comment #5 from Nick Clemens  ---
Created attachment 75565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75565=edit
Bug 18163: Pass through limits in ES

Before these patches we only allow a small subset of indexes to be used
as limits - if we are going to let users add new fields eventually we
probably don't want to strip out terms we didn't plan for.

To test:
1 - Enable ES
2 - Using sample kohadevbox data try a search like this (or adjust as
necessary):
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw=kw=kw=subject%2Cphr%3Astreet_by=relevance=Search
3 - Note nothing is found
4 - Apply patches
5 - Repeat search
6 - It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

--- Comment #4 from Nick Clemens  ---
Created attachment 75564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75564=edit
Bug 18163: Unit tests

prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
  Component|Searching   |Searching - Elasticsearch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Jonathan Druart  changed:

   What|Removed |Added

Version|16.11   |unspecified
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||12478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

--- Comment #3 from Pedro Amorim  ---
The reason the search is throwing the warning:
"item-level_itypes set but no itemtype set for item (ID) at
/usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698. " is because the
items.itype are indeed NULL (no info at the time of import). And the reason the
search is working is because it falls back to the biblioitems.itemtype after
throwing the error:
https://github.com/Koha-Community/Koha/blob/4f178fad53fb748bd1ccf67680e02411918c9584/Koha/Schema/Result/Item.pm#L700

With all that, the bug remains, the advanced search by item type will return no
results because it's searching as "itemtype, phr". "itemtype" alone will return
the results correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163

Pedro Amorim  changed:

   What|Removed |Added

Summary|Elasticsearch unimarc   |Elasticsearch advanced
   |advanced search by item |search by item type not
   |type not working|working with
   ||item-level_itypes turned
   ||off (biblio record)

--- Comment #2 from Pedro Amorim  ---
Turns out the the difference between itype and itemtype is related to the
item-level_itypes preference, which i had it set to biblio record instead of
item.

I changed the preference back to item-level and now the search is working.
However, upon indexing, the following message is thrown:
"item-level_itypes set but no itemtype set for item (ID) at
/usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698. "
Which is confusing because the item type info is in biblioitems.itemtype for
the items and also the search is apparently working fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/