[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Fridolin SOMERSchanged: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Marcel de Rooychanged: What|Removed |Added Attachment #65041|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 65043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65043=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Marcel de Rooychanged: What|Removed |Added Attachment #65042|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 65044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65044=edit Bug 18259: [QA Follow-up] Replace variable name The variable name has_subscriptions implies that it is a boolean. In reality we save the number of subscriptions into it. Renaming has_ to cnt_. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Marcel de Rooychanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Marcel de Rooychanged: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Marcel de Rooychanged: What|Removed |Added Attachment #64826|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 65041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65041=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 --- Comment #5 from Marcel de Rooy--- Created attachment 65042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65042=edit Bug 18259: [QA Follow-up] Replace variable name The variable name has_subscriptions implies that it is a boolean. In reality we save the number of subscriptions into it. Renaming has_ to cnt_. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Attachment #63889|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 64826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64826=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Marcel de Rooychanged: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Josef Moravecchanged: What|Removed |Added Attachment #61051|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 63889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63889=edit [SIGNED-OFF] Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Josef Moravecchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Bug 18259 depends on bug 18258, which changed state. Bug 18258 Summary: Add the Koha::Biblio->subscriptions method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Bug 18259 depends on bug 18256, which changed state. Bug 18256 Summary: Koha::Biblio - Remove GetItemsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 --- Comment #1 from Jonathan Druart--- Created attachment 61051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61051=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Depends on||18256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18256 [Bug 18256] Koha::Biblio - Remove GetItemsCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Depends on||18258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18258 [Bug 18258] Add the Koha::Biblio->subscriptions method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druartchanged: What|Removed |Added Blocks||17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/