[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #20 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #19 from Jonathan Druart  
---
I have removed the '+' icon, but it did not exist prior to these patches
anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #18 from Jonathan Druart  
---
Created attachment 74535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74535=edit
Bug 18327: Style 'Multi receiving' button like others

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org
 Status|Signed Off  |Passed QA

--- Comment #17 from Katrin Fischer  ---
Owen, could you take a look maybe at the GUI bits here for some of your magic?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74457|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 74516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74516=edit
Bug 18327: Set label width to 50% in modal

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74390|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 74513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74513=edit
Bug 18327: Add the ability to set the received date to today on multi receiving
serials

When receiving several issues for a subscription (Serials > Serial
collection > Multi receiving), the reception date is always identical to the
publication date.
In some use cases we would like to set this "date received" value to
today.
Note: "date received" refers to the DB column serial.planneddate

To make this possible this patch replaces the JS prompt with a modal
dialog asking for
 1. the number of issues to receive
 2. if the received date must be set to today

Ergonomic note: bootstrap styled buttons are used, but they do not display
correctly
We may need to improve that (later)

Test plan:
- Receive 1 or more serials using the "Multi receiving" buttons
Note that this button appears twice, on the "serial collection
information" and the "serial edition" pages
- Try with and without the new checkbox ticked and confirm the behaviour
is correct (i.e. date received is set to today or set to the publish
date)
- Make sure "Edit serials" and "Generate next" buttons still work as
before

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74456|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 74515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74515=edit
Bug 18327: Rename submit button with 'OK'

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74391|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 74514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74514=edit
Bug 18327: Same change for serials-edit

And use an include file to avoid copy/paste

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #12 from Katrin Fischer  ---
Hm, I will leave it up to you with the follow ups. I am not sure about the
pop-up either, maybe Owen will be able to take a look. Functionally it works
well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #11 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #7)
> 3) Can we shorten the input field for entering the number of items and give
> the text labels more space? Text is already crowded on multiple lines and it
> will get worse with translations to verbose language like German. :)

I have extended the label, it looks better to me as it.
What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #10 from Jonathan Druart  
---
Created attachment 74457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74457=edit
Bug 18327: Set label width to 50% in modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #9 from Jonathan Druart  
---
Created attachment 74456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74456=edit
Bug 18327: Rename submit button with 'OK'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #8 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #7)
> Only some cosmetics:
> 
> 1) With the patch the buttons on the serials collection and serial edit
> pages are no longer aligned and look very different. Can we fix this?

It's in the commit message, I do not know how to do.
I will need Owen's help.

> 2) In the pop-up the submit button is labelled "Multi receiving". I think OK
> would be better and more consistent with other views (also translations).
> 
> 3) Can we shorten the input field for entering the number of items and give
> the text labels more space? Text is already crowded on multiple lines and it
> will get worse with translations to verbose language like German. :)

follow-up is coming later today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #7 from Katrin Fischer  ---
Only some cosmetics:

1) With the patch the buttons on the serials collection and serial edit pages
are no longer aligned and look very different. Can we fix this?

2) In the pop-up the submit button is labelled "Multi receiving". I think OK
would be better and more consistent with other views (also translations).

3) Can we shorten the input field for entering the number of items and give the
text labels more space? Text is already crowded on multiple lines and it will
get worse with translations to verbose language like German. :)

Works well. Setting to failed to get some attention :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #6 from Séverine Queune  ---
The use of checkbox works as expected.
Behaviours of others buttons are the same as before.

I messed bug 18237 when I first this one, I confused myself between numbers...
I hope it won't cause touble.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74376|0   |1
is obsolete||

--- Comment #5 from Séverine Queune  ---
Created attachment 74391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74391=edit
Bug 18327: Same change for serials-edit

And use an include file to avoid copy/paste

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74375|0   |1
is obsolete||

--- Comment #4 from Séverine Queune  ---
Created attachment 74390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74390=edit
Bug 18327: Add the ability to set the received date to today on multi receiving
serials

When receiving several issues for a subscription (Serials > Serial
collection > Multi receiving), the reception date is always identical to the
publication date.
In some use cases we would like to set this "date received" value to
today.
Note: "date received" refers to the DB column serial.planneddate

To make this possible this patch replaces the JS prompt with a modal
dialog asking for
 1. the number of issues to receive
 2. if the received date must be set to today

Ergonomic note: bootstrap styled buttons are used, but they do not display
correctly
We may need to improve that (later)

Test plan:
- Receive 1 or more serials using the "Multi receiving" buttons
Note that this button appears twice, on the "serial collection
information" and the "serial edition" pages
- Try with and without the new checkbox ticked and confirm the behaviour
is correct (i.e. date received is set to today or set to the publish
date)
- Make sure "Edit serials" and "Generate next" buttons still work as
before

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Reception date when |Add the ability to set the
   |receiving multiple issues   |received date to today on
   |for a subscription is not   |multi receiving serials
   |the good one|
  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/