[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Pedro Amorim changed: What|Removed |Added Blocks||35073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35073 [Bug 35073] Serials batch edit deletes unchanged additional fields data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Blocks||22621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 [Bug 22621] Filters on subscription result list search the wrong column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Fridolin SOMERS changed: What|Removed |Added Blocks||21554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21554 [Bug 21554] Using Subscription Batch Edit produces Software Error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Bug 18426 depends on bug 20599, which changed state. Bug 20599 Summary: Add the Koha::Subscription->vendor method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Attachment #74393|0 |1 is obsolete|| --- Comment #30 from Katrin Fischer --- Created attachment 74676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74676&action=edit Bug 18426: Refactor subscriptions tables code in a BLOCK Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Attachment #74536|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 74680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74680&action=edit Bug 18426: Make sure the logged in user can edit the subscriptions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Attachment #74394|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 74677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74677&action=edit Bug 18426: Allow to edit subscriptions in batch This adds a checkbox column in serials-search.pl tables that allow to edit selected subscriptions. The following fields can be modified: - Bookseller - Location - Library - Item type - Public note - Nonpublic note - "Create item when receiving" flag - Expiration date + the additional fields defined in serials/add_fields.pl Test plan: 1. Go to Serials module 2. If there is no additional fields defined, define some (at least one with an authorized value and one without) 3. Start a subscription search 4. Select some results using the checkboxes and click the "Edit" button above the table 5. Select values for some fields (not all) and click "Start batch edit" 6. Verify you are being redirected to the previous search results 7. Verify that the fields for which you selected a value were modified and that the others fields weren't 8. Repeat steps 4 to 7 but this time, modify the other fields. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Attachment #74395|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer --- Created attachment 74678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74678&action=edit Bug 18426: Fix datepicker Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Attachment #74537|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 74681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74681&action=edit Bug 18426: Replace 'Modify' with 'Edit' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Attachment #74458|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 74679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74679&action=edit Bug 18426: Address QA issues - Replaced with the "action" links we already have on the biblio detail page and the items lost report. - Display all the editable values in the table - Add a 'Cancel' link Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #29 from Jonathan Druart --- (In reply to Katrin Fischer from comment #28) > Something is not quite right yet. Testing with a staff patron that has all > serial permissions but 'edit subscription'. I don't see the links, but I > still have the checkboxes that now have no function. You should remove superserials I guess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Something is not quite right yet. Testing with a staff patron that has all serial permissions but 'edit subscription'. I don't see the links, but I still have the checkboxes that now have no function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #27 from Jonathan Druart --- Indeed Katrin, thanks for catching the permission issue! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #26 from Jonathan Druart --- Created attachment 74537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74537&action=edit Bug 18426: Replace 'Modify' with 'Edit' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #25 from Jonathan Druart --- Created attachment 74536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74536&action=edit Bug 18426: Make sure the logged in user can edit the subscriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- Hi Jonathan, 2 things: 1) We have a permission for editing existing subscriptions: edit_subscription Edit an existing subscription I think we should hide everything related to the batch edit in the GUI, if users don't have this permission (checkboxes and links on top). 2) I'd use "Edit" instead of "Modify" to match with other patches/terminology in Koha. Otherwise this works really well, would be good to see it make it over the finish line! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #23 from Séverine Queune --- (In reply to Jonathan Druart from comment #22) > (In reply to Séverine Queune from comment #20) > > > Some values are not displayed in the table : > > - item type > > - additional subscription fields > > I have added item type in the last version of the patch. > I consider the additional subscription fields out of my scope. > Ok for me for item type ! Let' open a new ticket for additionnal subscription fields :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #22 from Jonathan Druart --- (In reply to Séverine Queune from comment #20) > Some values are not displayed in the table : > - item type > - additional subscription fields I have added item type in the last version of the patch. I consider the additional subscription fields out of my scope. > > > 5 - Maybe 'Save' instead of 'Start batch edit'? > > > > Done > > > Button is still 'Start batch edit'. I agree with a 'Save' button, that what > we have on the 'Item batch modification'. Indeed, done now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Attachment #74396|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 74458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74458&action=edit Bug 18426: Address QA issues - Replaced with the "action" links we already have on the biblio detail page and the items lost report. - Display all the editable values in the table - Add a 'Cancel' link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #20 from Séverine Queune --- I just test it. It works very well for all kind of fields. I also have a few comments. (In reply to Jonathan Druart from comment #19) > > (In reply to Nick Clemens from comment #8) > > 2 - On the edit page we should display all editable values - when the > > dropdown is 'No change' I cannot know what the original value was for things > > like 'Create items when receiving > > Done. > Some values are not displayed in the table : - item type - additional subscription fields > > 5 - Maybe 'Save' instead of 'Start batch edit'? > > Done > Button is still 'Start batch edit'. I agree with a 'Save' button, that what we have on the 'Item batch modification'. > (In reply to Katrin Fischer from comment #13) > > 3) It would be nice to have a checkbox like on the batch item edit in order > > to allow emptying the note fields. At the moment you'd have to add a space > > or something to clear them out. > > We had lot of issue about that, I'd avoid to add it now. > Agree with Katrin, could be great to have this enhancement later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Depends on||20599 Keywords|Academy | --- Comment #19 from Jonathan Druart --- Trying to unstuck this one. (In reply to Nick Clemens from comment #8) > 1 - The edit button is inconsistent, it should be a link as the others, and > I would suggest 'Edit selected serials' Replaced with the "action" links we already have on the biblio detail page and the items lost report. > 2 - On the edit page we should display all editable values - when the > dropdown is 'No change' I cannot know what the original value was for things > like 'Create items when receiving Done. > 3 - We should have a 'Cancel' button if we choose not to edit the subs Done. > 4 - It might be nice to be able to select/deselect subs before applying the > edits - not a blocker but saves from going back a page on wrong click TODO later I'd say > 5 - Maybe 'Save' instead of 'Start batch edit'? Done (In reply to Katrin Fischer from comment #13) > 1) Agree with Nick: "Edit" button would be nicer as a link, matching other > pages like the details page. So, done. > 2) If you select no subscriptions and click on edit, there should be a > warning. Or it should be inactive until you have selected some. No longer valid. > 3) It would be nice to have a checkbox like on the batch item edit in order > to allow emptying the note fields. At the moment you'd have to add a space > or something to clear them out. We had lot of issue about that, I'd avoid to add it now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599 [Bug 20599] Add the Koha::Subscription->vendor method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Attachment #62119|0 |1 is obsolete|| Attachment #64198|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 74393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74393&action=edit Bug 18426: Refactor subscriptions tables code in a BLOCK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #18 from Jonathan Druart --- Created attachment 74396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74396&action=edit Bug 18426: Address QA issues - Replaced with the "action" links we already have on the biblio detail page and the items lost report. - Display all the editable values in the table - Add a 'Cancel' link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #16 from Jonathan Druart --- Created attachment 74394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74394&action=edit Bug 18426: Allow to edit subscriptions in batch This adds a checkbox column in serials-search.pl tables that allow to edit selected subscriptions. The following fields can be modified: - Bookseller - Location - Library - Item type - Public note - Nonpublic note - "Create item when receiving" flag - Expiration date + the additional fields defined in serials/add_fields.pl Test plan: 1. Go to Serials module 2. If there is no additional fields defined, define some (at least one with an authorized value and one without) 3. Start a subscription search 4. Select some results using the checkboxes and click the "Edit" button above the table 5. Select values for some fields (not all) and click "Start batch edit" 6. Verify you are being redirected to the previous search results 7. Verify that the fields for which you selected a value were modified and that the others fields weren't 8. Repeat steps 4 to 7 but this time, modify the other fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #17 from Jonathan Druart --- Created attachment 74395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74395&action=edit Bug 18426: Fix datepicker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #14 from Séverine Queune --- Hi everyone ! I'm interested to work on this one during next hackfest. If no solution can be found during the next week, the BULAC would like to sponsor this development. Thanks to all of you ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #13 from Katrin Fischer --- Hi Julian, I really like it! The problem I previously had disappeared :) Some notes: 1) Agree with Nick: "Edit" button would be nicer as a link, matching other pages like the details page. 2) If you select no subscriptions and click on edit, there should be a warning. Or it should be inactive until you have selected some. 3) It would be nice to have a checkbox like on the batch item edit in order to allow emptying the note fields. At the moment you'd have to add a space or something to clear them out. 4) Agree with Nick: A cancel link would be consistent with other pages and features. 5) Agree with Nick: Maybe 'Save' instead of 'Start batch edit'? 6) Agree with Nick: It might be nice to be able to select/deselect subs before applying the edits - not a blocker but saves from going back a page on wrong click Don't understand that one: >is 'No change' I cannot know what the original value was for things like >'Create items when receiving Nick, can you explain? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #12 from Caroline Cyr La Rose --- Katrin, I wasn't sure if I should, since you also seemed to have problems testing it. I think it should be tested again by someone else before being signed off. Maybe put it back to needs signoff? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #11 from Katrin Fischer --- Caroline, did you intend to mark this signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #10 from Caroline Cyr La Rose --- Nick, I did not do any of those things and I don't know what they mean. I'm not that technical... Sorry! BUT I just did a git pull and I had to reinstall Koha for the latest version. It asked to install dependencies, so I guess that's done... I retested and IT WORKS! And it's really neat! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Hi Julian, didn't get far in testing, because even after running dbic and restart_all I still get an internal server error, when I try to 'edit': Template process failed: undef error - The method biblio is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Template process failed: undef error - The method biblio is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. The subscription search seems to work nicely, agreeing about Nick's 1: 1 - The edit button is inconsistent, it should be a link as the others, and I would suggest 'Edit selected serials' - Agreed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- Caroline, Did you apply dependencies and restart services and regenerate schema? All seems to work for me. Julian, I like this feature a lot, a few comments: 1 - The edit button is inconsistent, it should be a link as the others, and I would suggest 'Edit selected serials' 2 - On the edit page we should display all editable values - when the dropdown is 'No change' I cannot know what the original value was for things like 'Create items when receiving 3 - We should have a 'Cancel' button if we choose not to edit the subs 4 - It might be nice to be able to select/deselect subs before applying the edits - not a blocker but saves from going back a page on wrong click 5 - Maybe 'Save' instead of 'Start batch edit'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs Signoff |Failed QA --- Comment #7 from Caroline Cyr La Rose --- Hi, I applied the patch and was able to get the check boxes, but when I click "Edit", I get a software error. Template process failed: undef error - The method biblio is not covered by tests! at /inlibro/git/koha-master-dev-inlibro/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Paul Poulain changed: What|Removed |Added Keywords||Academy CC||paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Julian Maurice changed: What|Removed |Added Depends on||18785 Status|ASSIGNED|Needs Signoff --- Comment #6 from Julian Maurice --- (In reply to Jonathan Druart from comment #4) > Please move Koha::Subscription->biblio to its own bug report and provide > tests. Moved into bug 18785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 [Bug 18785] Add Koha::Subscription::biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Julian Maurice changed: What|Removed |Added Attachment #62120|0 |1 is obsolete|| --- Comment #5 from Julian Maurice --- Created attachment 64198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64198&action=edit Bug 18426: Allow to edit subscriptions in batch This adds a checkbox column in serials-search.pl tables that allow to edit selected subscriptions. The following fields can be modified: - Bookseller - Location - Library - Item type - Public note - Nonpublic note - "Create item when receiving" flag - Expiration date + the additional fields defined in serials/add_fields.pl Test plan: 1. Go to Serials module 2. If there is no additional fields defined, define some (at least one with an authorized value and one without) 3. Start a subscription search 4. Select some results using the checkboxes and click the "Edit" button above the table 5. Select values for some fields (not all) and click "Start batch edit" 6. Verify you are being redirected to the previous search results 7. Verify that the fields for which you selected a value were modified and that the others fields weren't 8. Repeat steps 4 to 7 but this time, modify the other fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Julian Maurice changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Julian Maurice changed: What|Removed |Added Blocks||18784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 [Bug 18784] Add 'auto claim' option to subscription batch edit tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Please move Koha::Subscription->biblio to its own bug report and provide tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 delaye changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||stephane.del...@biblibre.co ||m --- Comment #3 from delaye --- test in the sandbox 1 of biblibre with the test plan . It works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #2 from Julian Maurice --- Created attachment 62120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62120&action=edit Bug 18426: Allow to edit subscriptions in batch This adds a checkbox column in serials-search.pl tables that allow to edit selected subscriptions. The following fields can be modified: - Bookseller - Location - Library - Item type - Public note - Nonpublic note - "Create item when receiving" flag - Expiration date + the additional fields defined in serials/add_fields.pl Test plan: 1. Go to Serials module 2. If there is no additional fields defined, define some (at least one with an authorized value and one without) 3. Start a subscription search 4. Select some results using the checkboxes and click the "Edit" button above the table 5. Select values for some fields (not all) and click "Start batch edit" 6. Verify you are being redirected to the previous search results 7. Verify that the fields for which you selected a value were modified and that the others fields weren't 8. Repeat steps 4 to 7 but this time, modify the other fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 --- Comment #1 from Julian Maurice --- Created attachment 62119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62119&action=edit Bug 18426: Refactor subscriptions tables code in a BLOCK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
