[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Jonathan Druart  changed:

   What|Removed |Added

  Component|Searching   |Searching - Elasticsearch
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Stable|RESOLVED

--- Comment #31 from Katrin Fischer  ---
Doesn't apply cleanly, possibly because of other Elasticsearch related patches
missing in 16.11.x. Please get in touch with me if you want to have this
included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #30 from Fridolin SOMERS  ---
Pushed to 17.05.x, will be in 17.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #29 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #28 from Tomás Cohen Arazi  ---
*** Bug 18610 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #27 from Tomás Cohen Arazi  ---
The last two patches for this one overlap with my patches for bug 18610, this
ones are
ok and i'm closing the other as duplicate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #64773|0   |1
is obsolete||

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 64790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64790=edit
Bug 18434 - Followup fix tests for sorting and factes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63478|0   |1
is obsolete||

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 64787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64787=edit
Bug 18434: Elasticsearch indexing broken with newer catmandu version

To test:
1 - Make sure you have latest koha deps, catmandu versions should be:
libcatmandu-marc-perl   1.09-1~kohadev1
libcatmandu-perl1.0304-2~kohadev1
2 - Reindex elastic
3 - Try searching and likely notice odd results
4 - Try:
curl -XGET
'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
with a known biblionumber and notice some null fields
5 - Apply patch
6 - Reindex
7 - Note fields are populated and search works as expected

Signed-off-by: Chris Cormack 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63479|0   |1
is obsolete||

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 64788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64788=edit
Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63477|0   |1
is obsolete||

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 64786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64786=edit
Bug 18434: Add tests for K:SE:E::get_fixer_rules

This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.

(kidclamp) I added a quick test of _convert_marc_to_json to use the mocking
here
and illuminate what the change does, before the patches this should
fail (fields are indexed in place of one another), after it should succeed (new
indexed fields are appended).

A minor bug is highlighted by this new tests, I'll provide a followup for it.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ de kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #64386|0   |1
is obsolete||

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 64789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64789=edit
Bug 18434 - Followup - same changes for sort and facet fields

To test:
1 - Index some stuff with multiple fields defined for sorting
  i.e. Authorites - make heading sortable - default is 110a and 111a for
  heading - a record with 111a empty will make the sort field empty
2 - view the record:
curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true
3 - Note the blank field
4 - Apply patch
5 - Reindex
6 - Fields should be correctly populated

Unit tests to follow (once I have the originals working for all)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #21 from Nick Clemens  ---
Created attachment 64773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64773=edit
Bug 18434 - Followup fix tests for sorting and factes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #20 from Nick Clemens  ---
(In reply to Nick Clemens from comment #19)
> I am looking here, it seems we have some version issues - I sent an email to
> Mirko and going to talk about versions/packagin to see what we can do

I tested on a new kohadevbox - pulling Mirko's packaged versions everything
seems to work for me now:

sudo apt-get install koha-elasticsearch 


||/ Name  Version
ArchitectureDescription
+++-=-===-===-===
ii  libcatmandu-marc-perl 1.09-1~kohadev1
all Catmandu modules for working with MARC data
ii  libcatmandu-perl  1.0304-2~kohadev1  
all metadata toolkit
ii  libcatmandu-store-elasticsearch-perl  0.0507-1~kohadev1  
all searchable store backed by Elasticsearch

It must be another module somewhere causing the extra level in your conversion
- can you test with a new clean devbox and see if the error persists?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #19 from Nick Clemens  ---
I am looking here, it seems we have some version issues - I sent an email to
Mirko and going to talk about versions/packagin to see what we can do

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #18 from Jonathan Druart  
---
{
author   [
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__facet[
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__sort [
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__suggestion   {
input   [
[0] "Author",
[1] "Corp Author"
]
},
es_idundef,
record   [ 
   
   [21/108]
[0] [
[0] "LDR",
[1] undef,
[2] undef,
[3] "_",
[4] ""
],
[1] [
[0] 001,
[1] undef,
[2] undef,
[3] "_",
[4] 1234567
],
[2] [
[0] 020,
[1] " ",
[2] " ",
[3] "a",
[4] 1234567890123
],
[3] [
[0] 100,
[1] " ",
[2] " ",
[3] "a",
[4] "Author"
],
[4] [
[0] 110,
[1] " ",
[2] " ",
[3] "a",
[4] "Corp Author"
],
[5] [
[0] 245,
[1] " ",
[2] " ",
[3] "a",
[4] "Title"
]
]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #17 from Nick Clemens  ---
Created attachment 64386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64386=edit
Bug 18434 - Followup - same changes for sort and facet fields

To test:
1 - Index some stuff with multiple fields defined for sorting
  i.e. Authorites - make heading sortable - default is 110a and 111a for
  heading - a record with 111a empty will make the sort field empty
2 - view the record:
curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true
3 - Note the blank field
4 - Apply patch
5 - Reindex
6 - Fields should be correctly populated

Unit tests to follow (once I have the originals working for all)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #16 from Jonathan Druart  
---
Package: libcatmandu-marc-perl
Version: 1.09-1~kohadev1

Package: libcatmandu-perl
Version: 1.0304-2~kohadev1

{
author   [
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__facet[
[0] [
[0] "Author"
],
[1] [
[0] "Corp Author"
]
],
author__sort [
[0] [
[0] "Author"
],
[1] [
[0] "Corp Author"
]
],
author__suggestion   {
input   [
[0] "Author",
[1] "Corp Author"
]
},
es_idundef,
record   [
[0] [
[0] "LDR",
[1] undef,
[2] undef,
[3] "_",
[4] ""
],
[1] [
[0] 001,
[1] undef,
[2] undef,
[3] "_",
[4] 1234567
],
[2] [
[0] 020,
[1] " ",
[2] " ",
[3] "a",
[4] 1234567890123
],
[3] [
[0] 100,
[1] " ",
[2] " ",
[3] "a",
[4] "Author"
],
[4] [
[0] 110,
[1] " ",
[2] " ",
[3] "a",
[4] "Corp Author"
],
[5] [
[0] 245,
[1] " ",
[2] " ",
[3] "a",
[4] "Title"
]
]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #15 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #14)
> 2 Tests fail for me:
> 
Can you post your versions and maybe add a dump of $conv so we can see what the
structure looks like?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
2 Tests fail for me:

t/db_dependent/Koha_Elasticsearch_Indexer.t .. 1/6 
#   Failed test 'First mapped author should be 100a'
#   at t/db_dependent/Koha_Elasticsearch_Indexer.t line 120.
#  got: 'ARRAY(0x67369d8)'
# expected: 'Author'

#   Failed test 'Second mapped author should be 110a'
#   at t/db_dependent/Koha_Elasticsearch_Indexer.t line 121.
#  got: 'ARRAY(0x66f79c0)'
# expected: 'Corp Author'
# Looks like you failed 2 tests of 2.

#   Failed test '_convert_marc_to_json() tests'
#   at t/db_dependent/Koha_Elasticsearch_Indexer.t line 124.
# Looks like you failed 1 test of 6.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610
[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer
Catmandu versions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 63479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63479=edit
Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 63477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63477=edit
Bug 18434: Add tests for K:SE:E::get_fixer_rules

This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.

(kidclamp) I added a quick test of _convert_marc_to_json to use the mocking
here
and illuminate what the change does, before the patches this should
fail (fields are indexed in place of one another), after it should succeed (new
indexed fields are appended).

A minor bug is highlighted by this new tests, I'll provide a followup for it.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ de kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 63478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63478=edit
Bug 18434: Elasticsearch indexing broken with newer catmandu version

To test:
1 - Make sure you have latest koha deps, catmandu versions should be:
libcatmandu-marc-perl   1.09-1~kohadev1
libcatmandu-perl1.0304-2~kohadev1
2 - Reindex elastic
3 - Try searching and likely notice odd results
4 - Try:
curl -XGET
'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
with a known biblionumber and notice some null fields
5 - Apply patch
6 - Reindex
7 - Note fields are populated and search works as expected

Signed-off-by: Chris Cormack 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63452|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63453|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63473|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63451|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 63473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63473=edit
Bug 18434: Add tests for K:SE:E::get_fixer_rules

This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.

(kidclamp) I added a quick test of _convert_marc_to_json to use the mocking
here
and illuminate what the change does, before the patches this should
fail (fields are indexed in place of one another), after it should succeed (new
indexed fields are appended).

A minor bug is highlighted by this new tests, I'll provide a followup for it.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ de kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #9 from Tomás Cohen Arazi  ---
(In reply to Chris Cormack from comment #8)
> Should this be needs signoff, or signed off. Rather than Assigned?

It should be pqa imho, but nick was going to double check the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #8 from Chris Cormack  ---
Should this be needs signoff, or signed off. Rather than Assigned?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #6)
> Created attachment 63453 [details] [review]
> Bug 18434: (followup) Remove unneeded comma in fixer rules
> 
> Signed-off-by: Tomas Cohen Arazi 

I forgot to metion:

To test:
- Run:
  $ prove t/db_dependent/Koha_Elasticsearch.t
=> SUCCESS: All should be green!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #62702|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 63452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63452=edit
Bug 18434: Elasticsearch indexing broken with newer catmandu version

To test:
1 - Make sure you have latest koha deps, catmandu versions should be:
libcatmandu-marc-perl   1.09-1~kohadev1
libcatmandu-perl1.0304-2~kohadev1
2 - Reindex elastic
3 - Try searching and likely notice odd results
4 - Try:
curl -XGET
'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
with a known biblionumber and notice some null fields
5 - Apply patch
6 - Reindex
7 - Note fields are populated and search works as expected

Signed-off-by: Chris Cormack 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 63453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63453=edit
Bug 18434: (followup) Remove unneeded comma in fixer rules

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 63451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63451=edit
Bug 18434: Add tests for K:SE:E::get_fixer_rules

This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.

A minor bug is highlighted by this new tests, I'll provide a followup for it.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ de kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #3 from Jonathan Druart  
---
How could we test this change?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Chris Cormack  changed:

   What|Removed |Added

  Attachment #62171|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 62702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62702=edit
Bug 18434 - Elasticsearch indexing broken with newer catmandu version

To test:
1 - Make sure you have latest koha deps, catmandu versions should be:
libcatmandu-marc-perl   1.09-1~kohadev1
libcatmandu-perl1.0304-2~kohadev1
2 - Reindex elastic
3 - Try searching and likely notice odd results
4 - Try:
curl -XGET
'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
with a known biblionumber and notice some null fields
5 - Apply patch
6 - Reindex
7 - Note fields are populated and search works as expected

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #1 from Nick Clemens  ---
Created attachment 62171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62171=edit
Bug 18434 - Elasticsearch indexing broken with newer catmandu version

To test:
1 - Make sure you have latest koha deps, catmandu versions should be:
libcatmandu-marc-perl   1.09-1~kohadev1
libcatmandu-perl1.0304-2~kohadev1
2 - Reindex elastic
3 - Try searching and likely notice odd results
4 - Try:
curl -XGET
'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
with a known biblionumber and notice some null fields
5 - Apply patch
6 - Reindex
7 - Note fields are populated and search works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/