[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Depends on||17781 Assignee|oleon...@myacpl.org |k...@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 [Bug 17781] Improper branchcode set during renewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 David Kuhn changed: What|Removed |Added CC||techservs...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 --- Comment #1 from Nick Clemens --- Created attachment 64596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64596&action=edit Bug 18572 - Improper branchcode set during OPAC renewal To test: 1 - Set 'OpacRenewalBranch' to various settings 2 - Renew an item for a ptron under each setting 3 - Confirm action_log entries reflect the correct branch for each secnario 4 - prove t/db_dependent/Circulation/issue.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Nick Clemens changed: What|Removed |Added Assignee|k...@bywatersolutions.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 David Kuhn changed: What|Removed |Added Attachment #64596|0 |1 is obsolete|| --- Comment #2 from David Kuhn --- Created attachment 64609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64609&action=edit Bug 18572 - Improper branchcode set during OPAC renewal To test: 1 - Set 'OpacRenewalBranch' to various settings 2 - Renew an item for a ptron under each setting 3 - Confirm action_log entries reflect the correct branch for each secnario 4 - prove t/db_dependent/Circulation/issue.t Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 David Kuhn changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 David Kuhn changed: What|Removed |Added Attachment #64609|0 |1 is obsolete|| --- Comment #3 from David Kuhn --- Created attachment 64610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64610&action=edit Bug 18572 - Improper branchcode set during OPAC renewal To test: 1 - Set 'OpacRenewalBranch' to various settings 2 - Renew an item for a ptron under each setting 3 - Confirm action_log entries reflect the correct branch for each secnario 4 - prove t/db_dependent/Circulation/issue.t Step 3 in the above test should refer to entries in the statistics table as that was where the problem was originally noticed. Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/issue.t line 65. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Marcel de Rooy changed: What|Removed |Added Attachment #64610|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 65048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65048&action=edit Bug 18572 - Improper branchcode set during OPAC renewal To test: 1 - Set 'OpacRenewalBranch' to various settings 2 - Renew an item for a ptron under each setting 3 - Confirm action_log entries reflect the correct branch for each secnario 4 - prove t/db_dependent/Circulation/issue.t Signed-off-by: David Kuhn Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- Why do not you use C4::Context->interface instead of adding a new parameter to this subroutine? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 --- Comment #7 from Jonathan Druart --- Please also double check the indentation in tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 --- Comment #9 from Nick Clemens --- Created attachment 65124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65124&action=edit Bug 18572 - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Nick Clemens changed: What|Removed |Added Attachment #65048|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 65123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65123&action=edit Bug 18572 - Improper branchcode set during OPAC renewal To test: 1 - Set 'OpacRenewalBranch' to various settings 2 - Renew an item for a ptron under each setting 3 - Confirm action_log entries reflect the correct branch for each secnario 4 - prove t/db_dependent/Circulation/issue.t Signed-off-by: David Kuhn Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 --- Comment #10 from Jonathan Druart --- Created attachment 65201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65201&action=edit Bug 18572: Remove AddRenewal parameter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable --- Comment #12 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.02. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #13 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
