[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Bug 18654 depends on bug 18633, which changed state. Bug 18633 Summary: Logs are full of CGI::param called in list context - itemsearch.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #15 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 --- Comment #13 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #12) > Created attachment 67082 [details] [review] > Bug 18654 - Translatability: Get rid of tt directives starting with [%% in > translation for itemsearch.tt - followup Last patch pushed to master, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Fridolin SOMERS changed: What|Removed |Added Attachment #67082|Bug 18654 - |Bug 18654 - description|Translatability: Get rid of |Translatability: Get rid of |tt directives starting with |tt directives starting with |[%% in translation for |[%% in translation for |itemsearch.tt |itemsearch.tt - followup Attachment #67082|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Fridolin SOMERS changed: What|Removed |Added Attachment #66640|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Fridolin SOMERS changed: What|Removed |Added Attachment #67082|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Fridolin SOMERS changed: What|Removed |Added Attachment #66640|0 |1 is obsolete|| --- Comment #12 from Fridolin SOMERS --- Created attachment 67082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67082&action=edit Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Followup correcting a typo of previous patch : name="holdingbranch" options = branche it is branche[s] Test plan : - Look at 'Current location' in item search => Without patch you see only 'All libraries' => With patch you see 'All libraries' and each existing library, like in 'Home library' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #11 from Fridolin SOMERS --- Ah there is a typo in patch : [% INCLUDE form_field_select name="holdingbranch" options = branche Its branche[s]. I create a follow-up patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Jonathan Druart changed: What|Removed |Added Attachment #65407|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 66640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66640&action=edit Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before Followed test plan and verified that tt directives are not split by new lines, the changes to the fieldset tags in comment 3 have been removed and itemtype.tt still works correctly as before Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Alex Buckley changed: What|Removed |Added Attachment #64723|0 |1 is obsolete|| --- Comment #8 from Alex Buckley --- Created attachment 65407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65407&action=edit Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before Followed test plan and verified that tt directives are not split by new lines, the changes to the fieldset tags in comment 3 have been removed and itemtype.tt still works correctly as before Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 --- Comment #7 from Marc Véron --- Still applies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16485 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 --- Comment #6 from Marc Véron --- Created attachment 64723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64723&action=edit Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Attachment #64177|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Depends on||18633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633 [Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
Marc Véron changed:
What|Removed |Added
Attachment #63773|0 |1
is obsolete||
--- Comment #5 from Marc Véron ---
Created attachment 64177
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64177&action=edit
Bug 18654: Translatability: Get rid of tt directives starting with [%% in
translation for itemsearch.tt
Translation for file itemsearch.tt exposes tt directifes like:
%s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%]
%s %s %s %s %s %s %s %s %s %s %s
or
[%% INCLUDE form_field_select name="homebranch" options = branches empty_option
= "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch"
options = branches empty_option = "All libraries" %%] %s [%% INCLUDE
form_field_select name="location" options = locations empty_option = "All
locations" %%] %s
This patch fixes it.
To test:
- Apply patch
- Verify that itemsearch behaves as before
- Verify that code changes make sense
- Test a translatiion e.g. from folder misc/translator:
perl translate create aa-AA
...and verifiy that strings translated from itemsearch.tt and starting with
[%%
no longer appear in aa-AA-staff-prog.po
(Patch re-written, needs a new sign-off)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #4 from Marc Véron --- (In reply to Jonathan Druart from comment #3) > +[% BLOCK fieldset_start %][% END %] > +[% BLOCK fieldset_end %][% END %] > > This is not acceptable, why do you need that? You are right, it is not necessary to replace the fieldset tags. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- +[% BLOCK fieldset_start %][% END %] +[% BLOCK fieldset_end %][% END %] This is not acceptable, why do you need that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
Alex Buckley changed:
What|Removed |Added
Attachment #63643|0 |1
is obsolete||
--- Comment #2 from Alex Buckley ---
Created attachment 63773
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63773&action=edit
Bug 18654: Translatability: Get rid of tt directives starting with [%% in
translation for itemsearch.tt
Translation for file itemsearch.tt exposes tt directifes like:
%s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%]
%s %s %s %s %s %s %s %s %s %s %s
or
[%% INCLUDE form_field_select name="homebranch" options = branches empty_option
= "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch"
options = branches empty_option = "All libraries" %%] %s [%% INCLUDE
form_field_select name="location" options = locations empty_option = "All
locations" %%] %s
This patch fixes it.
To test:
- Apply patch
- Verify that itemsearch behaves as before
- Verify that code changes make sense
- Test a translatiion e.g. translator create aa-AA and
verifiy that strings from itemsearch.tt starting with [%%
no longer appear
Followed test plan and patch worked as intended
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
--- Comment #1 from Marc Véron ---
Created attachment 63643
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63643&action=edit
Bug 18654: Translatability: Get rid of tt directives starting with [%% in
translation for itemsearch.tt
Translation for file itemsearch.tt exposes tt directifes like:
%s %s %s %s %s %s %s %s %s [%% params = { f => f.$i q = q.$i op = op.$i } %%]
%s %s %s %s %s %s %s %s %s %s %s
or
[%% INCLUDE form_field_select name="homebranch" options = branches empty_option
= "All libraries" %%] [%% INCLUDE form_field_select name="holdingbranch"
options = branches empty_option = "All libraries" %%] %s [%% INCLUDE
form_field_select name="location" options = locations empty_option = "All
locations" %%] %s
This patch fixes it.
To test:
- Apply patch
- Verify that itemsearch behaves as before
- Verify that code changes make sense
- Test a translatiion e.g. translator create aa-AA and
verifiy that strings from itemsearch.tt starting with [%%
no longer appear
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives starting with [ %% in translation for itemsearch.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654 Marc Véron changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
