[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Jonathan Druart changed: What|Removed |Added Depends on||7295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 [Bug 7295] list of librarian managing a basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 --- Comment #7 from Nick Clemens --- Created attachment 64589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64589&action=edit Bug 18756 - add Unit Test Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Nick Clemens changed: What|Removed |Added Attachment #64179|0 |1 is obsolete|| Attachment #64403|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 64588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64588&action=edit Bug 18756: Users can view aq.baskets even if they are not allowed Due to bad use of grep syntax if there is one or more Basket Users the result of grep is not equal to 0 and the borrower is allowed. Test plan : 1- select system preference 'AcqViewBaskets' on 'user' 2- create 2 borrowers (A, B) with only permissions on acquisition : group_manage order_manage order_receive staff 3- login with A and create a basket 4- add a basquet manager other than B 5- relog with account B 6- you can see the basket Apply the patch. The basket is no longer visible. 1- relog with A 2- add basquet manager B 3- relog with B 5- you must see the basket Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Lee Jamison changed: What|Removed |Added Attachment #64280|0 |1 is obsolete|| --- Comment #5 from Lee Jamison --- Created attachment 64403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64403&action=edit Bug 18756 - add Unit Test Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 --- Comment #4 from Fridolin SOMERS --- Created attachment 64280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64280&action=edit Bug 18756 - add Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Christophe, please provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Josef Moravec changed: What|Removed |Added Attachment #64103|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 64179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64179&action=edit [SIGNED-OFF] Bug 18756: Users can view aq.baskets even if they are not allowed Due to bad use of grep syntax if there is one or more Basket Users the result of grep is not equal to 0 and the borrower is allowed. Test plan : 1- select system preference 'AcqViewBaskets' on 'user' 2- create 2 borrowers (A, B) with only permissions on acquisition : group_manage order_manage order_receive staff 3- login with A and create a basket 4- add a basquet manager other than B 5- relog with account B 6- you can see the basket Apply the patch. The basket is no longer visible. 1- relog with A 2- add basquet manager B 3- relog with B 5- you must see the basket Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Christophe Croullebois changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Christophe Croullebois changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Christophe Croullebois changed: What|Removed |Added CC||baptiste.wojtkowski@biblibr ||e.com, ||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Christophe Croullebois changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 --- Comment #1 from Christophe Croullebois --- Created attachment 64103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64103&action=edit Bug 18756: Users can view aq.baskets even if they are not allowed Due to bad use of grep syntax if there is one or more Basket Users the result of grep is not equal to 0 and the borrower is allowed. Test plan : 1- select system preference 'AcqViewBaskets' on 'user' 2- create 2 borrowers (A, B) with only permissions on acquisition : group_manage order_manage order_receive staff 3- login with A and create a basket 4- add a basquet manager other than B 5- relog with account B 6- you can see the basket Apply the patch. The basket is no longer visible. 1- relog with A 2- add basquet manager B 3- relog with B 5- you must see the basket -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
