[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Lisette Scheer  changed:

   What|Removed |Added

 Blocks||22872


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22872
[Bug 22872] payment_type handling is untested in Koha::Account->add_credit.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610
[Bug 22610] SIP Payment Types should be moved out of accountype
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

 CC||kohapa...@gmail.com

--- Comment #57 from Martin Renvoize  ---
*** Bug 5620 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||21791
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=21791   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791
[Bug 21791] Add payment type on Cash register report (cash_register_stats.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21791

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #56 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #55)
> Created attachment 75401 [details] [review]
> Bug 18786: Add PAYMENT_TYPE to the installer file

Pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #55 from Jonathan Druart  
---
Created attachment 75401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75401=edit
Bug 18786: Add PAYMENT_TYPE to the installer file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #54 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #53 from Kyle M Hall  ---
Created attachment 74436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74436=edit
Bug 18786: Remove duplicate block with bad IF

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #52 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #51)
> Take a look at the patch, the problem is obvious: the [% IF payment_types %]
> is duplicated. One has a call to ->count, the others not.

Ah, I *still* don't get an error, but that is clearly a duplicate block. I'll
get that taken care of!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #51 from Jonathan Druart  
---
Take a look at the patch, the problem is obvious: the [% IF payment_types %] is
duplicated. One has a call to ->count, the others not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #50 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #49)
> Did you create AVs for PAYMENT_TYPE?

Yes, I tested every payment option with and without PAYMENT_TYPEs. In both
cases the av category itself existed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #49 from Jonathan Druart  
---
Did you create AVs for PAYMENT_TYPE?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #48 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #46)
> Just try to pay a fine.

I am completely unable to reproduce your error. Can you try again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|josef.mora...@gmail.com |testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #47 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #46)
> Just try to pay a fine.

Thanks! Probably due to a recent change to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #46 from Jonathan Druart  
---
Just try to pay a fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #45 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #43)
> Hum, PQA, sure?
> 
> Template process failed: undef error - The method count is not covered by
> tests! at /home/vagrant/kohaclone/C4/Templates.pm line 122.

Why is this failed qa now? From this error? How do you generate it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #44 from Jonathan Druart  
---
Created attachment 74172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74172=edit
Bug 18786: Add PAYMENT_TYPE to the AV categories

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #43 from Jonathan Druart  
---
Hum, PQA, sure?

Template process failed: undef error - The method count is not covered by
tests! at /home/vagrant/kohaclone/C4/Templates.pm line 122.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #42 from Josef Moravec  ---
Created attachment 74149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74149=edit
Bug 18786: Remove use of Koha::Patron::Images

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72114|0   |1
is obsolete||
  Attachment #72115|0   |1
is obsolete||
  Attachment #73628|0   |1
is obsolete||

--- Comment #40 from Josef Moravec  ---
Created attachment 74147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74147=edit
Bug 18786: Update database

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #41 from Josef Moravec  ---
Created attachment 74148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74148=edit
Bug 18786: Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #39 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #38)
> Josef, do you have time to finish here?

Sorry, I missed this somehow, I'll take a look on this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #38 from Katrin Fischer  ---
Josef, do you have time to finish here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #37 from Kyle M Hall  ---
(In reply to Josef Moravec from comment #35)
> Why did you added the cleaning of the code in C4/SIP/ILS.pm? 
> 
> It looks OK, but I think it's not related to this report.

No idea how the snuck in. This new version of the followup should have that
fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72282|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall  ---
Created attachment 73628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73628=edit
Bug 18786: Remove use of Koha::Patron::Images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #35 from Josef Moravec  ---
Why did you added the cleaning of the code in C4/SIP/ILS.pm? 

It looks OK, but I think it's not related to this report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #34 from Kyle M Hall  ---
Created attachment 72282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72282=edit
Bug 18786: Remove use of Koha::Patron::Images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #33 from Katrin Fischer  ---
As the payment types are ok as key value pairs and you wouldn't need more, I
think having them as an authorised value is ok. But we should start to make AV
translatable one by one (or all at once - wouldn't mind that!). It is the next
logical step, especially for values exposed in the OPAC like location and
collection.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #32 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #31)
> Cannot we try to be exhaustive and list all (or at least several to start)
> payment types in a separate table? We could have a FK at DB level and make
> them translatable.

These are not hard coded payment types, they are meant to be added by the
librarians, just as we already use a AV category for librarian defined fee
types.

Really, what we need is for authorised values to be translatable, but that's a
bit outside the scope of this bug ; )

If you would like me to add an example payment type to the sample data, I'd be
happy to do so!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #31 from Jonathan Druart  
---
Cannot we try to be exhaustive and list all (or at least several to start)
payment types in a separate table? We could have a FK at DB level and make them
translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Signed Off

--- Comment #30 from Jonathan Druart  
---
We are going to add yet another AV that cannot be translatable.
Moreover this patch set does not create some default ones for existing or new
installations.

I'd like to get more QA pov on that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #29 from Kyle M Hall  ---
Created attachment 72115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72115=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72015|0   |1
is obsolete||
  Attachment #72016|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 72114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72114=edit
Bug 18786 - Update database

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Claudio  changed:

   What|Removed |Added

 CC||cost...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #27 from Kyle M Hall  ---
Created attachment 72016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72016=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #71020|0   |1
is obsolete||
  Attachment #71021|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall  ---
Created attachment 72015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72015=edit
Bug 18786 - Update database

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #25 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #24)
> What I am not sure about is the relation to the already existing SIP payment
> types - will both work together nicely for reports etc?

Yes they will!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #24 from Katrin Fischer  ---
What I am not sure about is the relation to the already existing SIP payment
types - will both work together nicely for reports etc?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|josef.mora...@gmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12001

--- Comment #23 from Josef Moravec  ---
I agree with you Kyle, better to not have more hardcoded values in Koha...

Passed QA, note for RM: on boraccount.pl, the payment type is not shown now,
but should be fixed by bug 12001 I think, with GetMemberAccountRecords
refactoring

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

  Attachment #69156|0   |1
is obsolete||
  Attachment #69157|0   |1
is obsolete||

--- Comment #21 from Josef Moravec  ---
Created attachment 71020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71020=edit
Bug 18786 - Update database

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #22 from Josef Moravec  ---
Created attachment 71021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71021=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #20 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #19)
> Found it - it was bug 5620!

That bug doesn't do what this one does. That one is specifically about SIP
payment types. Moreover, I see some issues with it since it hardcodes a bunch
of payment type values that aren't specified by the SIP2 protocol : \

If this one gets pushed I'd be willing to assist in fixing up 5620.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #19 from Katrin Fischer  ---
Found it - it was bug 5620!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #18 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #17)
> I think this is a duplicate of the older bug 5630 which is also signed off
> at the moment.

Katrin, which bug did you have in mind? This bug number is not related to
account either.


> There was some discussion about using an authorised value there and because
> we already have a list of payment types used by SIP and translatability some
> hardcoded values were added. Maybe we could make it so that the list can be
> extended by an authorised value? (... and make authorised values
> translatable for display one day...)
> 
> Can we pick one implementation?

+1 ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
I think this is a duplicate of the older bug 5630 which is also signed off at
the moment.

There was some discussion about using an authorised value there and because we
already have a list of payment types used by SIP and translatability some
hardcoded values were added. Maybe we could make it so that the list can be
extended by an authorised value? (... and make authorised values translatable
for display one day...)

Can we pick one implementation?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #16 from Kyle M Hall  ---
Created attachment 69157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69157=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67476|0   |1
is obsolete||
  Attachment #69155|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 69156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69156=edit
Bug 18786 - Update database

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67477|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 69155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69155=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Amit Gupta  changed:

   What|Removed |Added

 CC||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #13 from Kyle M Hall  ---
Created attachment 67477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67477=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64300|0   |1
is obsolete||
  Attachment #64301|0   |1
is obsolete||
  Attachment #64302|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 67476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67476=edit
Bug 18786 - Update database

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #10 from Martha Fuerst  ---
Got the following error when trying to pay a lost item charge, but fine is gone
from the account. No indication of payment on Account page or in
account_offsets table.

Software error:

{UNKNOWN}: Can't call method "unblessed" on an undefined value at
/var/lib/koha/hcpl/kohaclone/C4/Circulation.pm line 2178. at
/var/lib/koha/hcpl/kohaclone/C4/Circulation.pm line 2198
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

Everything else works fine.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types - YES (also appears with all "Pay")
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martha Fuerst  changed:

   What|Removed |Added

 CC||mfue...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Marc Véron  changed:

   What|Removed |Added

  Attachment #64288|0   |1
is obsolete||

--- Comment #9 from Marc Véron  ---
Created attachment 64302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64302=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Marc Véron  changed:

   What|Removed |Added

  Attachment #64202|0   |1
is obsolete||

--- Comment #7 from Marc Véron  ---
Created attachment 64300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64300=edit
Bug 18786 - Update database

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Marc Véron  changed:

   What|Removed |Added

  Attachment #64203|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 64301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64301=edit
Bug 18786 - Update schema

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64204|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 64288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64288=edit
Bug 18786 - Add ability to create custom payment types

Some libraries would like to be able to specify more specific payment types
such as cash, check, credit card, or even canned food ( for food drives ). This
feature will allow a library to specify payment types as authorised values of
the type PAYMENT_TYPE.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #5 from Kyle M Hall  ---
Ack! Thanks for the test plan! I'll get the patch set fixed up asap!

(In reply to Marc Véron from comment #4)
> Test plan was missing.
> 
> I tested with following steps:
> Following test is OK:
> 
> - Apply patches
> - Update database
> - Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit
> card'
> - Go to the fines section of a patron who has several fines
> - Tab 'Fines'
> - Click on 'Pay' for an individual fine
> - Verified that in form  'Pay an individual fine' a dropdown appears with
>   paxment types
> - Selected a payment type, confirm payment
> - Verify that payment type appears in "Description of charges" in tab
> 'Account'
> 
> 
> Following is missing:
> - Go to 'Fines' tab
> - Use 'Pay amount' or 'Pay selected' for payment
> Fail: There is no dropdown list with payment types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---
Test plan was missing.

I tested with following steps:
Following test is OK:

- Apply patches
- Update database
- Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
- Go to the fines section of a patron who has several fines
- Tab 'Fines'
- Click on 'Pay' for an individual fine
- Verified that in form  'Pay an individual fine' a dropdown appears with
  paxment types
- Selected a payment type, confirm payment
- Verify that payment type appears in "Description of charges" in tab 'Account'


Following is missing:
- Go to 'Fines' tab
- Use 'Pay amount' or 'Pay selected' for payment
Fail: There is no dropdown list with payment types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||18790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790
[Bug 18790] Add ability to void payments
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #2 from Kyle M Hall  ---
Created attachment 64203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64203=edit
Bug 18786 - Update schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #3 from Kyle M Hall  ---
Created attachment 64204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64204=edit
Bug 18786 - Add ability to create custom payment types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #1 from Kyle M Hall  ---
Created attachment 64202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64202=edit
Bug 18786 - Update database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/