[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #21 from Johanna Räisä  ---
(In reply to Tomás Cohen Arazi from comment #20)
> Hi Johanna. Nice and clean work!
> 
> A few remarks from the QA POV:
> - Our API design mojo is: 'As RESTful as we can'. In this context, we should
> consider the 'checkout history of a patron' a resource, and as such it feels
> more appropriate to put the patron id on the path, like in:
> 
> DELETE /patrons/{patron_id}/checkouts/history
> 
> Then we can reserve this route you were using for batch anonymizing :-D like
> in
> 
> DELETE /checkouts/history?q=more_complex_query_on_patrons
> 
> - There are some response definitions missing on the spec, (503 for
> maintenance mode, 500 for internal server error, and so on).
> 
> - Put the tests on a separate subtest please to avoid interference if some
> changes are made to the previous tests/data.

Hi Tomás, now that I'm back in business I will look those things as you
suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Tomás Cohen Arazi  ---
Hi Johanna. Nice and clean work!

A few remarks from the QA POV:
- Our API design mojo is: 'As RESTful as we can'. In this context, we should
consider the 'checkout history of a patron' a resource, and as such it feels
more appropriate to put the patron id on the path, like in:

DELETE /patrons/{patron_id}/checkouts/history

Then we can reserve this route you were using for batch anonymizing :-D like in

DELETE /checkouts/history?q=more_complex_query_on_patrons

- There are some response definitions missing on the spec, (503 for maintenance
mode, 500 for internal server error, and so on).

- Put the tests on a separate subtest please to avoid interference if some
changes are made to the previous tests/data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Bouzid Fergani  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #95267|0   |1
is obsolete||

--- Comment #19 from Bouzid Fergani  ---
Created attachment 95465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95465=edit
Bug 18795: (follow-up) Unify error message to be same across codebase

In Koha/REST/V1/Patrons.pm the error message for not finding patron is
"Patron not found" so let's use the same here.

Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #95266|0   |1
is obsolete||

--- Comment #18 from Bouzid Fergani  ---
Created attachment 95464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95464=edit
Bug 18795: (follow-up) Check whether patrons exists before deleting history

Running $patrons->anonymise_issue_history after checking patrons
exists is more logical even though $patrons->anonymise_issue_history()
can handle 0 patrons returned in the search. Also this way we don't
have to run anonymise_issue_history() code unless needed, thus making
the code finish faster.

Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Bouzid Fergani  changed:

   What|Removed |Added

  Attachment #95265|0   |1
is obsolete||

--- Comment #17 from Bouzid Fergani  ---
Created attachment 95463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95463=edit
Bug 18795: DELETE (anonymize) checkout history

Anonymize patron's checkout history via REST API

DELETE /checkouts/history?patron_id=123

To test:
1. prove t/db_dependent/api/v1/checkouts.t
2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123
where 123 is your patron's borrowernumber

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Joonas Kylmälä 
Signed-off-by: Bouzid Fergani 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #95247|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #95248|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #95246|0   |1
is obsolete||

--- Comment #14 from Joonas Kylmälä  ---
Created attachment 95265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95265=edit
Bug 18795: DELETE (anonymize) checkout history

Anonymize patron's checkout history via REST API

DELETE /checkouts/history?patron_id=123

To test:
1. prove t/db_dependent/api/v1/checkouts.t
2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123
where 123 is your patron's borrowernumber

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #15 from Joonas Kylmälä  ---
Created attachment 95266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95266=edit
Bug 18795: (follow-up) Check whether patrons exists before deleting history

Running $patrons->anonymise_issue_history after checking patrons
exists is more logical even though $patrons->anonymise_issue_history()
can handle 0 patrons returned in the search. Also this way we don't
have to run anonymise_issue_history() code unless needed, thus making
the code finish faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #16 from Joonas Kylmälä  ---
Created attachment 95267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95267=edit
Bug 18795: (follow-up) Unify error message to be same across codebase

In Koha/REST/V1/Patrons.pm the error message for not finding patron is
"Patron not found" so let's use the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #94555|0   |1
is obsolete||

--- Comment #13 from Johanna Räisä  ---
Created attachment 95248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95248=edit
Bug 18795: (follow-up) Unify error message to be same  across codebase

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #94552|0   |1
is obsolete||

--- Comment #12 from Johanna Räisä  ---
Created attachment 95247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95247=edit
Bug 18795: (follow-up) Check whether patrons exists  before deleting history

Rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #94547|0   |1
is obsolete||

--- Comment #11 from Johanna Räisä  ---
Created attachment 95246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95246=edit
Bug 18795: DELETE (anonymize) checkout history

Rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Bouzid Fergani  changed:

   What|Removed |Added

 CC||bouzid.ferg...@inlibro.com

--- Comment #10 from Bouzid Fergani  ---
Hi,
Please rebase this patch.

Bug 18795 - REST API: DELETE (anonymize) checkout history

94547 - Bug 18795: DELETE (anonymize) checkout history
94552 - Bug 18795: (follow-up) Check whether patrons exists  before deleting
history
94555 - Bug 18795: (follow-up) Unify error message to be same  across codebase

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 18795: DELETE (anonymize) checkout history
Using index info to reconstruct a base tree...
M   Koha/REST/V1/Checkouts.pm
M   api/v1/swagger/paths.json
Falling back to patching base and 3-way merge...
Auto-merging api/v1/swagger/paths.json
CONFLICT (content): Merge conflict in api/v1/swagger/paths.json
Auto-merging Koha/REST/V1/Checkouts.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18795: DELETE (anonymize) checkout history
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-18795-DELETE-anonymize-checkout-history-G3iEhh.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #9 from Joonas Kylmälä  ---
(In reply to Johanna Räisä from comment #8)
> Created attachment 94555 [details] [review]
> Bug 18795: (follow-up) Unify error message to be same  across codebase
> 
> In Koha/REST/V1/Patrons.pm the error message for not finding patron is
> "Patron not found" so let's use the same here.
> 
> Signed-off-by: Johanna Raisa 

You added the error message change here also in the test (which I had
forgotten) so thanks for that little change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #94549|0   |1
is obsolete||

--- Comment #8 from Johanna Räisä  ---
Created attachment 94555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94555=edit
Bug 18795: (follow-up) Unify error message to be same  across codebase

In Koha/REST/V1/Patrons.pm the error message for not finding patron is
"Patron not found" so let's use the same here.

Signed-off-by: Johanna Raisa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #94548|0   |1
is obsolete||

--- Comment #7 from Johanna Räisä  ---
Created attachment 94552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94552=edit
Bug 18795: (follow-up) Check whether patrons exists  before deleting history

Running $patrons->anonymise_issue_history after checking patrons
exists is more logical even though $patrons->anonymise_issue_history()
can handle 0 patrons returned in the search. Also this way we don't
have to run anonymise_issue_history() code unless needed, thus making
the code finish faster.

Signed-off-by: Johanna Raisa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #5 from Joonas Kylmälä  ---
Created attachment 94548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94548=edit
Bug 18795: (follow-up) Check whether patrons exists before deleting history

Running $patrons->anonymise_issue_history after checking patrons
exists is more logical even though $patrons->anonymise_issue_history()
can handle 0 patrons returned in the search. Also this way we don't
have to run anonymise_issue_history() code unless needed, thus making
the code finish faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #6 from Joonas Kylmälä  ---
Created attachment 94549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94549=edit
Bug 18795: (follow-up) Unify error message to be same across codebase

In Koha/REST/V1/Patrons.pm the error message for not finding patron is
"Patron not found" so let's use the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #94533|0   |1
is obsolete||

--- Comment #4 from Joonas Kylmälä  ---
Created attachment 94547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94547=edit
Bug 18795: DELETE (anonymize) checkout history

Anonymize patron's checkout history via REST API

DELETE /checkouts/history?patron_id=123

To test:
1. prove t/db_dependent/api/v1/checkouts.t
2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123
where 123 is your patron's borrowernumber

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

  Attachment #64255|0   |1
is obsolete||

--- Comment #3 from Johanna Räisä  ---
Created attachment 94533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94533=edit
Bug 18795: DELETE (anonymize) checkout history

Anonymize patron's checkout history via REST API

DELETE /checkouts/history?patron_id=123

To test:
1. prove t/db_dependent/api/v1/checkouts.t
2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123
where 123 is your patron's borrowernumber

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Johanna Räisä  changed:

   What|Removed |Added

 CC||johanna.ra...@koha-suomi.fi
   Assignee|koha-b...@lists.koha-commun |johanna.ra...@koha-suomi.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Jonathan Druart  changed:

   What|Removed |Added

  Component|Web services|REST api
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #2 from Lari Taskula  ---
Doesn't apply at the moment and needs to be rebased once Bug 18137 and Bug
17005 move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

Lari Taskula  changed:

   What|Removed |Added

 Depends on||17005


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005
[Bug 17005] REST API: add routes to list checkouts history
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #1 from Lari Taskula  ---
Created attachment 64255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64255=edit
Bug 18795: DELETE (anonymize) checkout history

Anonymize patron's checkout history via REST API

DELETE /checkouts/history?borrowernumber=123

To test:
1. prove t/db_dependent/api/v1/checkoutshistory.t
2. Manually send DELETE request to /api/v1/checkouts/history?borrowernumber=123
   where 123 is your patron's borrowernumber

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/