[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #31 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #30 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Nick Clemens  changed:

   What|Removed |Added

  Attachment #74417|0   |1
is obsolete||

--- Comment #29 from Nick Clemens  ---
Created attachment 74609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74609=edit
Bug 18799: XSLTresultsdisplay hides the icons

If item-level_itypes is turned off and XSLTResultsDisplay is turned on,
biblio-level itemtype images are not shown in staff client search
results. This patch corrects the problem.

This patch also adds some markup and CSS to the itemtype image to make
it look a litte cleaner and work better in result sets in which some
titles have images and some don't.

To test, apply the patch and view the staff client search results page
with various settings:

- XSLT turned on and off
- item-level_itypes turned on and off
- noItemTypeImages turned on and off

Confirm that item type images are shown or not shown correctly according
to each setting.

The difference between this patch and the other patch currently on this
bug is that this patch continues the practice of hiding biblio-level
itemtype information when item-level_itypes is ON.

Signed-off-by: Victor Grousset 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73514|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #28 from Victor Grousset/tuxayo  ---
(sorry for comment 25, by searching how to get diff of a patch, I somehow
triggered a review...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #27 from Victor Grousset/tuxayo  ---
Created attachment 74417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74417=edit
Bug 18799: XSLTresultsdisplay hides the icons

If item-level_itypes is turned off and XSLTResultsDisplay is turned on,
biblio-level itemtype images are not shown in staff client search
results. This patch corrects the problem.

This patch also adds some markup and CSS to the itemtype image to make
it look a litte cleaner and work better in result sets in which some
titles have images and some don't.

To test, apply the patch and view the staff client search results page
with various settings:

- XSLT turned on and off
- item-level_itypes turned on and off
- noItemTypeImages turned on and off

Confirm that item type images are shown or not shown correctly according
to each setting.

The difference between this patch and the other patch currently on this
bug is that this patch continues the practice of hiding biblio-level
itemtype information when item-level_itypes is ON.

Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #26 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #22)
> I have tested, works well.
> 
> But with biblio level item type, the image is displayed right of record text.
> Without patch it is left.
> 
> Shouldn't it be CSS :
>   .result-biblio-itemtype { float: left; ...
> ?
> 
> I think display is better with image left.

In the end, no worries I'm ok with this change.
It can be customized with intranetusercss syspref anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #64728|0   |1
is obsolete||

--- Comment #25 from Victor Grousset/tuxayo  ---
Comment on attachment 64728
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64728
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

>From a971568d84bb64f5e1cdefda13192fac2653695f Mon Sep 17 00:00:00 2001
>From: Owen Leonard 
>Date: Thu, 15 Jun 2017 12:32:43 +
>Subject: [PATCH] Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons
>
>If item-level_itypes is turned off and  XSLTResultsDisplay is turned on,
>biblio-level itemtype images are not shown in staff client search
>results. This patch corrects the problem.
>
>This patch also adds some markup and CSS to the itemtype image to make
>it look a litte cleaner and work better in result sets in which some
>titles have images and some don't.
>
>To test, apply the patch and view the staff client search results page
>with various settings:
>
>- XSLT turned on and off
>- item-level_itypes turned on and off
>- noItemTypeImages turned on and off
>
>Confirm that item type images are shown or not shown correctly according
>to each setting.
>
>The difference between this patch and the other patch currently on this
>bug is that this patch continues the practice of hiding biblio-level
>itemtype information when item-level_itypes is ON.
>---
> koha-tmpl/intranet-tmpl/prog/css/staff-global.css  | 14 
> .../prog/en/modules/catalogue/results.tt   | 25 ++
> 2 files changed, 25 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css 
>b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
>index fb09d51..6d37ce3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css
>@@ -3007,3 +3007,17 @@ fieldset.rows + fieldset.action {
> #patron_search #filters {
> display: none;
> }
>+
>+.result-biblio-itemtype {
>+float: right;
>+padding: .5em;
>+margin: .5em;
>+font-size: 85%;
>+text-align: center;
>+}
>+
>+.result-biblio-itemtype img {
>+display: block;
>+margin: auto;
>+margin-bottom: 2px;
>+}
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt 
>b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index e035200..a8e8f44 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -529,6 +529,16 @@ var holdForPatron = function () {
>  id="bib[% SEARCH_RESULT.biblionumber %]" name="biblionumber" value="[% 
> SEARCH_RESULT.biblionumber %]" style="display:none" />
> 
> 
>+
>+[% UNLESS ( item_level_itypes ) %]
>+
>+[% IF !noItemTypeImages && 
>SEARCH_RESULT.imageurl %]
>+
>+[% END %]
>+[% SEARCH_RESULT.description %]
>+
>+[% END %]
>+
>   [% IF ( SEARCH_RESULT.XSLTResultsRecord ) %]
> [% SEARCH_RESULT.result_number %].
>   [% SEARCH_RESULT.XSLTResultsRecord %]
>@@ -549,22 +559,9 @@ var holdForPatron = function () {
> [% ELSE %]
> 
> [% END %]
>-
>-[% UNLESS ( item_level_itypes ) %]
>-[% IF !noItemTypeImages && 
>SEARCH_RESULT.imageurl %]
>-title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" 
>alt="[% SEARCH_RESULT.description %]" />
>-[% END %]
>-[% SEARCH_RESULT.description %]
>-[% END %]
>-[% SEARCH_RESULT.summary %]
>+[% SEARCH_RESULT.summary %]
> [% ELSE %]
> 
>-[% UNLESS ( item_level_itypes ) %]
>-[% IF !noItemTypeImages && 
>SEARCH_RESULT.imageurl %]
>-title="[% SEARCH_RESULT.description %]" 

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #24 from Victor Grousset/tuxayo  ---
Rebased the patch and solved conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #23 from Victor Grousset/tuxayo  ---
Created attachment 73514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73514=edit
Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons

If item-level_itypes is turned off and XSLTResultsDisplay is turned on,
biblio-level itemtype images are not shown in staff client search
results. This patch corrects the problem.

This patch also adds some markup and CSS to the itemtype image to make
it look a litte cleaner and work better in result sets in which some
titles have images and some don't.

To test, apply the patch and view the staff client search results page
with various settings:

- XSLT turned on and off
- item-level_itypes turned on and off
- noItemTypeImages turned on and off

Confirm that item type images are shown or not shown correctly according
to each setting.

The difference between this patch and the other patch currently on this
bug is that this patch continues the practice of hiding biblio-level
itemtype information when item-level_itypes is ON.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m
   Assignee|fridolin.som...@biblibre.co |victor.grous...@biblibre.co
   |m   |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|baptiste.wojtkowski@biblibr |fridolin.som...@biblibre.co
   |e.com   |m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #22 from Fridolin SOMERS  ---
I have tested, works well.

But with biblio level item type, the image is displayed right of record text.
Without patch it is left.

Shouldn't it be CSS :
  .result-biblio-itemtype { float: left; ...
?

I think display is better with image left.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #21 from Baptiste  ---
Hum ok.. So the settings:

item-level_itype => biblio record
XSLTDetailsDisplay,  XSLTListsDisplay ,  XSLTResultsDisplay  => "default"
DisplayIconsXSLT  => show 
noItemTypeImages => show

I can find icons on this page 
http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=384=scs_1499067251739

but with all others settings it works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #20 from M. Tompsett  ---
The issue isn't the XSLT sysprefs per say.
The issue is the item-itype system preference.
Toggle that in your testing too!
And make sure to have 2 records one with a biblio level item type and another
with an item level item type.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #19 from Fridolin SOMERS  ---
(In reply to Baptiste from comment #18)
> I don't see any difference between  DisplayIconsXSLT setted and not setted,
> in all case, all icons are displayed in intranet results and not in intranet
> details.
> 
> I tested on this sandbox because I have locally no Marc21:
> http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.
> pl?biblionumber=73=scs_1498810298579
> 
> If you have an idea of what went wrong.. ;)

XSLT sysprefs are empty on this sandbox, use "default"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Baptiste  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #18 from Baptiste  ---
I don't see any difference between  DisplayIconsXSLT setted and not setted, in
all case, all icons are displayed in intranet results and not in intranet
details.

I tested on this sandbox because I have locally no Marc21:
http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=73=scs_1498810298579

If you have an idea of what went wrong.. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #17 from Fridolin SOMERS  ---
(In reply to M. Tompsett from comment #13)
> I hope Fridolin doesn't mind, but I really believe Owen's patch is better.
> Style inlined is really bad HTML, not to mention Owen actually optimizes the
> UNLESS code into one spot and brings code consistency. It's beautiful, Owen.

No problem, this patch is indeed better, Owen is a first class patcher ;).

I'll test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #16 from M. Tompsett  ---
The icons should ALWAYS display, regardless of the item-itype system
preference, should they not?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #15 from M. Tompsett  ---
Comment on attachment 64279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64279
Bug 18799: Display icons on results.tt

Review of attachment 64279:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18799=64279)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ +532,5 @@
>   [% IF ( SEARCH_RESULT.XSLTResultsRecord ) %]
>  [% SEARCH_RESULT.result_number %].
> +[% IF !noItemTypeImages && 
> SEARCH_RESULT.imageurl %]
> + title="[% SEARCH_RESULT.description %]" style="float: left; margin: .1em;" 
> alt="[% SEARCH_RESULT.description %]" />
> +[% END %]

Now after testing, I get it. This will always display for XSLT records
regardless of the item-itype system preference setting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64279|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Comment on attachment 64279
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64279
Bug 18799: Display icons on results.tt

Owen's patch is better, in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #13 from M. Tompsett  ---
I hope Fridolin doesn't mind, but I really believe Owen's patch is better.
Style inlined is really bad HTML, not to mention Owen actually optimizes the
UNLESS code into one spot and brings code consistency. It's beautiful, Owen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 Status|In Discussion   |Needs Signoff

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64327|0   |1
is obsolete||
 CC||mtomp...@hotmail.com

--- Comment #10 from Owen Leonard  ---
I think this bug can be fixed in a different way which will be acceptable to
all. I'm preparing an alternate patch.

--- Comment #11 from Owen Leonard  ---
Created attachment 64327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64327=edit
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

Bug 18799 [ Alternate ] XSLTresultsdisplay hides the icons

If item-level_itypes is turned off and  XSLTResultsDisplay is turned on,
biblio-level itemtype images are not shown in staff client search
results. This patch corrects the problem.

This patch also adds some markup and CSS to the itemtype image to make
it look a litte cleaner and work better in result sets in which some
titles have images and some don't.

To test, apply the patch and view the staff client search results page
with various settings:

- XSLT turned on and off
- item-level_itypes turned on and off
- noItemTypeImages turned on and off

Confirm that item type images are shown or not shown correctly according
to each setting.

The difference between this patch and the other patch currently on this
bug is that this patch continues the practice of hiding biblio-level
itemtype information when item-level_itypes is ON.

--- Comment #12 from M. Tompsett  ---
Created attachment 64728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64728=edit
Alternate patch which preserves status quo on biblio vs. item-level itemtypes

Hopefully this makes Owen's patch a nice patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #9 from Jonathan Druart  
---
Regarding last comments another signoff is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr
   |ity.org |e.com
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #8 from Fridolin SOMERS  ---
(In reply to Owen Leonard from comment #6)
> This change doesn't make sense to me. Generally I think we consider
> biblio-level itemtype to be superseded by item-level itemtype when it comes
> to displaying itemtype information. I think without this patch it works
> correctly.

But in OPAC icons are displayed and in intranet if no XSLT.
Behavior with or without XSLT should be the same outside XSLT generate HTML
code.

One can always hide the icons with syspref noItemTypeImages.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Baptiste  changed:

   What|Removed |Added

   Assignee|baptiste.wojtkowski@biblibr |koha-b...@lists.koha-commun
   |e.com   |ity.org

--- Comment #7 from Baptiste  ---
In this case, shouldn't the non XSLT interface hide those icons to ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr
   |ity.org |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #6 from Owen Leonard  ---
This change doesn't make sense to me. Generally I think we consider
biblio-level itemtype to be superseded by item-level itemtype when it comes to
displaying itemtype information. I think without this patch it works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Fridolin SOMERS  ---
I signoff.

Anyone outside Biblibre is free to sign also.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #64277|0   |1
is obsolete||

--- Comment #4 from Fridolin SOMERS  ---
Created attachment 64279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64279=edit
Bug 18799: Display icons on results.tt

TEST PLAN:
1 - Set xsltresultsdisplay to default
2 - Search something in the catalog => you shouldn't see any icon
3 - Apply patch
4 - Search again, you shall see icons beside the titles of resources

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #3 from Fridolin SOMERS  ---
You must have item-level_itypes on biblio record and biblio.itemtypes defined
on itemtypes with an icon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Baptiste  changed:

   What|Removed |Added

  Attachment #64276|0   |1
is obsolete||

--- Comment #2 from Baptiste  ---
Created attachment 64277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64277=edit
Bug 18799: Display icons on results.tt

TEST PLAN:
1 - Set xsltresultsdisplay to default
2 - Search something in the catalog => you shouldn't see any icon
3 - Apply patch
4 - Search again, you shall see icons beside the titles of resources

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

--- Comment #1 from Baptiste  ---
Created attachment 64276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64276=edit
Bub 18799: Display icons on results.tt

TEST PLAN:
1 - Set xsltresultsdisplay to default
2 - Search something in the catalog => you shouldn't see any icon
3 - Apply patch
4 - Search again, you shall see icons beside the titles of resources

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/