[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #23 from Marcel de Rooy --- Bug 18980 has been pushed. This bug can be closed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > I would let the option anyway and add a note if it does not apply currently. Will put this approach under report 18980 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18980 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #21 from Jonathan Druart --- I would let the option anyway and add a note if it does not apply currently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > Marcel, I do not think we should hide "Anyone seeing this list" for private > lists. > > First, you are not allowed to select it before sharing it. That can be a bit > annoying if you know you are going to share it after you created it. > > Then imagine the following workflow: > - Create a private list > - Share it > - Edit the list to let your friend adding items to this list > - Remove the share > => When you edit the list you do not see the correct value, "Anyone seeing > this list" is not displayed whereas it is the value of the field. I added it because users apparently get confused from options that are not relevant. See bug 10865 in the past. We could choose another approach too: [1] Tell the user that no one else sees the list (when this applies). [2] Replace Anyone by Owner when we delete the last share. This does not resolve your first remark. Any feedback ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- Marcel, I do not think we should hide "Anyone seeing this list" for private lists. First, you are not allowed to select it before sharing it. That can be a bit annoying if you know you are going to share it after you created it. Then imagine the following workflow: - Create a private list - Share it - Edit the list to let your friend adding items to this list - Remove the share => When you edit the list you do not see the correct value, "Anyone seeing this list" is not displayed whereas it is the value of the field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Bug 18834 depends on bug 18228, which changed state. Bug 18228 Summary: Make list permissions easier to use/understand https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #18 from Marcel de Rooy --- (In reply to Lee Jamison from comment #17) > Signed-off-by: Lee Jamison Great! Thanks, Lee. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Lee Jamison changed: What|Removed |Added Attachment #64525|0 |1 is obsolete|| --- Comment #17 from Lee Jamison --- Created attachment 64548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64548&action=edit Bug 18834: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Lee Jamison changed: What|Removed |Added Attachment #64523|0 |1 is obsolete|| --- Comment #16 from Lee Jamison --- Created attachment 64547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64547&action=edit Bug 18834: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Lee Jamison changed: What|Removed |Added Attachment #64521|0 |1 is obsolete|| --- Comment #14 from Lee Jamison --- Created attachment 64545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64545&action=edit Bug 18834: Show "Anyone seeing this list" permission only for shared and public lists This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea of bug 10865, but with one difference: It does not completely hide all permissions if adding public or shared lists is not allowed; it only hides the Anyone-permission if it is not relevant. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Disable OpacAllowPublicListCreation and OpacAllowSharingPrivateLists. [2] Edit a public list in staff view. Toggle permissions, save and reopen to check the value you saved. Is Anyone permission included? [3] Edit a private list (without shares) in staff. Is Anyone excluded? [4] Edit the same private list in OPAC. Is Anyone excluded too? [5] Enable OpacAllowPublicListCreation. Create a public list in OPAC. [6] Edit this list in OPAC. Do you see Anyone? Save with Anyone. [7] Change category to Private. Save and reopen. Is Owner selected now, and Anyone excluded? [8] Enable sharing. Share a list and accept it with another user. [You can also manually insert a record in virtualshelfshares.] Edit the list in OPAC as owner. Do you see Anyone? Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Works as directed in the test plan. updatedatabase.pl must be run in order for Datatables_Virtualshelves.t to pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Lee Jamison changed: What|Removed |Added Attachment #64522|0 |1 is obsolete|| --- Comment #15 from Lee Jamison --- Created attachment 64546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64546&action=edit Bug 18834: Add js to dynamically alter the permission options If we we move from Private to Public or vice versa, this actually has an impact on the permissions combo. If we go back to a private list without shares, we could remove Anyone. If we switch to public and the list had no shares, we could add Anyone. Handled in a js sub AdjustPerms, triggered by onchange of the category combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category. Check if the permissions combo changes accordingly. [2] Edit a public list in staff. Toggle category and check. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64524|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 64525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64525&action=edit Bug 18834: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64510|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 64521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64521&action=edit Bug 18834: Show "Anyone seeing this list" permission only for shared and public lists This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea of bug 10865, but with one difference: It does not completely hide all permissions if adding public or shared lists is not allowed; it only hides the Anyone-permission if it is not relevant. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Disable OpacAllowPublicListCreation and OpacAllowSharingPrivateLists. [2] Edit a public list in staff view. Toggle permissions, save and reopen to check the value you saved. Is Anyone permission included? [3] Edit a private list (without shares) in staff. Is Anyone excluded? [4] Edit the same private list in OPAC. Is Anyone excluded too? [5] Enable OpacAllowPublicListCreation. Create a public list in OPAC. [6] Edit this list in OPAC. Do you see Anyone? Save with Anyone. [7] Change category to Private. Save and reopen. Is Owner selected now, and Anyone excluded? [8] Enable sharing. Share a list and accept it with another user. [You can also manually insert a record in virtualshelfshares.] Edit the list in OPAC as owner. Do you see Anyone? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64520|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 64524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64524&action=edit Bug 18834: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64511|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 64522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64522&action=edit Bug 18834: Add js to dynamically alter the permission options If we we move from Private to Public or vice versa, this actually has an impact on the permissions combo. If we go back to a private list without shares, we could remove Anyone. If we switch to public and the list had no shares, we could add Anyone. Handled in a js sub AdjustPerms, triggered by onchange of the category combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category. Check if the permissions combo changes accordingly. [2] Edit a public list in staff. Toggle category and check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64512|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 64523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64523&action=edit Bug 18834: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #8 from Marcel de Rooy --- Created attachment 64520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64520&action=edit Bug 18834: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #7 from Marcel de Rooy --- Rebased (see 18214) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64491|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 64510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64510&action=edit Bug 18834: Show "Anyone seeing this list" permission only for shared and public lists This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea of bug 10865, but with one difference: It does not completely hide all permissions if adding public or shared lists is not allowed; it only hides the Anyone-permission if it is not relevant. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Disable OpacAllowPublicListCreation and OpacAllowSharingPrivateLists. [2] Edit a public list in staff view. Toggle permissions, save and reopen to check the value you saved. Is Anyone permission included? [3] Edit a private list (without shares) in staff. Is Anyone excluded? [4] Edit the same private list in OPAC. Is Anyone excluded too? [5] Enable OpacAllowPublicListCreation. Create a public list in OPAC. [6] Edit this list in OPAC. Do you see Anyone? Save with Anyone. [7] Change category to Private. Save and reopen. Is Owner selected now, and Anyone excluded? [8] Enable sharing. Share a list and accept it with another user. [You can also manually insert a record in virtualshelfshares.] Edit the list in OPAC as owner. Do you see Anyone? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64492|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 64511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64511&action=edit Bug 18834: Add js to dynamically alter the permission options If we we move from Private to Public or vice versa, this actually has an impact on the permissions combo. If we go back to a private list without shares, we could remove Anyone. If we switch to public and the list had no shares, we could add Anyone. Handled in a js sub AdjustPerms, triggered by onchange of the category combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category. Check if the permissions combo changes accordingly. [2] Edit a public list in staff. Toggle category and check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Attachment #64493|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 64512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64512&action=edit Bug 18834: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #3 from Marcel de Rooy --- Created attachment 64493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64493&action=edit Bug 18834: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #2 from Marcel de Rooy --- Created attachment 64492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64492&action=edit Bug 18834: Add js to dynamically alter the permission options If we we move from Private to Public or vice versa, this actually has an impact on the permissions combo. If we go back to a private list without shares, we could remove Anyone. If we switch to public and the list had no shares, we could add Anyone. Handled in a js sub AdjustPerms, triggered by onchange of the category combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category. Check if the permissions combo changes accordingly. [2] Edit a public list in staff. Toggle category and check. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 --- Comment #1 from Marcel de Rooy --- Created attachment 64491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64491&action=edit Bug 18834: Show "Anyone seeing this list" permission only for shared and public lists This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea of bug 10865, but with one difference: It does not completely hide all permissions if adding public or shared lists is not allowed; it only hides the Anyone-permission if it is not relevant. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Disable OpacAllowPublicListCreation and OpacAllowSharingPrivateLists. [2] Edit a public list in staff view. Toggle permissions, save and reopen to check the value you saved. Is Anyone permission included? [3] Edit a private list (without shares) in staff. Is Anyone excluded? [4] Edit the same private list in OPAC. Is Anyone excluded too? [5] Enable OpacAllowPublicListCreation. Create a public list in OPAC. [6] Edit this list in OPAC. Do you see Anyone? Save with Anyone. [7] Change category to Private. Save and reopen. Is Owner selected now, and Anyone excluded? [8] Enable sharing. Share a list and accept it with another user. [You can also manually insert a record in virtualshelfshares.] Edit the list in OPAC as owner. Do you see Anyone? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18838 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10865 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834 Marcel de Rooy changed: What|Removed |Added Depends on||18228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 [Bug 18228] Make list permissions easier to use/understand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
