[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Needs Signoff   |Failed QA

--- Comment #9 from Marcel de Rooy  ---
If we remove this comment, some day somebody wonders again why we do not use
the translated description.
So instead of removing I would opt for adding a legitimate reason why we really
do not want a translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #8 from M. Tompsett  ---
(In reply to Marc Véron from comment #7)
> Maybe there is a misunderstanding.

Perhaps. I'll just remove myself for the conversation. Please continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #7 from Marc Véron  ---
(In reply to M. Tompsett from comment #5)
> (In reply to Marc Véron from comment #4)
> > To have translated item descriptions you can go to 
> > Home > Administration > Item types > Modify item type 'BK' 
> > 
> > There you have a link 'Translate into other languages' to create 
> > translations
> > To test, you can even 'translate' for English to overwrite the original
> > description.
> 
> But that is by overwriting the actual description. Not by just changing the
> language selected. I think the comment was about having a way to po-i-size
> it. Patch is okay, but it's really a commentary on having DB translations,
> not just templates, I think.

Maybe there is a misunderstanding.

- Item types are defined by the library (or loaded together with the example
values, in the language choosen for installation).
- When defining an item type, the library can define translations for other
(installed) languages as well. E.g. in Switzerland a library could define an
item type with code 'BUCH' and the description "Buch" for German and the
translated descriptions "Livre" for French and "Libro" for Italian
- The (translated) description appears (is overlayed) depending on the language
selected by the user.
- You can not po-i-size that because the library defines the item types.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Did you check the description Marc gave? The value will change with switching
the language if you have configured it.

It doesn't make sense to have po files for configurable values that are
different for each library. The new way to save the translations in a separate
table works better, as every library can change it any time. I think Marc's
patch is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #5 from M. Tompsett  ---
(In reply to Marc Véron from comment #4)
> To have translated item descriptions you can go to 
> Home > Administration > Item types > Modify item type 'BK' 
> 
> There you have a link 'Translate into other languages' to create translations
> To test, you can even 'translate' for English to overwrite the original
> description.

But that is by overwriting the actual description. Not by just changing the
language selected. I think the comment was about having a way to po-i-size it.
Patch is okay, but it's really a commentary on having DB translations, not just
templates, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #4 from Marc Véron  ---
(In reply to M. Tompsett from comment #3)
> (In reply to Marc Véron from comment #1)
> > (In reply to Marc Véron from comment #0)
> > > Translated itemtype description is not used in display of Holds queue
> >  
> > Translated itemtype descriptions display OK, but there is a superfluous
> > comment in circ/view_holdsqueue.pl
> 
> It is because your description is translated in the first place, or does
> switching languages actually give a valid translation for each language?

To have translated item descriptions you can go to 
Home > Administration > Item types > Modify item type 'BK' 

There you have a link 'Translate into other languages' to create translations
To test, you can even 'translate' for English to overwrite the original
description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
(In reply to Marc Véron from comment #1)
> (In reply to Marc Véron from comment #0)
> > Translated itemtype description is not used in display of Holds queue
>  
> Translated itemtype descriptions display OK, but there is a superfluous
> comment in circ/view_holdsqueue.pl

It is because your description is translated in the first place, or does
switching languages actually give a valid translation for each language?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

--- Comment #2 from Marc Véron  ---
Created attachment 64726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64726=edit
Bug 18881:  Remove comment about translated itemtype description in
circ/view_holdsqueue.pl

This patch removes a superfluous FIXME comment.

To test:
Compare code, verify that comment correctly is removed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18881] Remove comment about translated itemtype description in circ/ view_holdsqueue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881

Marc Véron  changed:

   What|Removed |Added

Summary|Remove comment about|Remove comment about
   |translated description in   |translated itemtype
   |itemtype|description in
   |circ/view_holdsqueue.pl |circ/view_holdsqueue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/