subject:"\[Koha\-bugs\] \[Bug 18904\] Advanced editor \- Rancor \- Add authority support"

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-09-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21448


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448
[Bug 21448] Field 606 doesn't add multiple x subfields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-05-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904
Bug 18904 depends on bug 14769, which changed state.

Bug 14769 Summary: Authorities merge: Set correct indicators in biblio field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-05-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #66 from Nick Clemens  ---
Enhancement, not backported for 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-05-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-05-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This patchset adds the  |This patchset adds the
  release notes|ability to search for and   |ability to search for and
   |link authorities in the |link authorities in the
   |advanced cataloging editor. |advanced cataloging editor.
   |When  editing a record  |When  editing a record
   |staff can press |staff can press
   |'Shift+Ctrl+L' to launch|'Shift+Ctrl+L' to launch
   |the authorities search. |the authorities search.
   |Choosing a recorrd will |Choosing a record will
   |update the field and add a  |update the field and add a
   |subfield 9 for linking. |subfield 9 for linking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-05-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This patchset adds the
  release notes||ability to search for and
   ||link authorities in the
   ||advanced cataloging editor.
   ||When  editing a record
   ||staff can press
   ||'Shift+Ctrl+L' to launch
   ||the authorities search.
   ||Choosing a recorrd will
   ||update the field and add a
   ||subfield 9 for linking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-05-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #65 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20571


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20571
[Bug 20571] Rancor - Keybinding configuration per users
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|19538   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538
[Bug 19538] Advanced editor - Rancor - Move syspref from labs to cataloging and
remove experimental note
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74023|0   |1
is obsolete||

--- Comment #63 from Katrin Fischer  ---
Created attachment 74055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74055=edit
Bug 18904: (follow-up) Use Ctrl+Shift+L

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #64 from Katrin Fischer  ---
Retested with the new shortcut - works great for me. Docs were adjusted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #62 from Nick Clemens  ---
Created attachment 74023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74023=edit
Bug 18904: (follow-up) Use Ctrl+Shift+L

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #61 from Owen Leonard  ---
Why not use Ctrl-Shift-L?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #60 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #59)
> It's weird that nobody else raised this problem before. Do not you think the
> behavior is very bad?

I remember commenting on problems with some shortcuts in Firefox on another
report. Whether the key worked, depended on the field having focus iirc..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #59 from Jonathan Druart  
---
It's weird that nobody else raised this problem before. Do not you think the
behavior is very bad?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #58 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #57)
> CTRL+L made sense logically in English L = 'Link'

In Chinese too btw L = Autholities

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #57 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #56)
> But... why CTRL+L?
> It's used by the browser the select the address bar, so if I CTRL+L the
> popup opens, but the address bar is selected when I close it.

CTRL+L made sense logically in English L = 'Link'

I tried my best but can't seem to prevent the default action in the browser

I am happy to change it if you have a suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #56 from Jonathan Druart  
---
But... why CTRL+L?
It's used by the browser the select the address bar, so if I CTRL+L the popup
opens, but the address bar is selected when I close it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #55 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #54)
> Tiny remark:
> 
> +my $authtags = Koha::MarcSubfieldStructures->search({ authtypecode => {
> '!=' => '' }, 'frameworkcode' => '' });
> 
> Does Rancor only look at default framework ?
> (Actually, this is quite fundamental, but this report is not about the
> relation between Rancor and the frameworks.)

(13:20:46) ashimema: I do think Rancor entirely ignores frameworks.. always
been somewhat surprised by that too marcelr ;)
(13:20:56) kidclamp: yes, it does only use default framework, anything edited
becomes defauilt framework
(13:22:43) cait: marcelr: it's true, it only looks at default - there is no
need for most of the settings if you jsut type on a blank screen

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #54 from Marcel de Rooy  ---
Tiny remark:

+my $authtags = Koha::MarcSubfieldStructures->search({ authtypecode => { '!='
=> '' }, 'frameworkcode' => '' });

Does Rancor only look at default framework ?
(Actually, this is quite fundamental, but this report is not about the relation
between Rancor and the frameworks.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #53 from Marcel de Rooy  ---
Created attachment 73857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73857=edit
Bug 18904: (QA follow-up) Do not put authid in searchbox of blinddetail

Adding trivial test if subfield equals 9.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #49 from Marcel de Rooy  ---
Created attachment 73853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73853=edit
Bug 18904: (follow-up) Retrieve subfield in the order they are stored

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #51 from Marcel de Rooy  ---
Created attachment 73855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73855=edit
Bug 18904: (follow-up) Set indicators and correct js path

TO test:
1 - Have an authority with some indicators
2 - Link a field in rancor to that authority
3 - See that you get some indicators (same in unimarc, diff in marc21)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #52 from Marcel de Rooy  ---
Created attachment 73856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73856=edit
Bug 18904: (follow-up) Rebase onto 14769

Signed-off-by: Marcel de Rooy 
Amended: simplified if-then-else around cur_field.setIndicator[12].

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #48 from Marcel de Rooy  ---
Created attachment 73852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73852=edit
Bug 18904: (follow-up) Fix whitespace and don't use hardcoded path

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #50 from Marcel de Rooy  ---
Created attachment 73854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73854=edit
Bug 18904: Remove debugging code

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #73766|0   |1
is obsolete||
  Attachment #73767|0   |1
is obsolete||
  Attachment #73768|0   |1
is obsolete||
  Attachment #73769|0   |1
is obsolete||
  Attachment #73770|0   |1
is obsolete||
  Attachment #73771|0   |1
is obsolete||

--- Comment #47 from Marcel de Rooy  ---
Created attachment 73851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73851=edit
Bug 18904: Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #46 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||14769


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
[Bug 14769] Authorities merge: Set correct indicators in biblio field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #44 from Nick Clemens  ---
Created attachment 73770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73770=edit
Bug 18904 (follow-up) Set indicators and correct js path

TO test:
1 - Have an authority with some indicators
2 - Link a field in rancor to that authority
3 - See that you get some indicators (same in unimarc, diff in marc21)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #45 from Nick Clemens  ---
Created attachment 73771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73771=edit
Bug 18904: (follow-up) Rebase onto 14769

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #43 from Nick Clemens  ---
Created attachment 73769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73769=edit
Bug 18904 - Remove debugging code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #41 from Nick Clemens  ---
Created attachment 73767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73767=edit
Bug 18904: Followup - fix whitespace and don't use hardcoded path

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #42 from Nick Clemens  ---
Created attachment 73768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73768=edit
Bug 18904: Followup - Retrieve subfield in the order they are stored

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

  Attachment #73693|0   |1
is obsolete||
  Attachment #73694|0   |1
is obsolete||
  Attachment #73695|0   |1
is obsolete||
  Attachment #73696|0   |1
is obsolete||
  Attachment #73697|0   |1
is obsolete||

--- Comment #40 from Nick Clemens  ---
Created attachment 73766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73766=edit
Bug 18904 - Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #39 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #34)
> but Rancor is still a lower priority?

Just for completeness: Do not take this too strongly :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||19538


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538
[Bug 19538] Advanced editor - Rancor - Move syspref from labs to cataloging and
remove experimental note
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #38 from Katrin Fischer  ---
I think we don't need to keep discussing - let's try to find a way out of the
maze. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #37 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #35)
> Since Rancor is no longer experimental
Bug 19538 is still in discussion?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #36 from Katrin Fischer  ---
I'll help with testing too, just tell me what you come up with. 
I can also test this again, if there is a follow-up. I am just out for QA since
I did the initial sign-off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #35 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #34)
> Could you have a look please at bug 14769 ?
> We have a conflict re blinddetail*
> Bug 14769 solves some issues for authority controlled indicators (including
> $2 subfields), working with the regular editor. I may be biased, but Rancor
> is still a lower priority?
> Could you follow the changes there ?

I don't think we should prioritize here, but I am biased too. Since Rancor is
no longer experimental and this is just the feature missing that keeps a lot of
people from using it. I view this one as a very important candidate for 18.05.

First patch here: 6.7.2017, Sign off: 10.8.2017
Review here has already been done a few times with prompt follow-ups and never
mentioning a possible conflict. 

For bug 14769
Current patch set: 26.1.2018, Sign off: 5.3.2018

That said, please talk to each other to figure out how to resolve this conflict
best - if we work together, it will hopefully be possible to have both patches
go in before the deadline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #34 from Marcel de Rooy  ---
Could you have a look please at bug 14769 ?
We have a conflict re blinddetail*
Bug 14769 solves some issues for authority controlled indicators (including $2
subfields), working with the regular editor. I may be biased, but Rancor is
still a lower priority?
Could you follow the changes there ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #33 from Nick Clemens  ---
Created attachment 73697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73697=edit
Bug 18904 (follow-up) Set indicators and correct js path

TO test:
1 - Have an authority with some indicators
2 - Link a field in rancor to that authority
3 - See that you get some indicators (same in unimarc, diff in marc21)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #31 from Nick Clemens  ---
Created attachment 73695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73695=edit
Bug 18904: Followup - Retrieve subfield in the order they are stored

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #32 from Nick Clemens  ---
Created attachment 73696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73696=edit
Bug 18904 - Remove debugging code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #30 from Nick Clemens  ---
Created attachment 73694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73694=edit
Bug 18904: Followup - fix whitespace and don't use hardcoded path

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

  Attachment #71748|0   |1
is obsolete||
  Attachment #71749|0   |1
is obsolete||
  Attachment #71750|0   |1
is obsolete||
  Attachment #71751|0   |1
is obsolete||
  Attachment #72920|0   |1
is obsolete||

--- Comment #29 from Nick Clemens  ---
Created attachment 73693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73693=edit
Bug 18904 - Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-03-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #28 from Nick Clemens  ---
Created attachment 72920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72920=edit
Bug 18904 (follow-up) Set indicators and correct js path

TO test:
1 - Have an authority with some indicators
2 - Link a field in rancor to that authority
3 - See that you get some indicators (same in unimarc, diff in marc21)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-03-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-03-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Signed Off  |Failed QA

--- Comment #27 from Josef Moravec  ---
Just tested now and have some issues/comments:

1) The indicators are not taken from authority to biblio, if this can add
indicators, it'll take advantage of bug 14769 once it is pushed

2) cataloguing.js link in the template cataloguing/editor.tt should use [%
theme %] instead of hadcoded "prog" in path. And should have attached _[%
KOHA_VERSION %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #24 from Nick Clemens  ---
Created attachment 71749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71749=edit
Bug 18904: Followup - fix whitespace and don't use hardcoded path

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

  Attachment #71747|0   |1
is obsolete||

--- Comment #23 from Nick Clemens  ---
Created attachment 71748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71748=edit
Bug 18904 - Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #25 from Nick Clemens  ---
Created attachment 71750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71750=edit
Bug 18904: Followup - Retrieve subfield in the order they are stored

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #26 from Nick Clemens  ---
Created attachment 71751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71751=edit
Bug 18904 - Remove debugging code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68678|0   |1
is obsolete||
  Attachment #68679|0   |1
is obsolete||
  Attachment #68680|0   |1
is obsolete||
  Attachment #68681|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 71747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71747=edit
Bug 18904 - Remove debugging code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2018-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-11-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #21 from Nick Clemens  ---
Missed adding dependency on 19537, that should clear up the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-11-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Depends on||19537


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537
[Bug 19537] Authorities search doesn't correctly populate subfield $2 source of
heading
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-11-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Marcel de Rooy  ---
 FAIL   authorities/blinddetail-biblio-search.pl
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   SKIP   spelling
   FAIL   valid
Global symbol "%subfields" requires explicit package name
authorities/blinddetail-biblio-search.pl had compilation
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19538,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19537

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #19 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #14)
> I have the impression that you fix one or two bugs here in blinddetail that
> should go on their own. Please split.
Created 19537 - the subfield order patch makes no sense on its own as it has no
effect outside of rancor

> Also I would rather not change blinddetail for Rancor, but replace what you
> need on the receiving side. (experimental etc.)
I looked, but it doesn't make sense to me to move it - blinddetail does the
replacement of the text in the record and we do similar fixing of text for
traditional editor

> +index = 'rancor';//+field.line+'|'+field.tag;
> Debugging leftover?
Fixed


> +[%- FOREACH authtag = authtags -%]
> Hmm. Doesnt look nice.
Not sure what part you don't like here? Makes sense to me

> +   var cur_field =
> opener.opener.jQuery(".CodeMirror")[0].CodeMirror.marceditor.
> getCurrentField();
> What are you doing here exactly ? Why opener.opener ?
Same as traditional - editor opens auth-finder which opens blinddetail -
opener.opener gets us back to the place we called from (the editor)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #17 from Nick Clemens  ---
Created attachment 68680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68680=edit
Bug 18904: Followup - Retrieve subfield in the order they are stored

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #16 from Nick Clemens  ---
Created attachment 68679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68679=edit
Bug 18904: Followup - fix whitespace and don't use hardcoded path

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #18 from Nick Clemens  ---
Created attachment 68681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68681=edit
Bug 18904 - Remove debugging code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

  Attachment #65863|0   |1
is obsolete||
  Attachment #65864|0   |1
is obsolete||
  Attachment #65865|0   |1
is obsolete||
  Attachment #65866|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 68678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68678=edit
Bug 18904 - Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Marcel de Rooy  ---
Interesting feature! Rancor absolutely needs it.
I have the impression that you fix one or two bugs here in blinddetail that
should go on their own. Please split.
Also I would rather not change blinddetail for Rancor, but replace what you
need on the receiving side. (experimental etc.)

+index = 'rancor';//+field.line+'|'+field.tag;
Debugging leftover?

+[%- FOREACH authtag = authtags -%]
Hmm. Doesnt look nice.

+   var cur_field =
opener.opener.jQuery(".CodeMirror")[0].CodeMirror.marceditor.getCurrentField();
What are you doing here exactly ? Why opener.opener ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #13 from Marcel de Rooy  ---
Added a 600, opened blinddetail with Ctrl+L, chose an authority, and got:
Internal server error: Can't call method "authtypecode" on an undefined value
at /usr/share/koha/masterclone/authorities/blinddetail-biblio-search.pl line
77.

Not giving up yet. This probably was bad data. But as said before on other
reports if nobody checks what ->find returns, you get this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-10-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #12 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #8 from Katrin Fischer  ---
Created attachment 65863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65863=edit
[SIGNED OFF] Bug 18904 - Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #11 from Katrin Fischer  ---
Created attachment 65866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65866=edit
[SIGNED OFF] Bug 18904 - QA Followup - fix and restore subfield 2 code

I pulled it in last patch as it hasn't been working, offering this if
that funcationality should be fixed instead of removed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #10 from Katrin Fischer  ---
Created attachment 65865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65865=edit
[SIGNED OFF] Bug 18904 - QA Followup

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #9 from Katrin Fischer  ---
Created attachment 65864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65864=edit
[SIGNED OFF] Bug 18904 - QA followup

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64860|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64859|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65145|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Small patch |Medium patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65144|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #7 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #4)
> 1) RTL languages
Yes, this is an issue, but it is an issue with the editor in general. RTL
fields end up making the whole line RTL  - this has consequences since the
editor mostly assumes LTR for field/subfield info. I think this shoudl be a
separate bug. On a positive note - while linking to an RTL authority looks
wrong, the information is saved correctly (view in the standard editor to see
fields are read correctly after save)

> 2) Sequence of subfields is 'random'
This should now be fixed - we were using a hash to store subfield info and
losing order - it should now be preserved as saved in the record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #5 from Nick Clemens  ---
Created attachment 65144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65144=edit
Bug 18904 - QA Followup

Use subfields in the order they are stored.

This patch removes use of an intermediate hash for storing values. Order
of subfields as obtained from authority is now preserved.

Also removes useless code that was intended to set $2 subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #6 from Nick Clemens  ---
Created attachment 65145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65145=edit
Bug 18904 - QA Followup - fix and restore subfield 2 code

I pulled it in last patch as it hasn't been working, offering this if
that funcationality should be fixed instead of removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Love it! One day there might be an advanced editor for authorities too, but for
now this is a big missing piece to make the new editor useful for more
libraries.

Found 2 problems:

1) RTL languages

If the heading is in an RTL language, the field order will be messed up after
linking it. Is that something we could fix? Entering the data manually and
without linking seems to work ok.

To test:
- Enter something Arabic or Hebrew in 100$a
- Ctrl+L to link to an authority record
- Either select the right one or add a new one with heading in RTL language
- Link
- Verify display in 100$a is not looking right
- Try to save record, receive error message

2) Sequence of subfields is 'random'

This is actually a quite important one, as the sequence really matters.

To test:
- Add an authority records using $a $b $c $d
- Link record
- Subfields will appear out of order (if not, try again, might be random)

In my first test, I ended up with: 
100 _ _ ‡d1983-‡bIII‡aDuck, Donald‡cPope‡94

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #3 from Nick Clemens  ---
Created attachment 64860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64860=edit
Bug 18904 - QA followup

Fix whitespace/tabs
use [% interface %] not intranet-tmpl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #2 from Lee Jamison  ---
Patch applies and works correctly based on test plan. QA Tools fails (see
below). Once these are corrected I'd be happy to sign off!

Processing files before patches
|>| 4 / 4 (100.00%)
Processing files after patches
|>| 4 / 4 (100.00%)

 OK cataloguing/editor.pl
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

 OK koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
   FAIL   forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
   FAIL   forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

--- Comment #1 from Nick Clemens  ---
Created attachment 64859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64859=edit
Bug 18904 - Advanced editor - Rancor - Add authority support

This patchset adds the ability to use the authorities search to select
or clear fields in the advanced editor

To test:
 1 - Open a record in the advanced cataloging editor
 2 - Press 'Ctrl+L' while in a field that shuold not be linked to
authorities (300 for instance)
 3 - Nothing should happen
 4 - Try it in a field that should be linked
 5 - You should get the authorities pop-up
 6 - Values in pop-up should be populated from values in record (as
appropriate for authority type)
 7 - Correct authority type should be selected ( PERSO_NAME for 100,
TOPIC_TERM for 650, etc.)
 8 - Press 'Clear', field should be blanked
 9 - Search again and select an authority
10 - Field should be correctly populated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support

2017-07-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

93 matches

Mail list logo