[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20893


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893
[Bug 20893] batchRebuildItemsTables.pl has incorrect parameter
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #16 from Fridolin SOMERS  ---
Enhancement not pushed to 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks|18927   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927
[Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||18927


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927
[Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #15 from Jonathan Druart  
---
Then let's remove them :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #14 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #10)
> (In reply to Marcel de Rooy from comment #9)
> > Who is going to run these scripts still? And from what version? Should we
> > still have in master ??
> 
> People upgrading from Koha 2.2?

Sure? :)
My impression was that you would call 22_to_30 from 3.0.
So we should not be needing them in master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #13 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #10)
> (In reply to Marcel de Rooy from comment #9)
> > Who is going to run these scripts still? And from what version? Should we
> > still have in master ??
> 
> People upgrading from Koha 2.2?

People upgrading from 2.2 to current are likely to stop at 3.4 before
proceeding to master due to items being stored differently, at least that was
my impression. That's why I didn't change those two scripts. But I suppose it
can't hurt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #11 from Jonathan Druart  
---
Created attachment 66477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66477=edit
Bug 19040: Update 2 occurrences of GetMarcBiblio in 22_to_30

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #9)
> Who is going to run these scripts still? And from what version? Should we
> still have in master ??

People upgrading from Koha 2.2?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #9 from Marcel de Rooy  ---
carp 'GetMarcBiblio called without parameters';
Should be a Koha::Exception.
See coding guidelines.

git grep -E "GetMarcBiblio\s*\(\s*\$"
No results as expected
git grep -E "GetMarcBiblio\s*\(\s*[^{]"
misc/migration_tools/22_to_30/missing090field.pl: my $record =
GetMarcBiblio($biblionumber);
misc/migration_tools/22_to_30/rebuild_unimarc_100.pl:my $record =
GetMarcBiblio($biblionumber);
[OK] t/Biblio.t:warning_is { $ret = GetMarcBiblio() }

Who is going to run these scripts still? And from what version? Should we still
have in master ??

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #66145|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 66457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66457=edit
Bug 19040: Refactor GetMarcBiblio parameters

Change parameters to a hashref.

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 
Looks good to me.
Two calls in migration_tools/22_to_30 still in old style.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

--- Comment #8 from Marcel de Rooy  ---
Created attachment 66458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66458=edit
Bug 19040: [QA Follow-up] Adjust embed_items parameter in showdiffmarc

Trivial adjustment

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040

M. Tompsett  changed:

   What|Removed |Added

Summary|Refactor|Change prototype of
   |C4::Biblio::GetMarcBiblio   |C4::Biblio::GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/