[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #13 from Fridolin Somers --- Looks like still valid. Should also impact C4/Barcodes/hbyymmincr.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #1 from Blou --- Created attachment 66019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66019&action=edit Bug 19113 - Barcode value builder not working with numeric branchcode The regexp for the value builder 'hbyymmincr' doesn't allow for numerics in the branchcode, so the nextnum found is always 0 and multiple Add always generate the same barcode. This simply allow for numerics within the regex. Test - It's a bit complicated. You need - all your branchcodes to be numerics (01,02,71...) - all barcodes to already be a bunch of numbers - Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one. - Find an item in the pro-search, - New -> New Item - Click on the 'p' to have the value builder create the next barcode. - Without the patch, the query won't have found anything, so it'll suggest xx0001 - Click Add. It reprensent the form to enter another one. - Click on the 'p' edit box, it'll offer you again xx0001 With the patch, it'll offer valid ones everytime. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What|Removed |Added CC||francois.charbonnier@inlibr ||o.com, ||philippe.blo...@inlibro.com Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15239 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What|Removed |Added Attachment #67981|0 |1 is obsolete|| --- Comment #5 from Blou --- Comment on attachment 67981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67981 Bug 15685: DBRev 17.06.00.014 patch 15685 for bug 19113. Sounds wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What|Removed |Added Attachment #66019|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What|Removed |Added Attachment #66019|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #6 from Blou --- Created attachment 75509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509&action=edit Bug 19113: Barcode value builder not working with numeric branchcode The regexp for the value builder 'hbyymmincr' doesn't allow for numerics in the branchcode, so the nextnum found is always 0 and multiple Add always generate the same barcode. This simply allow for numerics within the regex. Test - It's a bit complicated. You need - all your branchcodes to be numerics (01,02,71...) - all barcodes to already be a bunch of numbers - Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one. - Find an item in the pro-search, - New -> New Item - Click on the 'p' to have the value builder create the next barcode. - Without the patch, the query won't have found anything, so it'll suggest xx0001 - Click Add. It reprensent the form to enter another one. - Click on the 'p' edit box, it'll offer you again xx0001 With the patch, it'll offer valid ones everytime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Blou --- Still don't understand why the patch had been replaced by Bug 15685. So setting back to need sign off. Not signed off yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett --- (In reply to Blou from comment #6) > Test > - It's a bit complicated. You need >- all your branchcodes to be numerics (01,02,71...) Who sets their branch codes to purely numerical values?! >- all barcodes to already be a bunch of numbers > - Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one. Support for the hbyymm barcode methodology has been deprecated, as far as I know. Why even fix it for this bizarre case? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113
--- Comment #9 from M. Tompsett ---
Comment on attachment 75509
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509
Bug 19113: Barcode value builder not working with numeric branchcode
Review of attachment 75509:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19113&attachment=75509)
-
::: C4/Barcodes/ValueBuilder.pm
@@ +49,4 @@
> my $month = $args->{mon};
> my $query = "SELECT MAX(CAST(SUBSTRING(barcode,-4) AS signed)) AS number
> FROM items WHERE barcode REGEXP ?";
> my $sth = C4::Context->dbh->prepare($query);
> +$sth->execute("^[-a-zA-Z0-9]{1,}$year$month");
If this regexp is wrong, there are several other places it is wrong too. See
C4/Barcodes/hbyymmincr.pm db_max for example.
See also line 142:
This format is deprecated and SHOULD NOT BE USED.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #10 from Katrin Fischer --- We have branchcodes that are a mix of capitals and numbers, so I don't think it's an odd case. The problem with deprecating something just in the source code is that people will still use it - how would they know? The code comments have been there forever, maybe we need to fix it or remove it, but don't leave it like that? Least we could do is add a note to the GUI about it being problematic or deprecated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #11 from Blou --- I'm biased and in full agreement with Katryn here. The code does exist and is in use. And there is certainly no good way to deprecate it. So why not just fix it. It's a few adjustments in the code, one patch to push, some or many users happy. There are many valid reasons to refuse an enhancement, and some good reasons to refuse a fix (ugly, could break other things, badly engineered...). But I don't think deprecation is valid, unless there's a plan behind it. What is the suggested PRACTICAL alternative for the user at this point? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #12 from M. Tompsett --- (In reply to M. Tompsett from comment #9) > If this regexp is wrong, there are several other places it is wrong too. See > C4/Barcodes/hbyymmincr.pm db_max for example. You can't just fix this place then. Fix them all. And include a full test plan. I'll look at it if all places are fixed, and I remember to get back to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 PTFS Europe Sandboxes changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@ptfs-europe.com --- Comment #2 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Jon Knight -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #66019|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 67981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67981&action=edit Bug 15685: DBRev 17.06.00.014 Signed-off-by: Jonathan Druart Signed-off-by: Jon Knight -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- Please correct the attachments here and add proper signoff line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
