[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Doesn't apply cleanly to 16.11.x - please provide a rebased patch if you want this to be included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Fridolin SOMERSchanged: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 --- Comment #6 from Magnus Enger--- This is needed in 17.05.x too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Marcel de Rooychanged: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | --- Comment #4 from Marcel de Rooy --- Magnus: Assignee field ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Marcel de Rooychanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Marcel de Rooychanged: What|Removed |Added Attachment #66256|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 66463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66463=edit Bug 19134: C4::SMS falils on long driver name Code in C4::SMS takes the part of the SMS::Send-driver that comes after SMS::Send and tries to turn it into part of a path to a YAML file that can contain additional parameters to SMS::Send. The current code works for e.g. SMS::Send::A::B, but if there is one or more extra names, it fails to turn :: into /. So we have: SMS::Send::A::B-> SMS/Send/A/B SMS::Send::A::B::C -> SMS/Send/A/B::C This patch makes sure all occurrences of :: are turned into /, by adding a "g" modifier at the end of the regex. Testing: Testing this preperly would take a whole lot of setup for a very small change. I would suggest that the following two oneliners are enough to demonstrate that the change makes sense: $ perl -e '$x = "a::b::c"; $x =~ s|::|/|; print $x, "\n";' $ perl -e '$x = "a::b::c"; $x =~ s|::|/|g; print $x, "\n";' So: - Check that the output of these oneliners make sense - Check that the patch changes the code in a similar way to the change from the first oneliner to the second. Signed-off-by: Aleisha Amohia Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Aleisha Amohiachanged: What|Removed |Added Attachment #66151|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 66256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66256=edit [SIGNED-OFF] Bug 19134: C4::SMS falils on long driver name Code in C4::SMS takes the part of the SMS::Send-driver that comes after SMS::Send and tries to turn it into part of a path to a YAML file that can contain additional parameters to SMS::Send. The current code works for e.g. SMS::Send::A::B, but if there is one or more extra names, it fails to turn :: into /. So we have: SMS::Send::A::B-> SMS/Send/A/B SMS::Send::A::B::C -> SMS/Send/A/B::C This patch makes sure all occurrences of :: are turned into /, by adding a "g" modifier at the end of the regex. Testing: Testing this preperly would take a whole lot of setup for a very small change. I would suggest that the following two oneliners are enough to demonstrate that the change makes sense: $ perl -e '$x = "a::b::c"; $x =~ s|::|/|; print $x, "\n";' $ perl -e '$x = "a::b::c"; $x =~ s|::|/|g; print $x, "\n";' So: - Check that the output of these oneliners make sense - Check that the patch changes the code in a similar way to the change from the first oneliner to the second. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Aleisha Amohiachanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 --- Comment #1 from Magnus Enger--- Created attachment 66151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66151=edit Bug 19134 - C4::SMS falils on long driver name Code in C4::SMS takes the part of the SMS::Send-driver that comes after SMS::Send and tries to turn it into part of a path to a YAML file that can contain additional parameters to SMS::Send. The current code works for e.g. SMS::Send::A::B, but if there is one or more extra names, it fails to turn :: into /. So we have: SMS::Send::A::B-> SMS/Send/A/B SMS::Send::A::B::C -> SMS/Send/A/B::C This patch makes sure all occurrences of :: are turned into /, by adding a "g" modifier at the end of the regex. Testing: Testing this preperly would take a whole lot of setup for a very small change. I would suggest that the following two oneliners are enough to demonstrate that the change makes sense: $ perl -e '$x = "a::b::c"; $x =~ s|::|/|; print $x, "\n";' $ perl -e '$x = "a::b::c"; $x =~ s|::|/|g; print $x, "\n";' So: - Check that the output of these oneliners make sense - Check that the patch changes the code in a similar way to the change from the first oneliner to the second. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19134] C4::SMS does not handle drivers with more than two names well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19134 Magnus Engerchanged: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/